bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

views: Fix Chrome style browser RequestFocus behavior (fixes #3819)

Browse Source 
Fix implementation of CefBrowserView::RequestFocus for Chrome style
browsers. Match Alloy style behavior of requesting browser focus
(calling OnSetFocus) after initial navigation. Add CefView::HasFocus
and CefWindow::GetFocusedView that can be used in combination with
CefWindow::IsActive to determine global keyboard focus.

Update sample applications for the new behavior.

In cefclient:
- Browser receives initial focus via ViewsWindow::RequestBrowserFocus.
- When running with `--show-overlay-browser` (see #3790):
  - Give initial focus to the overlay browser.
  - Change the overlay popout shortcut to CTRL+SHIFT+O to avoid
    assigning focus to the menu in the main window.
  - Switching from overlay in the main window to popout browser
    window will give focus to the popout browser.
  - Switching from popout browser to overlay will leave current focus
    unchanged (e.g. in the overlay browser, or somewhere else). User
    gesture to activate the main window may be required on Mac/Linux.
- When running with `--no-active` don't give initial focus to either
  browser.

In cefsimple:
- Browser receives initial focus via default handling.
This commit is contained in:
Marshall Greenblatt
2024-11-05 14:58:45 -05:00
parent b070564ec5
commit b660522983
53 changed files with 652 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/cefclient/browser/client_handler.h
View File

@ -32,9 +32,7 @@ class ClientHandler : public BaseClientHandler,
public CefDisplayHandler,
public CefDownloadHandler,
public CefDragHandler,
public CefFocusHandler,
public CefKeyboardHandler,
public CefLoadHandler,
public CefPermissionHandler {
public:
// Implement this interface to receive notification of ClientHandler
@ -82,6 +80,9 @@ class ClientHandler : public BaseClientHandler,
virtual void OnSetDraggableRegions(
const std::vector<CefDraggableRegion>& regions) = 0;
// Called on the UI thread to optionally handle the browser gaining focus.
virtual bool OnSetFocus(cef_focus_source_t source) { return false; }
// Set focus to the next/previous control.
virtual void OnTakeFocus(bool next) {}
@ -111,9 +112,7 @@ class ClientHandler : public BaseClientHandler,
CefRefPtr<CefDisplayHandler> GetDisplayHandler() override { return this; }
CefRefPtr<CefDownloadHandler> GetDownloadHandler() override { return this; }
CefRefPtr<CefDragHandler> GetDragHandler() override { return this; }
CefRefPtr<CefFocusHandler> GetFocusHandler() override { return this; }
CefRefPtr<CefKeyboardHandler> GetKeyboardHandler() override { return this; }
CefRefPtr<CefLoadHandler> GetLoadHandler() override { return this; }
CefRefPtr<CefPermissionHandler> GetPermissionHandler() override {
return this;
}
@ -423,9 +422,6 @@ class ClientHandler : public BaseClientHandler,
// True if an editable field currently has focus.
bool focus_on_editable_field_ = false;
// True for the initial navigation after browser creation.
bool initial_navigation_ = true;
DISALLOW_COPY_AND_ASSIGN(ClientHandler);
};