bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add CommandLineTest.IgnorePrefixes unit test to verify prefix removal behavior (issue #1778)

This commit is contained in:
Marshall Greenblatt 2015-12-03 17:13:14 -05:00
parent aaa5563582
commit b4a159a1da
1 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/unittests/command_line_unittest.cc
View File

@ -10,7 +10,9 @@
namespace { namespace {
void VerifyCommandLine(CefRefPtr<CefCommandLine> command_line) { void VerifyCommandLine(CefRefPtr<CefCommandLine> command_line,
const char* expected_arg1 = "arg1",
const char* expected_arg2 = "arg 2") {
std::string program = command_line->GetProgram(); std::string program = command_line->GetProgram();
EXPECT_EQ("test.exe", program); EXPECT_EQ("test.exe", program);
@ -67,9 +69,9 @@ void VerifyCommandLine(CefRefPtr<CefCommandLine> command_line) {
command_line->GetArguments(args); command_line->GetArguments(args);
EXPECT_EQ((size_t)2, args.size()); EXPECT_EQ((size_t)2, args.size());
std::string arg0 = args[0]; std::string arg0 = args[0];
EXPECT_EQ("arg1", arg0); EXPECT_EQ(expected_arg1, arg0);
std::string arg1 = args[1]; std::string arg1 = args[1];
EXPECT_EQ("arg 2", arg1); EXPECT_EQ(expected_arg2, arg1);
command_line->Reset(); command_line->Reset();
EXPECT_FALSE(command_line->HasSwitches()); EXPECT_FALSE(command_line->HasSwitches());
@ -119,3 +121,23 @@ TEST(CommandLineTest, Manual) {
VerifyCommandLine(command_line); VerifyCommandLine(command_line);
} }
// Test that any prefixes included with the switches are ignored.
TEST(CommandLineTest, IgnorePrefixes) {
CefRefPtr<CefCommandLine> command_line = CefCommandLine::CreateCommandLine();
EXPECT_TRUE(command_line.get() != NULL);
command_line->SetProgram("test.exe");
command_line->AppendSwitch("-switch1");
command_line->AppendSwitchWithValue("--switch2", "val2");
command_line->AppendSwitchWithValue("-switch3", "val3");
command_line->AppendSwitchWithValue("-switch4", "val 4");
// Prefixes will not be removed from arguments.
const char arg1[] = "-arg1";
const char arg2[] = "--arg 2";
command_line->AppendArgument(arg1);
command_line->AppendArgument(arg2);
VerifyCommandLine(command_line, arg1, arg2);
}