Allow empty username parameter to CefAuthCallback::Continue (issue #2275)

This commit is contained in:
Marshall Greenblatt 2018-03-28 19:29:28 -04:00
parent a1f47abaf6
commit b44919e3c5
3 changed files with 5 additions and 13 deletions

View File

@ -50,7 +50,7 @@ class CefAuthCallback : public virtual CefBaseRefCounted {
/// ///
// Continue the authentication request. // Continue the authentication request.
/// ///
/*--cef(capi_name=cont,optional_param=password)--*/ /*--cef(capi_name=cont,optional_param=username,optional_param=password)--*/
virtual void Continue(const CefString& username, virtual void Continue(const CefString& username,
const CefString& password) = 0; const CefString& password) = 0;

View File

@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory // implementations. See the translator.README.txt file in the tools directory
// for more information. // for more information.
// //
// $hash=1adf0d1a89ad232ddb0daa468082980906dc5931$ // $hash=3980a914cf9a6be45acabff6e35c2849b51b27dd$
// //
#include "libcef_dll/cpptoc/auth_callback_cpptoc.h" #include "libcef_dll/cpptoc/auth_callback_cpptoc.h"
@ -26,11 +26,7 @@ void CEF_CALLBACK auth_callback_cont(struct _cef_auth_callback_t* self,
DCHECK(self); DCHECK(self);
if (!self) if (!self)
return; return;
// Verify param: username; type: string_byref_const // Unverified params: username, password
DCHECK(username);
if (!username)
return;
// Unverified params: password
// Execute // Execute
CefAuthCallbackCppToC::Get(self)->Continue(CefString(username), CefAuthCallbackCppToC::Get(self)->Continue(CefString(username),

View File

@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory // implementations. See the translator.README.txt file in the tools directory
// for more information. // for more information.
// //
// $hash=de11e537658b94c48a2d2be344399186bd679f5b$ // $hash=0464376fa24627e57280c81408ff70c3c2768021$
// //
#include "libcef_dll/ctocpp/auth_callback_ctocpp.h" #include "libcef_dll/ctocpp/auth_callback_ctocpp.h"
@ -24,11 +24,7 @@ void CefAuthCallbackCToCpp::Continue(const CefString& username,
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING // AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
// Verify param: username; type: string_byref_const // Unverified params: username, password
DCHECK(!username.empty());
if (username.empty())
return;
// Unverified params: password
// Execute // Execute
_struct->cont(_struct, username.GetStruct(), password.GetStruct()); _struct->cont(_struct, username.GetStruct(), password.GetStruct());