From b2f5ab6cd23cb15606195f9df0004ebbd2c003cb Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Mon, 31 Mar 2025 12:11:33 -0400 Subject: [PATCH] Fix crash on invalid chromeMediaSourceId (fixes #3911) --- libcef/browser/media_access_query.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libcef/browser/media_access_query.cc b/libcef/browser/media_access_query.cc index 89d20fc55..f5eae2d93 100644 --- a/libcef/browser/media_access_query.cc +++ b/libcef/browser/media_access_query.cc @@ -215,8 +215,10 @@ class CefMediaAccessQuery { content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN, -1 /* webrtc::kFullDesktopScreenId */); } - video_devices.emplace_back(request_.video_type, media_id.ToString(), - "Screen"); + if (media_id.type != content::DesktopMediaID::TYPE_NONE) { + video_devices.emplace_back(request_.video_type, media_id.ToString(), + "Screen"); + } } blink::mojom::StreamDevicesSetPtr stream_devices_set =