From b28a6145a1d74c30118c16ebde3e8bfd1e5305fc Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Wed, 10 May 2017 12:16:53 -0400 Subject: [PATCH] Make the CefAuthCallback::Continue password parameter optional (issue #1928) --- include/cef_auth_callback.h | 2 +- libcef_dll/cpptoc/auth_callback_cpptoc.cc | 5 +---- libcef_dll/ctocpp/auth_callback_ctocpp.cc | 5 +---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/cef_auth_callback.h b/include/cef_auth_callback.h index ca511fdc4..09b04d4c4 100644 --- a/include/cef_auth_callback.h +++ b/include/cef_auth_callback.h @@ -50,7 +50,7 @@ class CefAuthCallback : public virtual CefBaseRefCounted { /// // Continue the authentication request. /// - /*--cef(capi_name=cont)--*/ + /*--cef(capi_name=cont,optional_param=password)--*/ virtual void Continue(const CefString& username, const CefString& password) =0; diff --git a/libcef_dll/cpptoc/auth_callback_cpptoc.cc b/libcef_dll/cpptoc/auth_callback_cpptoc.cc index aab0f644d..9ca31259a 100644 --- a/libcef_dll/cpptoc/auth_callback_cpptoc.cc +++ b/libcef_dll/cpptoc/auth_callback_cpptoc.cc @@ -28,10 +28,7 @@ void CEF_CALLBACK auth_callback_cont(struct _cef_auth_callback_t* self, DCHECK(username); if (!username) return; - // Verify param: password; type: string_byref_const - DCHECK(password); - if (!password) - return; + // Unverified params: password // Execute CefAuthCallbackCppToC::Get(self)->Continue( diff --git a/libcef_dll/ctocpp/auth_callback_ctocpp.cc b/libcef_dll/ctocpp/auth_callback_ctocpp.cc index 1b8810f96..11dd7ff9e 100644 --- a/libcef_dll/ctocpp/auth_callback_ctocpp.cc +++ b/libcef_dll/ctocpp/auth_callback_ctocpp.cc @@ -27,10 +27,7 @@ void CefAuthCallbackCToCpp::Continue(const CefString& username, DCHECK(!username.empty()); if (username.empty()) return; - // Verify param: password; type: string_byref_const - DCHECK(!password.empty()); - if (password.empty()) - return; + // Unverified params: password // Execute _struct->cont(_struct,