From a6a3da2d537713584b9cac878f07c9658b024828 Mon Sep 17 00:00:00 2001
From: Marshall Greenblatt <magreenblatt@gmail.com>
Date: Wed, 8 Feb 2017 12:35:21 -0500
Subject: [PATCH] Allow empty value param to CefSetCrashKeyValue (issue #1995)

---
 include/cef_crash_util.h                 | 2 +-
 libcef_dll/libcef_dll.cc                 | 5 +----
 libcef_dll/wrapper/libcef_dll_wrapper.cc | 5 +----
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/include/cef_crash_util.h b/include/cef_crash_util.h
index 09eeb2f65..d9ecfe351 100644
--- a/include/cef_crash_util.h
+++ b/include/cef_crash_util.h
@@ -138,7 +138,7 @@ bool CefCrashReportingEnabled();
 ///
 // Sets or clears a specific key-value pair from the crash metadata.
 ///
-/*--cef()--*/
+/*--cef(optional_param=value)--*/
 void CefSetCrashKeyValue(const CefString& key, const CefString& value);
 
 #endif  // CEF_INCLUDE_CEF_CRASH_UTIL_H_
diff --git a/libcef_dll/libcef_dll.cc b/libcef_dll/libcef_dll.cc
index cc1aafe56..1f037f927 100644
--- a/libcef_dll/libcef_dll.cc
+++ b/libcef_dll/libcef_dll.cc
@@ -411,10 +411,7 @@ CEF_EXPORT void cef_set_crash_key_value(const cef_string_t* key,
   DCHECK(key);
   if (!key)
     return;
-  // Verify param: value; type: string_byref_const
-  DCHECK(value);
-  if (!value)
-    return;
+  // Unverified params: value
 
   // Execute
   CefSetCrashKeyValue(
diff --git a/libcef_dll/wrapper/libcef_dll_wrapper.cc b/libcef_dll/wrapper/libcef_dll_wrapper.cc
index 08ddbd830..c4a1b5595 100644
--- a/libcef_dll/wrapper/libcef_dll_wrapper.cc
+++ b/libcef_dll/wrapper/libcef_dll_wrapper.cc
@@ -403,10 +403,7 @@ CEF_GLOBAL void CefSetCrashKeyValue(const CefString& key,
   DCHECK(!key.empty());
   if (key.empty())
     return;
-  // Verify param: value; type: string_byref_const
-  DCHECK(!value.empty());
-  if (value.empty())
-    return;
+  // Unverified params: value
 
   // Execute
   cef_set_crash_key_value(