bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't set "always on top" style for child CefWindows. 

As of https://crrev.com/9e653328e3 the Views framework will apply the "always
on top" (WS_EX_TOPMOST) style by default to widgets created with TYPE_MENU. CEF
uses this type in CefWindowView::CreateWidget to support child windows that are
not clipped to the parent window bounds (currently indicated by returning a
parent window from CefWindowDelegate::GetParentWindow and setting |is_menu| to
true).

Not setting "always on top" shouldn't be a problem except in cases where some
other window is already "always on top" and the child CefWindow is expected to
overlay that window. For this reason any menus created using ShowMenu will
continue to have the "always on top" style.
This commit is contained in:
Marshall Greenblatt 2019-10-18 14:24:29 +02:00
parent 01e75761d3
commit a4b6ef577e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcef/browser/views/window_view.cc
View File

@ -268,6 +268,10 @@ void CefWindowView::CreateWidget() {
if (is_menu) { if (is_menu) {
// Don't clip the window to parent bounds. // Don't clip the window to parent bounds.
params.type = views::Widget::InitParams::TYPE_MENU; params.type = views::Widget::InitParams::TYPE_MENU;
// Don't set "always on top" for the window.
params.z_order = ui::ZOrderLevel::kNormal;
can_activate = can_activate_menu; can_activate = can_activate_menu;
if (can_activate_menu) if (can_activate_menu)
params.activatable = views::Widget::InitParams::ACTIVATABLE_YES; params.activatable = views::Widget::InitParams::ACTIVATABLE_YES;