bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix excessive CPU usage with external and multi-threaded message loops (fixes issue #2809, fixes issue #2970).

This commit is contained in:
Masako Toda 2020-07-21 16:26:41 +00:00 committed by Marshall Greenblatt
parent 034bd641de
commit a3919cb0ec
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libcef/browser/browser_message_loop.cc
View File

@ -70,19 +70,21 @@ class MessagePumpExternal : public base::MessagePumpForUI {
// is_immediate() returns true if the next task is ready right away. // is_immediate() returns true if the next task is ready right away.
more_immediate_work = next_work_info.is_immediate(); more_immediate_work = next_work_info.is_immediate();
if (!more_immediate_work) { if (!more_immediate_work) {
// DoIdleWork() returns true if idle work was all done.
more_idle_work = !delegate->DoIdleWork();
// Check the next PendingTask's |delayed_run_time|. // Check the next PendingTask's |delayed_run_time|.
// is_max() returns true if there are no more immediate nor delayed tasks. // is_max() returns true if there are no more immediate nor delayed tasks.
more_delayed_work = !next_work_info.delayed_run_time.is_max(); more_delayed_work = !next_work_info.delayed_run_time.is_max();
if (more_delayed_work && !more_idle_work) { if (more_delayed_work) {
// The only remaining work that we know about is the PendingTask. // The only remaining work that we know about is the PendingTask.
// Consider the run time for that task in the time slice calculation. // Consider the run time for that task in the time slice calculation.
*next_run_time = next_work_info.delayed_run_time; *next_run_time = next_work_info.delayed_run_time;
} }
} }
if (!more_immediate_work && !more_delayed_work) {
// DoIdleWork() returns true if idle work was all done.
more_idle_work = !delegate->DoIdleWork();
}
return more_immediate_work || more_idle_work || more_delayed_work; return more_immediate_work || more_idle_work || more_delayed_work;
} }