Remove methods that modify cookie storage at runtime (see issue #2622).

This change removes cookie and request handler functionality that will not
supported by the NetworkService. Specifically, it is no longer possible to
change cookie storage locations at runime by returning a different
CefCookieManager for an already initialized CefRequestContext. After this change
you will need to use a separate CefRequestContext when creating a CefBrowser if
you require separate cookie storage.

The following methods have been removed:
- CefCookieManager::CreateManager
- CefCookieManager::GetBlockingManager
- CefCookieManager::SetStoragePath
- CefRequestContextHandler::GetCookieManager

The following methods have been renamed:
- CefRequestContext::GetDefaultCookieManager to GetCookieManager.

This change substantially simplifies the network implementation in CEF because
it is no longer necessary to proxy objects that are normally owned by Chromium.
Chromium patches that are no longer necessary will be removed as a follow-up
commit.

To test: Verify that `ceftests --gtest_filter=-PluginTest.*` pass with
NetworkService disabled. Plugin tests will be fixed in a follow-up commit.
This commit is contained in:
Marshall Greenblatt
2019-03-22 18:11:51 -04:00
parent 6b2c1fe969
commit a23e845244
66 changed files with 1175 additions and 3939 deletions

View File

@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=4a4744491587c5f5b1ce8726d8dd08ad04646b92$
// $hash=7c87ef36c39355a02bb9544b8228acac7a7abee9$
//
#include <dlfcn.h>
@ -198,12 +198,6 @@ typedef struct _cef_command_line_t* (*cef_command_line_get_global_ptr)();
typedef struct _cef_cookie_manager_t* (
*cef_cookie_manager_get_global_manager_ptr)(
struct _cef_completion_callback_t*);
typedef struct _cef_cookie_manager_t* (
*cef_cookie_manager_get_blocking_manager_ptr)();
typedef struct _cef_cookie_manager_t* (*cef_cookie_manager_create_manager_ptr)(
const cef_string_t*,
int,
struct _cef_completion_callback_t*);
typedef struct _cef_drag_data_t* (*cef_drag_data_create_ptr)();
typedef struct _cef_image_t* (*cef_image_create_ptr)();
typedef struct _cef_menu_model_t* (*cef_menu_model_create_ptr)(
@ -580,9 +574,6 @@ struct libcef_pointers {
cef_command_line_get_global_ptr cef_command_line_get_global;
cef_cookie_manager_get_global_manager_ptr
cef_cookie_manager_get_global_manager;
cef_cookie_manager_get_blocking_manager_ptr
cef_cookie_manager_get_blocking_manager;
cef_cookie_manager_create_manager_ptr cef_cookie_manager_create_manager;
cef_drag_data_create_ptr cef_drag_data_create;
cef_image_create_ptr cef_image_create;
cef_menu_model_create_ptr cef_menu_model_create;
@ -797,8 +788,6 @@ int libcef_init_pointers(const char* path) {
INIT_ENTRY(cef_command_line_create);
INIT_ENTRY(cef_command_line_get_global);
INIT_ENTRY(cef_cookie_manager_get_global_manager);
INIT_ENTRY(cef_cookie_manager_get_blocking_manager);
INIT_ENTRY(cef_cookie_manager_create_manager);
INIT_ENTRY(cef_drag_data_create);
INIT_ENTRY(cef_image_create);
INIT_ENTRY(cef_menu_model_create);
@ -1309,20 +1298,6 @@ struct _cef_cookie_manager_t* cef_cookie_manager_get_global_manager(
return g_libcef_pointers.cef_cookie_manager_get_global_manager(callback);
}
NO_SANITIZE("cfi-icall")
struct _cef_cookie_manager_t* cef_cookie_manager_get_blocking_manager() {
return g_libcef_pointers.cef_cookie_manager_get_blocking_manager();
}
NO_SANITIZE("cfi-icall")
struct _cef_cookie_manager_t* cef_cookie_manager_create_manager(
const cef_string_t* path,
int persist_session_cookies,
struct _cef_completion_callback_t* callback) {
return g_libcef_pointers.cef_cookie_manager_create_manager(
path, persist_session_cookies, callback);
}
NO_SANITIZE("cfi-icall") struct _cef_drag_data_t* cef_drag_data_create() {
return g_libcef_pointers.cef_drag_data_create();
}