bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow empty value param to CefSetCrashKeyValue (issue #1995)

This commit is contained in:
Marshall Greenblatt 2017-02-08 12:35:21 -05:00
parent aa398d8798
commit 9dd0ca2661
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/cef_crash_util.h
View File

@ -138,7 +138,7 @@ bool CefCrashReportingEnabled();
/// ///
// Sets or clears a specific key-value pair from the crash metadata. // Sets or clears a specific key-value pair from the crash metadata.
/// ///
/*--cef()--*/ /*--cef(optional_param=value)--*/
void CefSetCrashKeyValue(const CefString& key, const CefString& value); void CefSetCrashKeyValue(const CefString& key, const CefString& value);
#endif // CEF_INCLUDE_CEF_CRASH_UTIL_H_ #endif // CEF_INCLUDE_CEF_CRASH_UTIL_H_

5
libcef_dll/libcef_dll.cc
View File

@ -411,10 +411,7 @@ CEF_EXPORT void cef_set_crash_key_value(const cef_string_t* key,
DCHECK(key); DCHECK(key);
if (!key) if (!key)
return; return;
// Verify param: value; type: string_byref_const // Unverified params: value
DCHECK(value);
if (!value)
return;
// Execute // Execute
CefSetCrashKeyValue( CefSetCrashKeyValue(

5
libcef_dll/wrapper/libcef_dll_wrapper.cc
View File

@ -403,10 +403,7 @@ CEF_GLOBAL void CefSetCrashKeyValue(const CefString& key,
DCHECK(!key.empty()); DCHECK(!key.empty());
if (key.empty()) if (key.empty())
return; return;
// Verify param: value; type: string_byref_const // Unverified params: value
DCHECK(!value.empty());
if (value.empty())
return;
// Execute // Execute
cef_set_crash_key_value( cef_set_crash_key_value(