bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable dangling ptr check for PendingRequest::request_ (fixes #3743) 

The InterceptedRequestHandlerWrapper object may be deleted (likely via
~InterceptedRequest) while the task to call
InterceptedRequestHandlerWrapper:ContinueCreateURLLoaderNetworkObserver
is still pending. That binding holds a
WeakPtr<InterceptedRequestHandlerWrapper> (which is now nullptr)
resulting in the bound std::unique_ptr<PendingRequest> being deleted
while still holding a raw_ptr<network::ResourceRequest> to the
already-deleted object. This is always safe (raw_ptr will never be
dereferenced) because of the WeakPtr check.
This commit is contained in:
Marshall Greenblatt 2024-07-17 14:35:30 -04:00
parent da971da381
commit 9ca230c960
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libcef/browser/net_service/resource_request_handler_wrapper.cc
View File

@ -147,7 +147,7 @@ class InterceptedRequestHandlerWrapper : public InterceptedRequestHandler {
} }
const int32_t id_; const int32_t id_;
raw_ptr<network::ResourceRequest> request_; raw_ptr<network::ResourceRequest, DisableDanglingPtrDetection> request_;
const bool request_was_redirected_; const bool request_was_redirected_;
OnBeforeRequestResultCallback callback_; OnBeforeRequestResultCallback callback_;
CancelRequestCallback cancel_callback_; CancelRequestCallback cancel_callback_;