Fix compilation errors from shared message unit tests (see issue #3126)

This commit is contained in:
Nik Pavlov
2022-07-19 14:09:10 +00:00
committed by Marshall Greenblatt
parent ba947d842a
commit 987b932a19
2 changed files with 20 additions and 17 deletions

View File

@ -140,15 +140,18 @@ class ThresholdTestHandler final : public SingleLoadTestHandler {
TrackCallback got_notify_; TrackCallback got_notify_;
}; };
using CharTestHandler = CefRefPtr<ThresholdTestHandler<char>>; using CharTestHandler = ThresholdTestHandler<char>;
using WCharTestHandler = CefRefPtr<ThresholdTestHandler<wchar_t>>; using CharTestHandlerPtr = CefRefPtr<CharTestHandler>;
using WCharTestHandler = ThresholdTestHandler<wchar_t>;
using WCharTestHandlerPtr = CefRefPtr<WCharTestHandler>;
} // namespace } // namespace
TEST(MessageRouterTest, ThresholdMessageUnderSuccessCallback) { TEST(MessageRouterTest, ThresholdMessageUnderSuccessCallback) {
const auto UnderThreshold = kMessageSizeThreshold - 1; const auto UnderThreshold = kMessageSizeThreshold - 1;
CharTestHandler handler = CharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::SUCCESS, UnderThreshold, 'A'); new CharTestHandler(TestType::SUCCESS, UnderThreshold, 'A');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -157,8 +160,8 @@ TEST(MessageRouterTest, ThresholdMessageUnderSuccessCallback) {
} }
TEST(MessageRouterTest, ThresholMessageExactdSuccessCallback) { TEST(MessageRouterTest, ThresholMessageExactdSuccessCallback) {
CharTestHandler handler = CharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::SUCCESS, kMessageSizeThreshold, 'A'); new CharTestHandler(TestType::SUCCESS, kMessageSizeThreshold, 'A');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -168,8 +171,8 @@ TEST(MessageRouterTest, ThresholMessageExactdSuccessCallback) {
TEST(MessageRouterTest, ThresholdMessageOverSuccessCallback) { TEST(MessageRouterTest, ThresholdMessageOverSuccessCallback) {
const auto OverThreshold = kMessageSizeThreshold + 1; const auto OverThreshold = kMessageSizeThreshold + 1;
CharTestHandler handler = CharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::SUCCESS, OverThreshold, 'A'); new CharTestHandler(TestType::SUCCESS, OverThreshold, 'A');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -179,8 +182,8 @@ TEST(MessageRouterTest, ThresholdMessageOverSuccessCallback) {
TEST(MessageRouterTest, ThresholdMessageUnderFailureCallback) { TEST(MessageRouterTest, ThresholdMessageUnderFailureCallback) {
const auto UnderThreshold = kMessageSizeThreshold - 1; const auto UnderThreshold = kMessageSizeThreshold - 1;
CharTestHandler handler = CharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::FAILURE, UnderThreshold, 'A'); new CharTestHandler(TestType::FAILURE, UnderThreshold, 'A');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -190,8 +193,8 @@ TEST(MessageRouterTest, ThresholdMessageUnderFailureCallback) {
TEST(MessageRouterTest, ThresholMessageOverdFailureCallback) { TEST(MessageRouterTest, ThresholMessageOverdFailureCallback) {
const auto OverThreshold = kMessageSizeThreshold + 1; const auto OverThreshold = kMessageSizeThreshold + 1;
CharTestHandler handler = CharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::FAILURE, OverThreshold, 'A'); new CharTestHandler(TestType::FAILURE, OverThreshold, 'A');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -201,8 +204,8 @@ TEST(MessageRouterTest, ThresholMessageOverdFailureCallback) {
TEST(MessageRouterTest, ThresholdUtf8MessageUnderSuccessCallback) { TEST(MessageRouterTest, ThresholdUtf8MessageUnderSuccessCallback) {
const auto UnderThreshold = kMessageSizeThreshold - 1; const auto UnderThreshold = kMessageSizeThreshold - 1;
WCharTestHandler handler = WCharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::SUCCESS, UnderThreshold, L'\u304B'); new WCharTestHandler(TestType::SUCCESS, UnderThreshold, L'\u304B');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();
@ -212,8 +215,8 @@ TEST(MessageRouterTest, ThresholdUtf8MessageUnderSuccessCallback) {
TEST(MessageRouterTest, ThresholdUtf8MessageOverSuccessCallback) { TEST(MessageRouterTest, ThresholdUtf8MessageOverSuccessCallback) {
const auto OverThreshold = kMessageSizeThreshold + 1; const auto OverThreshold = kMessageSizeThreshold + 1;
WCharTestHandler handler = WCharTestHandlerPtr handler =
new ThresholdTestHandler(TestType::SUCCESS, OverThreshold, L'\u304B'); new WCharTestHandler(TestType::SUCCESS, OverThreshold, L'\u304B');
handler->SetMessageSizeThreshold(kMessageSizeThreshold); handler->SetMessageSizeThreshold(kMessageSizeThreshold);
handler->ExecuteTest(); handler->ExecuteTest();

View File

@ -4,7 +4,7 @@
#include "include/cef_shared_process_message_builder.h" #include "include/cef_shared_process_message_builder.h"
#include "testing/gtest/include/gtest/gtest.h" #include "tests/gtest/include/gtest/gtest.h"
#include <array> #include <array>