Windows: Add abseil-cpp deps to cef_sandbox.lib

Now required due to https://crrev.com/504881812c adding a //base/metrics
dependency on absl::Mutex.
This commit is contained in:
Marshall Greenblatt 2021-11-16 14:22:55 -05:00
parent 66648c2343
commit 8e39ae2703
3 changed files with 28 additions and 25 deletions

View File

@ -39,26 +39,3 @@ void* cef_sandbox_info_create() {
void cef_sandbox_info_destroy(void* sandbox_info) { void cef_sandbox_info_destroy(void* sandbox_info) {
delete static_cast<sandbox::SandboxInterfaceInfo*>(sandbox_info); delete static_cast<sandbox::SandboxInterfaceInfo*>(sandbox_info);
} }
#if BUILDFLAG(IS_CEF_SANDBOX_BUILD)
// Avoid bringing in absl dependencies.
namespace absl {
// From third_party/abseil-cpp/absl/types/bad_optional_access.cc
namespace optional_internal {
void throw_bad_optional_access() {
LOG(FATAL) << "Bad optional access";
abort();
}
} // namespace optional_internal
// From third_party/abseil-cpp/absl/types/bad_variant_access.cc
namespace variant_internal {
void ThrowBadVariantAccess() {
LOG(FATAL) << "Bad variant access";
abort();
}
} // namespace variant_internal
} // namespace absl
#endif // BUILDFLAG(IS_CEF_SANDBOX_BUILD)

View File

@ -6,6 +6,7 @@ from __future__ import absolute_import
from glob import iglob from glob import iglob
from io import open from io import open
import os import os
import fnmatch
import shutil import shutil
import sys import sys
import time import time
@ -155,9 +156,28 @@ def make_dir(name, quiet=True):
def get_files(search_glob): def get_files(search_glob):
""" Returns all files matching the search glob. """ """ Returns all files matching |search_glob|. """
recursive_glob = '**' + os.path.sep
if recursive_glob in search_glob:
if sys.version_info >= (3, 5):
result = iglob(search_glob, recursive=True)
else:
# Polyfill for recursive glob pattern matching added in Python 3.5.
result = get_files_recursive(*search_glob.split(recursive_glob))
else:
result = iglob(search_glob)
# Sort the result for consistency across platforms. # Sort the result for consistency across platforms.
return sorted(iglob(search_glob)) return sorted(result)
def get_files_recursive(directory, pattern):
""" Returns all files in |directory| matching |pattern| recursively. """
for root, dirs, files in os.walk(directory):
for basename in files:
if fnmatch.fnmatch(basename, pattern):
filename = os.path.join(root, basename)
yield filename
def read_version_file(file, args): def read_version_file(file, args):

View File

@ -886,6 +886,12 @@ if platform == 'windows':
'obj\\base\\win\\pe_image.lib', 'obj\\base\\win\\pe_image.lib',
cef_sandbox_lib, cef_sandbox_lib,
'obj\\sandbox\\win\\sandbox.lib', 'obj\\sandbox\\win\\sandbox.lib',
'obj\\third_party\\abseil-cpp\\absl\\base\\**\\*.obj',
'obj\\third_party\\abseil-cpp\\absl\\debugging\\**\\*.obj',
'obj\\third_party\\abseil-cpp\\absl\\numeric\\**\\*.obj',
'obj\\third_party\\abseil-cpp\\absl\\synchronization\\**\\*.obj',
'obj\\third_party\\abseil-cpp\\absl\\time\\**\\*.obj',
'obj\\third_party\\abseil-cpp\\absl\\types\\**\\*.obj',
] ]
# Generate the cef_sandbox.lib merged library. A separate *_sandbox build # Generate the cef_sandbox.lib merged library. A separate *_sandbox build