bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace ReadOnlySharedMemoryRegion with WritableSharedMemoryRegion (see #3502)

Browse Source 
Write access to the shared memory region is required because JavaScript lacks
the capability to create read-only ArrayBuffers. When a user attempts to modify
an ArrayBuffer that utilizes a ReadOnlySharedMemoryRegion as its BackingStore
it triggers an access violation.

Note that this pull request may be reverted in the future if JavaScript adds
read-only ArrayBuffer support.
This commit is contained in:
Nik Pavlov
2023-10-16 22:43:29 +00:00
committed by Marshall Greenblatt
parent f3e92b45fc
commit 8d7001adc3
16 changed files with 81 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libcef_dll/cpptoc/shared_memory_region_cpptoc.cc
View File

@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=9b9187a75a85ff63f2244471af1e54f40eae5a82$
// $hash=3bc6db85e54dc87c1e592291be01820547e0989f$
//
#include "libcef_dll/cpptoc/shared_memory_region_cpptoc.h"
@ -55,7 +55,7 @@ shared_memory_region_size(struct _cef_shared_memory_region_t* self) {
return _retval;
}
const void* CEF_CALLBACK
void* CEF_CALLBACK
shared_memory_region_memory(struct _cef_shared_memory_region_t* self) {
shutdown_checker::AssertNotShutdown();
@ -65,9 +65,9 @@ shared_memory_region_memory(struct _cef_shared_memory_region_t* self) {
}
// Execute
const void* _retval = CefSharedMemoryRegionCppToC::Get(self)->Memory();
void* _retval = CefSharedMemoryRegionCppToC::Get(self)->Memory();
// Return type: simple
// Return type: simple_byaddr
return _retval;
}