bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Fix timing issue with DownloadTest.ClickedInvalid

This commit is contained in:
Marshall Greenblatt 2023-06-26 13:48:34 +03:00
parent 650755a092
commit 8603545aef
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/ceftests/download_unittest.cc
View File

@ -274,14 +274,6 @@ class DownloadTestHandler : public TestHandler {
// ALT key will trigger download of custom protocol links. // ALT key will trigger download of custom protocol links.
SendClick(browser, SendClick(browser,
test_mode_ == CLICKED_INVALID ? EVENTFLAG_ALT_DOWN : 0); test_mode_ == CLICKED_INVALID ? EVENTFLAG_ALT_DOWN : 0);
if (is_clicked() && !is_clicked_and_downloaded()) {
// Destroy the test after a bit because there will be no further
// callbacks.
CefPostDelayedTask(
TID_UI, base::BindOnce(&DownloadTestHandler::DestroyTest, this),
200);
}
} else { } else {
// Begin the download progammatically. // Begin the download progammatically.
browser->GetHost()->StartDownload(kTestDownloadUrl); browser->GetHost()->StartDownload(kTestDownloadUrl);
@ -339,6 +331,13 @@ class DownloadTestHandler : public TestHandler {
EXPECT_STREQ(download_url_.c_str(), url.ToString().c_str()); EXPECT_STREQ(download_url_.c_str(), url.ToString().c_str());
EXPECT_STREQ("GET", request_method.ToString().c_str()); EXPECT_STREQ("GET", request_method.ToString().c_str());
if (is_clicked() && !is_clicked_and_downloaded()) {
// Destroy the test after a bit because there will be no further
// callbacks.
CefPostDelayedTask(
TID_UI, base::BindOnce(&DownloadTestHandler::DestroyTest, this), 200);
}
return test_mode_ != CLICKED_BLOCKED; return test_mode_ != CLICKED_BLOCKED;
} }