bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Properly disable the notification and push APIs (fixes issue #2951)

This commit is contained in:
Cristian Amarie 2020-07-20 18:16:48 +00:00 committed by Marshall Greenblatt
parent e87fedd27c
commit 82d6bcbbea
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libcef/renderer/alloy/alloy_content_renderer_client.cc
View File

@ -256,9 +256,6 @@ void AlloyContentRendererClient::WebKitInitialized() {
// Create global objects associated with the default Isolate.
CefV8IsolateCreated();
// TODO(cef): Enable these once the implementation supports it.
blink::WebRuntimeFeatures::EnableNotifications(false);
const CefAppManager::SchemeInfoList* schemes =
CefAppManager::Get()->GetCustomSchemes();
if (!schemes->empty()) {
@ -361,6 +358,13 @@ void AlloyContentRendererClient::RunSingleProcessCleanup() {
} while (!complete);
}
void AlloyContentRendererClient::PostIOThreadCreated(
base::SingleThreadTaskRunner*) {
// TODO(cef): Enable these once the implementation supports it.
blink::WebRuntimeFeatures::EnableNotifications(false);
blink::WebRuntimeFeatures::EnablePushMessaging(false);
}
void AlloyContentRendererClient::RenderThreadStarted() {
const base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();

2
libcef/renderer/alloy/alloy_content_renderer_client.h
View File

@ -96,6 +96,8 @@ class AlloyContentRendererClient
void RunSingleProcessCleanup();
// ContentRendererClient implementation.
void PostIOThreadCreated(
base::SingleThreadTaskRunner* io_thread_task_runner) override;
void RenderThreadStarted() override;
void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override;
void RenderThreadConnected() override;