bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add NUM_VALUES for enums and size for structs (see #3836)

Browse Source 
API versioning requires that enumerations end with a count value
(`*_NUM_VALUES`) and structs begin with a size value (`size_t size`).
Wrapper templates are updated to support structs with different size
values indicating different versions.

To test:
Run `ceftests --gtest_filter=ApiVersionTest.StructVersion*`
This commit is contained in:
Marshall Greenblatt
2025-01-09 19:14:53 -05:00
parent ee5cec12d2
commit 81a5005bc0
43 changed files with 777 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libcef/browser/menu_model_impl.cc
View File

@ -240,7 +240,7 @@ struct CefMenuModelImpl::Item {
bool ctrl_pressed_ = false;
bool alt_pressed_ = false;
cef_color_t colors_[CEF_MENU_COLOR_COUNT] = {0};
cef_color_t colors_[CEF_MENU_COLOR_NUM_VALUES] = {0};
gfx::FontList font_list_;
bool has_font_list_ = false;
};
@ -744,7 +744,7 @@ bool CefMenuModelImpl::SetColorAt(int index,
return false;
}
if (color_type < 0 || color_type >= CEF_MENU_COLOR_COUNT) {
if (color_type < 0 || color_type >= CEF_MENU_COLOR_NUM_VALUES) {
return false;
}
@ -775,7 +775,7 @@ bool CefMenuModelImpl::GetColorAt(int index,
return false;
}
if (color_type < 0 || color_type >= CEF_MENU_COLOR_COUNT) {
if (color_type < 0 || color_type >= CEF_MENU_COLOR_NUM_VALUES) {
return false;
}