bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-02-03 04:27:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak when returning zero-length strings from V8 (issue #581).

Browse Source 
git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@604 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
Marshall Greenblatt 2012-04-25 20:01:10 +00:00
parent 00fbc510da
commit 7987af5acf
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/internal/cef_string_wrappers.h
View File

@ -414,7 +414,7 @@ class CefStringBase {
// Clear the string data. // Clear the string data.
/// ///
void clear() { void clear() {
if (!empty()) if (string_)
traits::clear(string_); traits::clear(string_);
} }

6
libcef/renderer/v8_impl.cc
View File

@ -168,6 +168,8 @@ void GetCefString(v8::Handle<v8::String> str, CefString& out) {
#if defined(CEF_STRING_TYPE_WIDE) #if defined(CEF_STRING_TYPE_WIDE)
// Allocate enough space for a worst-case conversion. // Allocate enough space for a worst-case conversion.
int len = str->Utf8Length(); int len = str->Utf8Length();
if (len == 0)
return;
char* buf = new char[len + 1]; char* buf = new char[len + 1];
str->WriteUtf8(buf, len + 1); str->WriteUtf8(buf, len + 1);
@ -179,11 +181,15 @@ void GetCefString(v8::Handle<v8::String> str, CefString& out) {
#else // !defined(CEF_STRING_TYPE_WIDE) #else // !defined(CEF_STRING_TYPE_WIDE)
#if defined(CEF_STRING_TYPE_UTF16) #if defined(CEF_STRING_TYPE_UTF16)
int len = str->Length(); int len = str->Length();
if (len == 0)
return;
char16* buf = new char16[len + 1]; char16* buf = new char16[len + 1];
str->Write(reinterpret_cast<uint16_t*>(buf), 0, len + 1); str->Write(reinterpret_cast<uint16_t*>(buf), 0, len + 1);
#else #else
// Allocate enough space for a worst-case conversion. // Allocate enough space for a worst-case conversion.
int len = str->Utf8Length(); int len = str->Utf8Length();
if (len == 0)
return;
char* buf = new char[len + 1]; char* buf = new char[len + 1];
str->WriteUtf8(buf, len + 1); str->WriteUtf8(buf, len + 1);
#endif #endif