bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove CefFrame::LoadString method (fixes issue #2586)

Browse Source 
This method has not behaved as expected for some time.
This commit is contained in:
Marshall Greenblatt
2019-10-15 17:34:13 +02:00
parent d28efe8797
commit 737ff18498
11 changed files with 107 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
libcef_dll/ctocpp/frame_ctocpp.cc
View File

@@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=957f55c65387757a411f9b898827bdef95531c45$
// $hash=99d10924d2ed2a233bd9d33314a627aa574cf89e$
//
#include "libcef_dll/ctocpp/frame_ctocpp.h"
@@ -220,30 +220,6 @@ NO_SANITIZE("cfi-icall") void CefFrameCToCpp::LoadURL(const CefString& url) {
_struct->load_url(_struct, url.GetStruct());
}
NO_SANITIZE("cfi-icall")
void CefFrameCToCpp::LoadString(const CefString& string_val,
const CefString& url) {
shutdown_checker::AssertNotShutdown();
cef_frame_t* _struct = GetStruct();
if (CEF_MEMBER_MISSING(_struct, load_string))
return;
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
// Verify param: string_val; type: string_byref_const
DCHECK(!string_val.empty());
if (string_val.empty())
return;
// Verify param: url; type: string_byref_const
DCHECK(!url.empty());
if (url.empty())
return;
// Execute
_struct->load_string(_struct, string_val.GetStruct(), url.GetStruct());
}
NO_SANITIZE("cfi-icall")
void CefFrameCToCpp::ExecuteJavaScript(const CefString& code,
const CefString& script_url,

3
libcef_dll/ctocpp/frame_ctocpp.h
View File

@@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=1f9305ea3945990271795caf303c11ae09f662a4$
// $hash=016b054a1d376b7e66fa5bfc377be2d1da080631$
//
#ifndef CEF_LIBCEF_DLL_CTOCPP_FRAME_CTOCPP_H_
@@ -52,7 +52,6 @@ class CefFrameCToCpp
void GetText(CefRefPtr<CefStringVisitor> visitor) OVERRIDE;
void LoadRequest(CefRefPtr<CefRequest> request) OVERRIDE;
void LoadURL(const CefString& url) OVERRIDE;
void LoadString(const CefString& string_val, const CefString& url) OVERRIDE;
void ExecuteJavaScript(const CefString& code,
const CefString& script_url,
int start_line) OVERRIDE;