From 71b315d55cb64c1433a36c70b9ae7ba9a1a589cd Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Fri, 28 Jan 2022 12:13:26 -0500 Subject: [PATCH] Remove DCHECK that triggers while loading DevTools resources See https://crbug.com/1289230 for background. --- patch/patch.cfg | 5 +++++ patch/patches/blink_security_policy_1289230.patch | 13 +++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 patch/patches/blink_security_policy_1289230.patch diff --git a/patch/patch.cfg b/patch/patch.cfg index 8ecc6358b..00453e151 100644 --- a/patch/patch.cfg +++ b/patch/patch.cfg @@ -534,5 +534,10 @@ patches = [ # Windows: Fix crash when |sandbox_info| parameter is nullptr. # https://bitbucket.org/chromiumembedded/cef/issues/3210 'name': 'win_sandbox_3210', + }, + { + # Remove DCHECK that triggers while loading DevTools resources. + # https://bugs.chromium.org/p/chromium/issues/detail?id=1289230 + 'name': 'blink_security_policy_1289230', } ] diff --git a/patch/patches/blink_security_policy_1289230.patch b/patch/patches/blink_security_policy_1289230.patch new file mode 100644 index 000000000..86f8830bd --- /dev/null +++ b/patch/patches/blink_security_policy_1289230.patch @@ -0,0 +1,13 @@ +diff --git third_party/blink/renderer/platform/weborigin/security_policy.cc third_party/blink/renderer/platform/weborigin/security_policy.cc +index 4ebbed336ebd8..845f7ec694721 100644 +--- third_party/blink/renderer/platform/weborigin/security_policy.cc ++++ third_party/blink/renderer/platform/weborigin/security_policy.cc +@@ -90,7 +90,7 @@ Referrer SecurityPolicy::GenerateReferrer( + ReferrerUtils::MojoReferrerPolicyResolveDefault(referrer_policy); + if (referrer == Referrer::NoReferrer()) + return Referrer(Referrer::NoReferrer(), referrer_policy_no_default); +- DCHECK(!referrer.IsEmpty()); ++ // DCHECK(!referrer.IsEmpty()); + + KURL referrer_url = KURL(NullURL(), referrer).UrlStrippedForUseAsReferrer(); +