bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Allow blank URL when creating popup windows (issue #1289)

Browse Source
This commit is contained in:
Marshall Greenblatt
2015-12-03 13:41:40 -05:00
parent 26e68c3d26
commit 6824387c8d
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libcef/browser/browser_info_manager.cc
View File

@ -139,7 +139,6 @@ void CefBrowserInfoManager::OnCreateWindow(
const ViewHostMsg_CreateWindow_Params& params) { const ViewHostMsg_CreateWindow_Params& params) {
DCHECK_GT(params.opener_id, 0); DCHECK_GT(params.opener_id, 0);
DCHECK_GT(params.opener_render_frame_id, 0); DCHECK_GT(params.opener_render_frame_id, 0);
DCHECK(!params.target_url.is_empty());
scoped_ptr<CefBrowserInfoManager::PendingPopup> pending_popup( scoped_ptr<CefBrowserInfoManager::PendingPopup> pending_popup(
new CefBrowserInfoManager::PendingPopup); new CefBrowserInfoManager::PendingPopup);
@ -465,7 +464,6 @@ scoped_ptr<CefBrowserInfoManager::PendingPopup>
const GURL& target_url) { const GURL& target_url) {
DCHECK_GT(opener_process_id, 0); DCHECK_GT(opener_process_id, 0);
DCHECK_GT(opener_view_id, 0); DCHECK_GT(opener_view_id, 0);
DCHECK(!target_url.is_empty());
base::AutoLock lock_scope(pending_popup_lock_); base::AutoLock lock_scope(pending_popup_lock_);

2
libcef/browser/browser_info_manager.h
View File

@ -159,6 +159,8 @@ class CefBrowserInfoManager : public content::RenderProcessHostObserver {
} step; } step;
// Initial state from ViewHostMsg_CreateWindow. // Initial state from ViewHostMsg_CreateWindow.
// |target_url| will be empty if a popup is created via window.open() and
// never navigated. For example: javascript:window.open();
int opener_process_id; int opener_process_id;
int opener_view_id; int opener_view_id;
int64 opener_frame_id; int64 opener_frame_id;