From 5ffe90cd560b02743e66756cf55c50d49f357f0c Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Wed, 4 Aug 2021 14:19:27 -0400 Subject: [PATCH] Fix assertion when client handles HTTPS URL without certificate. --- patch/patch.cfg | 4 ++++ patch/patches/blink_web_url_loader.patch | 12 ++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 patch/patches/blink_web_url_loader.patch diff --git a/patch/patch.cfg b/patch/patch.cfg index 9938c3a03..9cace00de 100644 --- a/patch/patch.cfg +++ b/patch/patch.cfg @@ -70,6 +70,10 @@ patches = [ # https://bitbucket.org/chromiumembedded/cef/issues/2345 'name': 'webkit_popups_and_background', }, + { + # Fix assertion when client handles HTTPS URL without certificate. + 'name': 'blink_web_url_loader', + }, { # Give AlloyContentRendererClient access to protected # RuntimeEnabledFeatures methods. diff --git a/patch/patches/blink_web_url_loader.patch b/patch/patches/blink_web_url_loader.patch new file mode 100644 index 000000000..eb318ba7a --- /dev/null +++ b/patch/patches/blink_web_url_loader.patch @@ -0,0 +1,12 @@ +diff --git third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc +index c346490cdf4f..fff11e84cce5 100644 +--- third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc ++++ third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc +@@ -250,7 +250,6 @@ void SetSecurityStyleAndDetails(const GURL& url, + sct_list[i] = NetSCTToBlinkSCT(ssl_info.signed_certificate_timestamps[i]); + + if (!ssl_info.cert) { +- NOTREACHED(); + response->SetSecurityStyle(SecurityStyle::kUnknown); + return; + }