mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2025-06-05 21:39:12 +02:00
Update to Chromium version 56.0.2924.51
This commit is contained in:
@@ -7,5 +7,5 @@
|
|||||||
# https://bitbucket.org/chromiumembedded/cef/wiki/BranchesAndBuilding
|
# https://bitbucket.org/chromiumembedded/cef/wiki/BranchesAndBuilding
|
||||||
|
|
||||||
{
|
{
|
||||||
'chromium_checkout': 'refs/tags/56.0.2924.10',
|
'chromium_checkout': 'refs/tags/56.0.2924.51',
|
||||||
}
|
}
|
||||||
|
@@ -247,14 +247,12 @@ void CefPrintingMessageFilter::OnUpdatePrintSettings(
|
|||||||
}
|
}
|
||||||
printer_query = queue_->PopPrinterQuery(document_cookie);
|
printer_query = queue_->PopPrinterQuery(document_cookie);
|
||||||
if (!printer_query.get()) {
|
if (!printer_query.get()) {
|
||||||
int host_id = render_process_id_;
|
int host_id;
|
||||||
int routing_id = reply_msg->routing_id();
|
int routing_id;
|
||||||
if (!new_settings->GetInteger(printing::kPreviewInitiatorHostId,
|
if (!new_settings->GetInteger(kPreviewInitiatorHostId, &host_id) ||
|
||||||
&host_id) ||
|
!new_settings->GetInteger(kPreviewInitiatorRoutingId, &routing_id)) {
|
||||||
!new_settings->GetInteger(printing::kPreviewInitiatorRoutingId,
|
|
||||||
&routing_id)) {
|
|
||||||
host_id = content::ChildProcessHost::kInvalidUniqueID;
|
host_id = content::ChildProcessHost::kInvalidUniqueID;
|
||||||
routing_id = content::ChildProcessHost::kInvalidUniqueID;
|
routing_id = MSG_ROUTING_NONE;
|
||||||
}
|
}
|
||||||
printer_query = queue_->CreatePrinterQuery(host_id, routing_id);
|
printer_query = queue_->CreatePrinterQuery(host_id, routing_id);
|
||||||
}
|
}
|
||||||
@@ -276,11 +274,10 @@ void CefPrintingMessageFilter::OnUpdatePrintSettingsReply(
|
|||||||
params.params.document_cookie = printer_query->cookie();
|
params.params.document_cookie = printer_query->cookie();
|
||||||
params.pages = PageRange::GetPages(printer_query->settings().ranges());
|
params.pages = PageRange::GetPages(printer_query->settings().ranges());
|
||||||
}
|
}
|
||||||
PrintHostMsg_UpdatePrintSettings::WriteReplyParams(
|
bool canceled = printer_query.get() &&
|
||||||
reply_msg,
|
(printer_query->last_status() == PrintingContext::CANCEL);
|
||||||
params,
|
PrintHostMsg_UpdatePrintSettings::WriteReplyParams(reply_msg, params,
|
||||||
printer_query.get() &&
|
canceled);
|
||||||
(printer_query->last_status() == printing::PrintingContext::CANCEL));
|
|
||||||
Send(reply_msg);
|
Send(reply_msg);
|
||||||
// If user hasn't cancelled.
|
// If user hasn't cancelled.
|
||||||
if (printer_query.get()) {
|
if (printer_query.get()) {
|
||||||
|
@@ -39,10 +39,10 @@ index f2a854f..913e30c 100644
|
|||||||
// built in media player for the given |url|. Defaults to false.
|
// built in media player for the given |url|. Defaults to false.
|
||||||
virtual bool ShouldUseMediaPlayerForURL(const GURL& url);
|
virtual bool ShouldUseMediaPlayerForURL(const GURL& url);
|
||||||
diff --git renderer/render_frame_impl.cc renderer/render_frame_impl.cc
|
diff --git renderer/render_frame_impl.cc renderer/render_frame_impl.cc
|
||||||
index 2f79ac0..7e0c73b 100644
|
index c0d7575..c1ea8e6 100644
|
||||||
--- renderer/render_frame_impl.cc
|
--- renderer/render_frame_impl.cc
|
||||||
+++ renderer/render_frame_impl.cc
|
+++ renderer/render_frame_impl.cc
|
||||||
@@ -5112,7 +5112,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
|
@@ -5120,7 +5120,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
|
||||||
(pending_navigation_params_ &&
|
(pending_navigation_params_ &&
|
||||||
!pending_navigation_params_->request_params.redirects.empty());
|
!pending_navigation_params_->request_params.redirects.empty());
|
||||||
|
|
||||||
@@ -50,7 +50,7 @@ index 2f79ac0..7e0c73b 100644
|
|||||||
// The handlenavigation API is deprecated and will be removed once
|
// The handlenavigation API is deprecated and will be removed once
|
||||||
// crbug.com/325351 is resolved.
|
// crbug.com/325351 is resolved.
|
||||||
if (GetContentClient()->renderer()->HandleNavigation(
|
if (GetContentClient()->renderer()->HandleNavigation(
|
||||||
@@ -5121,7 +5120,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
|
@@ -5129,7 +5128,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
|
||||||
is_redirect)) {
|
is_redirect)) {
|
||||||
return blink::WebNavigationPolicyIgnore;
|
return blink::WebNavigationPolicyIgnore;
|
||||||
}
|
}
|
||||||
|
@@ -178,7 +178,7 @@ index 3d1e71a..a876c2a 100644
|
|||||||
PrintHostMsg_SetOptionsFromDocument_Params /* params */)
|
PrintHostMsg_SetOptionsFromDocument_Params /* params */)
|
||||||
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
||||||
diff --git components/printing/renderer/print_web_view_helper.cc components/printing/renderer/print_web_view_helper.cc
|
diff --git components/printing/renderer/print_web_view_helper.cc components/printing/renderer/print_web_view_helper.cc
|
||||||
index e343eef..025671c 100644
|
index c72217a..2eb3a52 100644
|
||||||
--- components/printing/renderer/print_web_view_helper.cc
|
--- components/printing/renderer/print_web_view_helper.cc
|
||||||
+++ components/printing/renderer/print_web_view_helper.cc
|
+++ components/printing/renderer/print_web_view_helper.cc
|
||||||
@@ -88,6 +88,9 @@ const float kPrintingMinimumShrinkFactor = 1.333f;
|
@@ -88,6 +88,9 @@ const float kPrintingMinimumShrinkFactor = 1.333f;
|
||||||
@@ -268,7 +268,7 @@ index e343eef..025671c 100644
|
|||||||
} else {
|
} else {
|
||||||
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
Print(web_frame, blink::WebNode(), true /* is_scripted? */);
|
Print(web_frame, blink::WebNode(), true /* is_scripted? */);
|
||||||
@@ -988,14 +981,10 @@ bool PrintWebViewHelper::OnMessageReceived(const IPC::Message& message) {
|
@@ -992,14 +985,10 @@ bool PrintWebViewHelper::OnMessageReceived(const IPC::Message& message) {
|
||||||
IPC_MESSAGE_HANDLER(PrintMsg_PrintPages, OnPrintPages)
|
IPC_MESSAGE_HANDLER(PrintMsg_PrintPages, OnPrintPages)
|
||||||
IPC_MESSAGE_HANDLER(PrintMsg_PrintForSystemDialog, OnPrintForSystemDialog)
|
IPC_MESSAGE_HANDLER(PrintMsg_PrintForSystemDialog, OnPrintForSystemDialog)
|
||||||
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
@@ -283,7 +283,7 @@ index e343eef..025671c 100644
|
|||||||
IPC_MESSAGE_HANDLER(PrintMsg_SetPrintingEnabled, OnSetPrintingEnabled)
|
IPC_MESSAGE_HANDLER(PrintMsg_SetPrintingEnabled, OnSetPrintingEnabled)
|
||||||
IPC_MESSAGE_UNHANDLED(handled = false)
|
IPC_MESSAGE_UNHANDLED(handled = false)
|
||||||
IPC_END_MESSAGE_MAP()
|
IPC_END_MESSAGE_MAP()
|
||||||
@@ -1033,7 +1022,6 @@ void PrintWebViewHelper::OnPrintForSystemDialog() {
|
@@ -1043,7 +1032,6 @@ void PrintWebViewHelper::OnPrintForSystemDialog() {
|
||||||
}
|
}
|
||||||
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
|
|
||||||
@@ -291,7 +291,7 @@ index e343eef..025671c 100644
|
|||||||
void PrintWebViewHelper::OnPrintForPrintPreview(
|
void PrintWebViewHelper::OnPrintForPrintPreview(
|
||||||
const base::DictionaryValue& job_settings) {
|
const base::DictionaryValue& job_settings) {
|
||||||
CHECK_LE(ipc_nesting_level_, 1);
|
CHECK_LE(ipc_nesting_level_, 1);
|
||||||
@@ -1092,7 +1080,6 @@ void PrintWebViewHelper::OnPrintForPrintPreview(
|
@@ -1102,7 +1090,6 @@ void PrintWebViewHelper::OnPrintForPrintPreview(
|
||||||
DidFinishPrinting(FAIL_PRINT);
|
DidFinishPrinting(FAIL_PRINT);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -299,7 +299,7 @@ index e343eef..025671c 100644
|
|||||||
|
|
||||||
void PrintWebViewHelper::GetPageSizeAndContentAreaFromPageLayout(
|
void PrintWebViewHelper::GetPageSizeAndContentAreaFromPageLayout(
|
||||||
const PageSizeMargins& page_layout_in_points,
|
const PageSizeMargins& page_layout_in_points,
|
||||||
@@ -1117,7 +1104,6 @@ void PrintWebViewHelper::UpdateFrameMarginsCssInfo(
|
@@ -1127,7 +1114,6 @@ void PrintWebViewHelper::UpdateFrameMarginsCssInfo(
|
||||||
ignore_css_margins_ = (margins_type != DEFAULT_MARGINS);
|
ignore_css_margins_ = (margins_type != DEFAULT_MARGINS);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -307,7 +307,7 @@ index e343eef..025671c 100644
|
|||||||
void PrintWebViewHelper::OnPrintPreview(const base::DictionaryValue& settings) {
|
void PrintWebViewHelper::OnPrintPreview(const base::DictionaryValue& settings) {
|
||||||
if (ipc_nesting_level_ > 1)
|
if (ipc_nesting_level_ > 1)
|
||||||
return;
|
return;
|
||||||
@@ -1302,7 +1288,7 @@ bool PrintWebViewHelper::CreatePreviewDocument() {
|
@@ -1312,7 +1298,7 @@ bool PrintWebViewHelper::CreatePreviewDocument() {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -316,7 +316,7 @@ index e343eef..025671c 100644
|
|||||||
bool PrintWebViewHelper::RenderPreviewPage(
|
bool PrintWebViewHelper::RenderPreviewPage(
|
||||||
int page_number,
|
int page_number,
|
||||||
const PrintMsg_Print_Params& print_params) {
|
const PrintMsg_Print_Params& print_params) {
|
||||||
@@ -1332,7 +1318,7 @@ bool PrintWebViewHelper::RenderPreviewPage(
|
@@ -1342,7 +1328,7 @@ bool PrintWebViewHelper::RenderPreviewPage(
|
||||||
}
|
}
|
||||||
return PreviewPageRendered(page_number, draft_metafile.get());
|
return PreviewPageRendered(page_number, draft_metafile.get());
|
||||||
}
|
}
|
||||||
@@ -325,7 +325,7 @@ index e343eef..025671c 100644
|
|||||||
|
|
||||||
bool PrintWebViewHelper::FinalizePrintReadyDocument() {
|
bool PrintWebViewHelper::FinalizePrintReadyDocument() {
|
||||||
DCHECK(!is_print_ready_metafile_sent_);
|
DCHECK(!is_print_ready_metafile_sent_);
|
||||||
@@ -1362,7 +1348,6 @@ bool PrintWebViewHelper::FinalizePrintReadyDocument() {
|
@@ -1372,7 +1358,6 @@ bool PrintWebViewHelper::FinalizePrintReadyDocument() {
|
||||||
Send(new PrintHostMsg_MetafileReadyForPrinting(routing_id(), preview_params));
|
Send(new PrintHostMsg_MetafileReadyForPrinting(routing_id(), preview_params));
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
@@ -333,7 +333,7 @@ index e343eef..025671c 100644
|
|||||||
|
|
||||||
void PrintWebViewHelper::OnPrintingDone(bool success) {
|
void PrintWebViewHelper::OnPrintingDone(bool success) {
|
||||||
if (ipc_nesting_level_ > 1)
|
if (ipc_nesting_level_ > 1)
|
||||||
@@ -1377,7 +1362,6 @@ void PrintWebViewHelper::OnSetPrintingEnabled(bool enabled) {
|
@@ -1387,7 +1372,6 @@ void PrintWebViewHelper::OnSetPrintingEnabled(bool enabled) {
|
||||||
is_printing_enabled_ = enabled;
|
is_printing_enabled_ = enabled;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -341,7 +341,7 @@ index e343eef..025671c 100644
|
|||||||
void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
||||||
if (ipc_nesting_level_ > 1)
|
if (ipc_nesting_level_ > 1)
|
||||||
return;
|
return;
|
||||||
@@ -1388,7 +1372,9 @@ void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
@@ -1398,7 +1382,9 @@ void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
||||||
// that instead.
|
// that instead.
|
||||||
auto plugin = delegate_->GetPdfElement(frame);
|
auto plugin = delegate_->GetPdfElement(frame);
|
||||||
if (!plugin.isNull()) {
|
if (!plugin.isNull()) {
|
||||||
@@ -351,7 +351,7 @@ index e343eef..025671c 100644
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
print_preview_context_.InitWithFrame(frame);
|
print_preview_context_.InitWithFrame(frame);
|
||||||
@@ -1396,7 +1382,6 @@ void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
@@ -1406,7 +1392,6 @@ void PrintWebViewHelper::OnInitiatePrintPreview(bool has_selection) {
|
||||||
? PRINT_PREVIEW_USER_INITIATED_SELECTION
|
? PRINT_PREVIEW_USER_INITIATED_SELECTION
|
||||||
: PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME);
|
: PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME);
|
||||||
}
|
}
|
||||||
@@ -359,10 +359,10 @@ index e343eef..025671c 100644
|
|||||||
|
|
||||||
bool PrintWebViewHelper::IsPrintingEnabled() const {
|
bool PrintWebViewHelper::IsPrintingEnabled() const {
|
||||||
return is_printing_enabled_;
|
return is_printing_enabled_;
|
||||||
@@ -1420,11 +1405,9 @@ void PrintWebViewHelper::PrintNode(const blink::WebNode& node) {
|
@@ -1428,11 +1413,9 @@ void PrintWebViewHelper::PrintNode(const blink::WebNode& node) {
|
||||||
|
|
||||||
|
print_node_in_progress_ = true;
|
||||||
|
|
||||||
// Make a copy of the node, in case RenderView::OnContextMenuClosed resets
|
|
||||||
// its |context_menu_node_|.
|
|
||||||
- if (g_is_preview_enabled) {
|
- if (g_is_preview_enabled) {
|
||||||
-#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
-#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
||||||
+ if (g_is_preview_enabled || force_print_preview_) {
|
+ if (g_is_preview_enabled || force_print_preview_) {
|
||||||
@@ -371,8 +371,8 @@ index e343eef..025671c 100644
|
|||||||
-#endif
|
-#endif
|
||||||
} else {
|
} else {
|
||||||
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
blink::WebNode duplicate_node(node);
|
// Make a copy of the node, in case RenderView::OnContextMenuClosed() resets
|
||||||
@@ -1490,7 +1473,6 @@ void PrintWebViewHelper::DidFinishPrinting(PrintingResult result) {
|
@@ -1521,7 +1504,6 @@ void PrintWebViewHelper::DidFinishPrinting(PrintingResult result) {
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
|
|
||||||
@@ -380,7 +380,7 @@ index e343eef..025671c 100644
|
|||||||
case FAIL_PREVIEW:
|
case FAIL_PREVIEW:
|
||||||
int cookie =
|
int cookie =
|
||||||
print_pages_params_ ? print_pages_params_->params.document_cookie : 0;
|
print_pages_params_ ? print_pages_params_->params.document_cookie : 0;
|
||||||
@@ -1502,7 +1484,6 @@ void PrintWebViewHelper::DidFinishPrinting(PrintingResult result) {
|
@@ -1533,7 +1515,6 @@ void PrintWebViewHelper::DidFinishPrinting(PrintingResult result) {
|
||||||
}
|
}
|
||||||
print_preview_context_.Failed(notify_browser_of_print_failure_);
|
print_preview_context_.Failed(notify_browser_of_print_failure_);
|
||||||
break;
|
break;
|
||||||
@@ -388,7 +388,7 @@ index e343eef..025671c 100644
|
|||||||
}
|
}
|
||||||
prep_frame_view_.reset();
|
prep_frame_view_.reset();
|
||||||
print_pages_params_.reset();
|
print_pages_params_.reset();
|
||||||
@@ -1634,7 +1615,6 @@ bool PrintWebViewHelper::CalculateNumberOfPages(blink::WebLocalFrame* frame,
|
@@ -1665,7 +1646,6 @@ bool PrintWebViewHelper::CalculateNumberOfPages(blink::WebLocalFrame* frame,
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -396,15 +396,15 @@ index e343eef..025671c 100644
|
|||||||
bool PrintWebViewHelper::SetOptionsFromPdfDocument(
|
bool PrintWebViewHelper::SetOptionsFromPdfDocument(
|
||||||
PrintHostMsg_SetOptionsFromDocument_Params* options) {
|
PrintHostMsg_SetOptionsFromDocument_Params* options) {
|
||||||
blink::WebLocalFrame* source_frame = print_preview_context_.source_frame();
|
blink::WebLocalFrame* source_frame = print_preview_context_.source_frame();
|
||||||
@@ -1743,7 +1723,6 @@ bool PrintWebViewHelper::UpdatePrintSettings(
|
@@ -1772,7 +1752,6 @@ bool PrintWebViewHelper::UpdatePrintSettings(
|
||||||
|
print_preview_context_.set_error(PREVIEW_ERROR_INVALID_PRINTER_SETTINGS);
|
||||||
return true;
|
return false;
|
||||||
}
|
}
|
||||||
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
||||||
|
|
||||||
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
bool PrintWebViewHelper::GetPrintSettingsFromUser(blink::WebLocalFrame* frame,
|
void PrintWebViewHelper::GetPrintSettingsFromUser(
|
||||||
@@ -1857,7 +1836,6 @@ void PrintWebViewHelper::PrintPageInternal(
|
@@ -1879,7 +1858,6 @@ void PrintWebViewHelper::PrintPageInternal(
|
||||||
|
|
||||||
MetafileSkiaWrapper::SetMetafileOnCanvas(*canvas, metafile);
|
MetafileSkiaWrapper::SetMetafileOnCanvas(*canvas, metafile);
|
||||||
|
|
||||||
@@ -412,7 +412,7 @@ index e343eef..025671c 100644
|
|||||||
if (params.params.display_header_footer) {
|
if (params.params.display_header_footer) {
|
||||||
// TODO(thestig): Figure out why Linux needs this. It is almost certainly
|
// TODO(thestig): Figure out why Linux needs this. It is almost certainly
|
||||||
// |printingMinimumShrinkFactor| from Blink.
|
// |printingMinimumShrinkFactor| from Blink.
|
||||||
@@ -1872,7 +1850,6 @@ void PrintWebViewHelper::PrintPageInternal(
|
@@ -1894,7 +1872,6 @@ void PrintWebViewHelper::PrintPageInternal(
|
||||||
scale_factor / fudge_factor, page_layout_in_points,
|
scale_factor / fudge_factor, page_layout_in_points,
|
||||||
params.params);
|
params.params);
|
||||||
}
|
}
|
||||||
@@ -420,7 +420,7 @@ index e343eef..025671c 100644
|
|||||||
|
|
||||||
float webkit_scale_factor =
|
float webkit_scale_factor =
|
||||||
RenderPageContent(frame, params.page_number, canvas_area, content_area,
|
RenderPageContent(frame, params.page_number, canvas_area, content_area,
|
||||||
@@ -1908,7 +1885,6 @@ bool PrintWebViewHelper::CopyMetafileDataToSharedMem(
|
@@ -1930,7 +1907,6 @@ bool PrintWebViewHelper::CopyMetafileDataToSharedMem(
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -428,7 +428,7 @@ index e343eef..025671c 100644
|
|||||||
void PrintWebViewHelper::ShowScriptedPrintPreview() {
|
void PrintWebViewHelper::ShowScriptedPrintPreview() {
|
||||||
if (is_scripted_preview_delayed_) {
|
if (is_scripted_preview_delayed_) {
|
||||||
is_scripted_preview_delayed_ = false;
|
is_scripted_preview_delayed_ = false;
|
||||||
@@ -2036,7 +2012,6 @@ bool PrintWebViewHelper::PreviewPageRendered(int page_number,
|
@@ -2061,7 +2037,6 @@ bool PrintWebViewHelper::PreviewPageRendered(int page_number,
|
||||||
Send(new PrintHostMsg_DidPreviewPage(routing_id(), preview_page_params));
|
Send(new PrintHostMsg_DidPreviewPage(routing_id(), preview_page_params));
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
@@ -437,10 +437,10 @@ index e343eef..025671c 100644
|
|||||||
PrintWebViewHelper::PrintPreviewContext::PrintPreviewContext()
|
PrintWebViewHelper::PrintPreviewContext::PrintPreviewContext()
|
||||||
: total_page_count_(0),
|
: total_page_count_(0),
|
||||||
diff --git components/printing/renderer/print_web_view_helper.h components/printing/renderer/print_web_view_helper.h
|
diff --git components/printing/renderer/print_web_view_helper.h components/printing/renderer/print_web_view_helper.h
|
||||||
index 2dad908..fea05fd 100644
|
index 0730f76..645aa81 100644
|
||||||
--- components/printing/renderer/print_web_view_helper.h
|
--- components/printing/renderer/print_web_view_helper.h
|
||||||
+++ components/printing/renderer/print_web_view_helper.h
|
+++ components/printing/renderer/print_web_view_helper.h
|
||||||
@@ -143,9 +143,7 @@ class PrintWebViewHelper
|
@@ -145,9 +145,7 @@ class PrintWebViewHelper
|
||||||
OK,
|
OK,
|
||||||
FAIL_PRINT_INIT,
|
FAIL_PRINT_INIT,
|
||||||
FAIL_PRINT,
|
FAIL_PRINT,
|
||||||
@@ -450,7 +450,7 @@ index 2dad908..fea05fd 100644
|
|||||||
};
|
};
|
||||||
|
|
||||||
enum PrintPreviewErrorBuckets {
|
enum PrintPreviewErrorBuckets {
|
||||||
@@ -181,10 +179,8 @@ class PrintWebViewHelper
|
@@ -183,10 +181,8 @@ class PrintWebViewHelper
|
||||||
void OnPrintForSystemDialog();
|
void OnPrintForSystemDialog();
|
||||||
void OnPrintForPrintPreview(const base::DictionaryValue& job_settings);
|
void OnPrintForPrintPreview(const base::DictionaryValue& job_settings);
|
||||||
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
#endif // BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
@@ -461,7 +461,7 @@ index 2dad908..fea05fd 100644
|
|||||||
void OnPrintingDone(bool success);
|
void OnPrintingDone(bool success);
|
||||||
|
|
||||||
// Get |page_size| and |content_area| information from
|
// Get |page_size| and |content_area| information from
|
||||||
@@ -197,7 +193,6 @@ class PrintWebViewHelper
|
@@ -199,7 +195,6 @@ class PrintWebViewHelper
|
||||||
// Update |ignore_css_margins_| based on settings.
|
// Update |ignore_css_margins_| based on settings.
|
||||||
void UpdateFrameMarginsCssInfo(const base::DictionaryValue& settings);
|
void UpdateFrameMarginsCssInfo(const base::DictionaryValue& settings);
|
||||||
|
|
||||||
@@ -469,7 +469,7 @@ index 2dad908..fea05fd 100644
|
|||||||
// Prepare frame for creating preview document.
|
// Prepare frame for creating preview document.
|
||||||
void PrepareFrameForPreviewDocument();
|
void PrepareFrameForPreviewDocument();
|
||||||
|
|
||||||
@@ -214,7 +209,6 @@ class PrintWebViewHelper
|
@@ -216,7 +211,6 @@ class PrintWebViewHelper
|
||||||
|
|
||||||
// Finalize the print ready preview document.
|
// Finalize the print ready preview document.
|
||||||
bool FinalizePrintReadyDocument();
|
bool FinalizePrintReadyDocument();
|
||||||
@@ -477,7 +477,7 @@ index 2dad908..fea05fd 100644
|
|||||||
|
|
||||||
// Enable/Disable printing.
|
// Enable/Disable printing.
|
||||||
void OnSetPrintingEnabled(bool enabled);
|
void OnSetPrintingEnabled(bool enabled);
|
||||||
@@ -242,7 +236,6 @@ class PrintWebViewHelper
|
@@ -246,7 +240,6 @@ class PrintWebViewHelper
|
||||||
const blink::WebNode& node,
|
const blink::WebNode& node,
|
||||||
int* number_of_pages);
|
int* number_of_pages);
|
||||||
|
|
||||||
@@ -485,15 +485,15 @@ index 2dad908..fea05fd 100644
|
|||||||
// Set options for print preset from source PDF document.
|
// Set options for print preset from source PDF document.
|
||||||
bool SetOptionsFromPdfDocument(
|
bool SetOptionsFromPdfDocument(
|
||||||
PrintHostMsg_SetOptionsFromDocument_Params* options);
|
PrintHostMsg_SetOptionsFromDocument_Params* options);
|
||||||
@@ -253,7 +246,6 @@ class PrintWebViewHelper
|
@@ -257,7 +250,6 @@ class PrintWebViewHelper
|
||||||
bool UpdatePrintSettings(blink::WebLocalFrame* frame,
|
bool UpdatePrintSettings(blink::WebLocalFrame* frame,
|
||||||
const blink::WebNode& node,
|
const blink::WebNode& node,
|
||||||
const base::DictionaryValue& passed_job_settings);
|
const base::DictionaryValue& passed_job_settings);
|
||||||
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
-#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
||||||
|
|
||||||
|
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
|
||||||
// Get final print settings from the user.
|
// Get final print settings from the user.
|
||||||
// Return false if the user cancels or on error.
|
@@ -335,7 +327,6 @@ class PrintWebViewHelper
|
||||||
@@ -328,7 +320,6 @@ class PrintWebViewHelper
|
|
||||||
const PrintMsg_PrintPages_Params& params,
|
const PrintMsg_PrintPages_Params& params,
|
||||||
int page_count);
|
int page_count);
|
||||||
|
|
||||||
@@ -501,7 +501,7 @@ index 2dad908..fea05fd 100644
|
|||||||
// Given the |device| and |canvas| to draw on, prints the appropriate headers
|
// Given the |device| and |canvas| to draw on, prints the appropriate headers
|
||||||
// and footers using strings from |header_footer_info| on to the canvas.
|
// and footers using strings from |header_footer_info| on to the canvas.
|
||||||
static void PrintHeaderAndFooter(blink::WebCanvas* canvas,
|
static void PrintHeaderAndFooter(blink::WebCanvas* canvas,
|
||||||
@@ -338,7 +329,6 @@ class PrintWebViewHelper
|
@@ -345,7 +336,6 @@ class PrintWebViewHelper
|
||||||
float webkit_scale_factor,
|
float webkit_scale_factor,
|
||||||
const PageSizeMargins& page_layout_in_points,
|
const PageSizeMargins& page_layout_in_points,
|
||||||
const PrintMsg_Print_Params& params);
|
const PrintMsg_Print_Params& params);
|
||||||
@@ -509,7 +509,7 @@ index 2dad908..fea05fd 100644
|
|||||||
|
|
||||||
// Script Initiated Printing ------------------------------------------------
|
// Script Initiated Printing ------------------------------------------------
|
||||||
|
|
||||||
@@ -348,7 +338,6 @@ class PrintWebViewHelper
|
@@ -355,7 +345,6 @@ class PrintWebViewHelper
|
||||||
bool IsScriptInitiatedPrintAllowed(blink::WebFrame* frame,
|
bool IsScriptInitiatedPrintAllowed(blink::WebFrame* frame,
|
||||||
bool user_initiated);
|
bool user_initiated);
|
||||||
|
|
||||||
@@ -517,7 +517,7 @@ index 2dad908..fea05fd 100644
|
|||||||
// Shows scripted print preview when options from plugin are available.
|
// Shows scripted print preview when options from plugin are available.
|
||||||
void ShowScriptedPrintPreview();
|
void ShowScriptedPrintPreview();
|
||||||
|
|
||||||
@@ -364,7 +353,6 @@ class PrintWebViewHelper
|
@@ -373,7 +362,6 @@ class PrintWebViewHelper
|
||||||
// |metafile| is the rendered page. Otherwise |metafile| is NULL.
|
// |metafile| is the rendered page. Otherwise |metafile| is NULL.
|
||||||
// Returns true if print preview should continue, false on failure.
|
// Returns true if print preview should continue, false on failure.
|
||||||
bool PreviewPageRendered(int page_number, PdfMetafileSkia* metafile);
|
bool PreviewPageRendered(int page_number, PdfMetafileSkia* metafile);
|
||||||
@@ -525,7 +525,7 @@ index 2dad908..fea05fd 100644
|
|||||||
|
|
||||||
void SetPrintPagesParams(const PrintMsg_PrintPages_Params& settings);
|
void SetPrintPagesParams(const PrintMsg_PrintPages_Params& settings);
|
||||||
|
|
||||||
@@ -516,6 +504,7 @@ class PrintWebViewHelper
|
@@ -525,6 +513,7 @@ class PrintWebViewHelper
|
||||||
ScriptingThrottler scripting_throttler_;
|
ScriptingThrottler scripting_throttler_;
|
||||||
|
|
||||||
bool print_node_in_progress_;
|
bool print_node_in_progress_;
|
||||||
|
@@ -1,5 +1,5 @@
|
|||||||
diff --git render_widget_host_view_mac.mm render_widget_host_view_mac.mm
|
diff --git render_widget_host_view_mac.mm render_widget_host_view_mac.mm
|
||||||
index 689ae2c..52e405d 100644
|
index 93d929c..249ecd7 100644
|
||||||
--- render_widget_host_view_mac.mm
|
--- render_widget_host_view_mac.mm
|
||||||
+++ render_widget_host_view_mac.mm
|
+++ render_widget_host_view_mac.mm
|
||||||
@@ -462,9 +462,6 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,
|
@@ -462,9 +462,6 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,
|
||||||
|
@@ -351,10 +351,10 @@ index 0dd6715..324fecbc 100644
|
|||||||
ui::Window* parent_mus = nullptr;
|
ui::Window* parent_mus = nullptr;
|
||||||
// Specifies the initial bounds of the Widget. Default is empty, which means
|
// Specifies the initial bounds of the Widget. Default is empty, which means
|
||||||
diff --git ui/views/win/hwnd_message_handler.cc ui/views/win/hwnd_message_handler.cc
|
diff --git ui/views/win/hwnd_message_handler.cc ui/views/win/hwnd_message_handler.cc
|
||||||
index 6f80d3e..9a21157 100644
|
index a15ec1a..9a8697b 100644
|
||||||
--- ui/views/win/hwnd_message_handler.cc
|
--- ui/views/win/hwnd_message_handler.cc
|
||||||
+++ ui/views/win/hwnd_message_handler.cc
|
+++ ui/views/win/hwnd_message_handler.cc
|
||||||
@@ -2508,8 +2508,12 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
|
@@ -2516,8 +2516,12 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
|
||||||
active_mouse_tracking_flags_ = 0;
|
active_mouse_tracking_flags_ = 0;
|
||||||
} else if (event.type() == ui::ET_MOUSEWHEEL) {
|
} else if (event.type() == ui::ET_MOUSEWHEEL) {
|
||||||
// Reroute the mouse wheel to the window under the pointer if applicable.
|
// Reroute the mouse wheel to the window under the pointer if applicable.
|
||||||
|
@@ -74,7 +74,7 @@ index 6cdff54..0efcaa2 100644
|
|||||||
int opener_render_process_id,
|
int opener_render_process_id,
|
||||||
int opener_render_frame_id,
|
int opener_render_frame_id,
|
||||||
diff --git content/browser/web_contents/web_contents_impl.cc content/browser/web_contents/web_contents_impl.cc
|
diff --git content/browser/web_contents/web_contents_impl.cc content/browser/web_contents/web_contents_impl.cc
|
||||||
index a662439..2b22f27 100644
|
index 5b98a03..ddd9675 100644
|
||||||
--- content/browser/web_contents/web_contents_impl.cc
|
--- content/browser/web_contents/web_contents_impl.cc
|
||||||
+++ content/browser/web_contents/web_contents_impl.cc
|
+++ content/browser/web_contents/web_contents_impl.cc
|
||||||
@@ -1572,6 +1572,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
|
@@ -1572,6 +1572,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
|
||||||
|
@@ -1,8 +1,8 @@
|
|||||||
diff --git Source/web/ChromeClientImpl.cpp Source/web/ChromeClientImpl.cpp
|
diff --git Source/web/ChromeClientImpl.cpp Source/web/ChromeClientImpl.cpp
|
||||||
index 0f7c13c..9fac7a7 100644
|
index 4cf0fe7..404afc2 100644
|
||||||
--- Source/web/ChromeClientImpl.cpp
|
--- Source/web/ChromeClientImpl.cpp
|
||||||
+++ Source/web/ChromeClientImpl.cpp
|
+++ Source/web/ChromeClientImpl.cpp
|
||||||
@@ -892,7 +892,7 @@ bool ChromeClientImpl::hasOpenedPopup() const {
|
@@ -886,7 +886,7 @@ bool ChromeClientImpl::hasOpenedPopup() const {
|
||||||
PopupMenu* ChromeClientImpl::openPopupMenu(LocalFrame& frame,
|
PopupMenu* ChromeClientImpl::openPopupMenu(LocalFrame& frame,
|
||||||
HTMLSelectElement& select) {
|
HTMLSelectElement& select) {
|
||||||
notifyPopupOpeningObservers();
|
notifyPopupOpeningObservers();
|
||||||
@@ -12,10 +12,10 @@ index 0f7c13c..9fac7a7 100644
|
|||||||
|
|
||||||
DCHECK(RuntimeEnabledFeatures::pagePopupEnabled());
|
DCHECK(RuntimeEnabledFeatures::pagePopupEnabled());
|
||||||
diff --git Source/web/WebViewImpl.cpp Source/web/WebViewImpl.cpp
|
diff --git Source/web/WebViewImpl.cpp Source/web/WebViewImpl.cpp
|
||||||
index 1330049..66205a3 100644
|
index fd45686..6e8d82f 100644
|
||||||
--- Source/web/WebViewImpl.cpp
|
--- Source/web/WebViewImpl.cpp
|
||||||
+++ Source/web/WebViewImpl.cpp
|
+++ Source/web/WebViewImpl.cpp
|
||||||
@@ -359,6 +359,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
|
@@ -358,6 +358,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
|
||||||
m_enableFakePageScaleAnimationForTesting(false),
|
m_enableFakePageScaleAnimationForTesting(false),
|
||||||
m_fakePageScaleAnimationPageScaleFactor(0),
|
m_fakePageScaleAnimationPageScaleFactor(0),
|
||||||
m_fakePageScaleAnimationUseAnchor(false),
|
m_fakePageScaleAnimationUseAnchor(false),
|
||||||
@@ -23,7 +23,7 @@ index 1330049..66205a3 100644
|
|||||||
m_ignoreInputEvents(false),
|
m_ignoreInputEvents(false),
|
||||||
m_compositorDeviceScaleFactorOverride(0),
|
m_compositorDeviceScaleFactorOverride(0),
|
||||||
m_suppressNextKeypressEvent(false),
|
m_suppressNextKeypressEvent(false),
|
||||||
@@ -3708,8 +3709,13 @@ void WebViewImpl::mainFrameScrollOffsetChanged() {
|
@@ -3707,8 +3708,13 @@ void WebViewImpl::mainFrameScrollOffsetChanged() {
|
||||||
m_devToolsEmulator->mainFrameScrollOrScaleChanged();
|
m_devToolsEmulator->mainFrameScrollOrScaleChanged();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -1,16 +1,16 @@
|
|||||||
diff --git chrome/app/generated_resources.grd chrome/app/generated_resources.grd
|
diff --git chrome/app/generated_resources.grd chrome/app/generated_resources.grd
|
||||||
index 4206b74..5d6af4c 100644
|
index 54b8ced..aca718b 100644
|
||||||
--- chrome/app/generated_resources.grd
|
--- chrome/app/generated_resources.grd
|
||||||
+++ chrome/app/generated_resources.grd
|
+++ chrome/app/generated_resources.grd
|
||||||
@@ -7199,7 +7199,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
|
@@ -7196,7 +7196,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
|
||||||
</message>
|
</message>
|
||||||
</if>
|
</if>
|
||||||
<message name="IDS_PLUGIN_BLOCKED_BY_POLICY" desc="The placeholder text for a plugin blocked by enterprise policy.">
|
<message name="IDS_PLUGIN_BLOCKED_BY_POLICY" desc="The placeholder text for a plugin blocked by enterprise policy.">
|
||||||
- <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is blocked by enterprise policy
|
- <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is blocked by enterprise policy
|
||||||
+ <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is not allowed
|
+ <ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is not allowed
|
||||||
</message>
|
</message>
|
||||||
<if expr="chromeos">
|
<message name="IDS_PLUGIN_BLOCKED_NO_LOADING" desc="The placeholder text for a blocked plugin that cannot be manually loaded by the user.">
|
||||||
<message name="IDS_NACL_PLUGIN_BLOCKED" desc="The placeholder text for a blocked plugin.">
|
<ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is blocked
|
||||||
diff --git components/plugins/renderer/loadable_plugin_placeholder.cc components/plugins/renderer/loadable_plugin_placeholder.cc
|
diff --git components/plugins/renderer/loadable_plugin_placeholder.cc components/plugins/renderer/loadable_plugin_placeholder.cc
|
||||||
index 1f38fdb..03e0f60 100644
|
index 1f38fdb..03e0f60 100644
|
||||||
--- components/plugins/renderer/loadable_plugin_placeholder.cc
|
--- components/plugins/renderer/loadable_plugin_placeholder.cc
|
||||||
|
@@ -439,7 +439,8 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
case OSR_TEST_POPUP_SIZE:
|
case OSR_TEST_POPUP_SIZE:
|
||||||
EXPECT_EQ(kExpandedSelectRect.x, rect.x);
|
EXPECT_EQ(kExpandedSelectRect.x, rect.x);
|
||||||
EXPECT_EQ(kExpandedSelectRect.y, rect.y);
|
EXPECT_EQ(kExpandedSelectRect.y, rect.y);
|
||||||
EXPECT_EQ(kExpandedSelectRect.width, rect.width);
|
if (ExpectComputedPopupWidth())
|
||||||
|
EXPECT_EQ(kExpandedSelectRect.width, rect.width);
|
||||||
EXPECT_EQ(kExpandedSelectRect.height, rect.height);
|
EXPECT_EQ(kExpandedSelectRect.height, rect.height);
|
||||||
DestroySucceededTestSoon();
|
DestroySucceededTestSoon();
|
||||||
break;
|
break;
|
||||||
@@ -460,7 +461,8 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
EXPECT_EQ(GetScaledInt(kOsrHeight), height);
|
EXPECT_EQ(GetScaledInt(kOsrHeight), height);
|
||||||
} else if (type == PET_POPUP) {
|
} else if (type == PET_POPUP) {
|
||||||
const CefRect& expanded_select_rect = GetScaledRect(kExpandedSelectRect);
|
const CefRect& expanded_select_rect = GetScaledRect(kExpandedSelectRect);
|
||||||
EXPECT_EQ(expanded_select_rect.width, width);
|
if (ExpectComputedPopupWidth())
|
||||||
|
EXPECT_EQ(expanded_select_rect.width, width);
|
||||||
EXPECT_EQ(expanded_select_rect.height, height);
|
EXPECT_EQ(expanded_select_rect.height, height);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -703,10 +705,12 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
EXPECT_EQ(dirtyRects.size(), 1U);
|
EXPECT_EQ(dirtyRects.size(), 1U);
|
||||||
const CefRect& expanded_select_rect =
|
const CefRect& expanded_select_rect =
|
||||||
GetScaledRect(kExpandedSelectRect);
|
GetScaledRect(kExpandedSelectRect);
|
||||||
EXPECT_EQ(dirtyRects[0],
|
EXPECT_EQ(0, dirtyRects[0].x);
|
||||||
CefRect(0, 0,
|
EXPECT_EQ(0, dirtyRects[0].y);
|
||||||
expanded_select_rect.width,
|
if (ExpectComputedPopupWidth())
|
||||||
expanded_select_rect.height));
|
EXPECT_EQ(expanded_select_rect.width, dirtyRects[0].width);
|
||||||
|
EXPECT_EQ(expanded_select_rect.height, dirtyRects[0].height);
|
||||||
|
|
||||||
// first pixel of border
|
// first pixel of border
|
||||||
#if defined(OS_MACOSX)
|
#if defined(OS_MACOSX)
|
||||||
EXPECT_EQ(0xff5d99d6, *(reinterpret_cast<const uint32*>(buffer)));
|
EXPECT_EQ(0xff5d99d6, *(reinterpret_cast<const uint32*>(buffer)));
|
||||||
@@ -719,7 +723,8 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
#else
|
#else
|
||||||
#error "Unsupported platform"
|
#error "Unsupported platform"
|
||||||
#endif
|
#endif
|
||||||
EXPECT_EQ(expanded_select_rect.width, width);
|
if (ExpectComputedPopupWidth())
|
||||||
|
EXPECT_EQ(expanded_select_rect.width, width);
|
||||||
EXPECT_EQ(expanded_select_rect.height, height);
|
EXPECT_EQ(expanded_select_rect.height, height);
|
||||||
DestroySucceededTestSoon();
|
DestroySucceededTestSoon();
|
||||||
}
|
}
|
||||||
@@ -743,11 +748,11 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
const CefRect& expanded_select_rect =
|
const CefRect& expanded_select_rect =
|
||||||
GetScaledRect(kExpandedSelectRect);
|
GetScaledRect(kExpandedSelectRect);
|
||||||
EXPECT_EQ(dirtyRects.size(), 1U);
|
EXPECT_EQ(dirtyRects.size(), 1U);
|
||||||
EXPECT_EQ(dirtyRects[0],
|
EXPECT_EQ(0, dirtyRects[0].x);
|
||||||
CefRect(0,
|
EXPECT_EQ(0, dirtyRects[0].y);
|
||||||
0,
|
if (ExpectComputedPopupWidth())
|
||||||
expanded_select_rect.width,
|
EXPECT_EQ(expanded_select_rect.width, dirtyRects[0].width);
|
||||||
expanded_select_rect.height));
|
EXPECT_EQ(expanded_select_rect.height, dirtyRects[0].height);
|
||||||
DestroySucceededTestSoon();
|
DestroySucceededTestSoon();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1132,6 +1137,19 @@ class OSRTestHandler : public RoutingTestHandler,
|
|||||||
return rect.y + rect.height / 2;
|
return rect.y + rect.height / 2;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
bool ExpectComputedPopupWidth() const {
|
||||||
|
#if defined(OS_WIN)
|
||||||
|
// On Windows the device scale factor is ignored in Blink when computing
|
||||||
|
// the default form control font size (see https://crbug.com/674663#c11).
|
||||||
|
// This results in better font size display but also means that we won't
|
||||||
|
// get the expected (scaled) width value for non-1.0 scale factor select
|
||||||
|
// popups.
|
||||||
|
return scale_factor_ == 1.0;
|
||||||
|
#else
|
||||||
|
return true;
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
||||||
void DestroySucceededTestSoon() {
|
void DestroySucceededTestSoon() {
|
||||||
if (succeeded())
|
if (succeeded())
|
||||||
return;
|
return;
|
||||||
|
Reference in New Issue
Block a user