bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

alloy: Fix extension function registration for print preview dialog (fixes issue #3167)

Browse Source
This commit is contained in:
Marshall Greenblatt
2022-02-02 14:45:53 -05:00
parent 9ed0ce82d9
commit 5491502a52
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libcef/browser/alloy/alloy_content_browser_client.cc
View File

@ -1518,6 +1518,18 @@ bool AlloyContentBrowserClient::ShouldAllowPluginCreation(
return true; return true;
} }
void AlloyContentBrowserClient::OnWebContentsCreated(
content::WebContents* web_contents) {
// Attach universal WebContentsObservers. These are quite rare, and in most
// cases CefBrowserPlatformDelegateAlloy::BrowserCreated and/or
// CefExtensionsAPIClient::AttachWebContentsHelpers should be used instead.
if (extensions::ExtensionsEnabled()) {
extensions::CefExtensionWebContentsObserver::CreateForWebContents(
web_contents);
}
}
bool AlloyContentBrowserClient::IsFindInPageDisabledForOrigin( bool AlloyContentBrowserClient::IsFindInPageDisabledForOrigin(
const url::Origin& origin) { const url::Origin& origin) {
// For PDF viewing with the PPAPI-free PDF Viewer, find-in-page should only // For PDF viewing with the PPAPI-free PDF Viewer, find-in-page should only

1
libcef/browser/alloy/alloy_content_browser_client.h
View File

@ -237,6 +237,7 @@ class AlloyContentBrowserClient : public content::ContentBrowserClient {
bool ShouldAllowPluginCreation( bool ShouldAllowPluginCreation(
const url::Origin& embedder_origin, const url::Origin& embedder_origin,
const content::PepperPluginInfo& plugin_info) override; const content::PepperPluginInfo& plugin_info) override;
void OnWebContentsCreated(content::WebContents* web_contents) override;
bool IsFindInPageDisabledForOrigin(const url::Origin& origin) override; bool IsFindInPageDisabledForOrigin(const url::Origin& origin) override;
CefRefPtr<CefRequestContextImpl> request_context() const; CefRefPtr<CefRequestContextImpl> request_context() const;

3
libcef/browser/alloy/browser_platform_delegate_alloy.cc
View File

@ -179,9 +179,6 @@ void CefBrowserPlatformDelegateAlloy::BrowserCreated(
printing::CefPrintViewManager::CreateForWebContents(web_contents_); printing::CefPrintViewManager::CreateForWebContents(web_contents_);
if (extensions::ExtensionsEnabled()) { if (extensions::ExtensionsEnabled()) {
extensions::CefExtensionWebContentsObserver::CreateForWebContents(
web_contents_);
// Used by the tabs extension API. // Used by the tabs extension API.
zoom::ZoomController::CreateForWebContents(web_contents_); zoom::ZoomController::CreateForWebContents(web_contents_);
} }

2
libcef/browser/extensions/extensions_api_client.cc
View File

@ -52,8 +52,6 @@ void CefExtensionsAPIClient::AttachWebContentsHelpers(
PrefsTabHelper::CreateForWebContents(web_contents); PrefsTabHelper::CreateForWebContents(web_contents);
printing::CefPrintViewManager::CreateForWebContents(web_contents); printing::CefPrintViewManager::CreateForWebContents(web_contents);
CefExtensionWebContentsObserver::CreateForWebContents(web_contents);
// Used by the PDF extension. // Used by the PDF extension.
pdf::PDFWebContentsHelper::CreateForWebContentsWithClient( pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(
web_contents, std::unique_ptr<pdf::PDFWebContentsHelperClient>( web_contents, std::unique_ptr<pdf::PDFWebContentsHelperClient>(