bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chrome: Fix crash when clicking Reading List sidebar link (fixes issue #3128)

This commit is contained in:
Marshall Greenblatt 2022-01-14 13:52:56 -05:00
parent 9276dba712
commit 51e8bd9bd8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libcef/browser/chrome/chrome_browser_delegate.cc
View File

@ -135,6 +135,14 @@ void ChromeBrowserDelegate::AddNewContents(
content::WebContents* ChromeBrowserDelegate::OpenURLFromTab( content::WebContents* ChromeBrowserDelegate::OpenURLFromTab(
content::WebContents* source, content::WebContents* source,
const content::OpenURLParams& params) { const content::OpenURLParams& params) {
// |source| may be nullptr when opening a link from chrome UI such as the
// Reading List sidebar. In that case we default to using the Browser's
// currently active WebContents.
if (!source) {
source = browser_->tab_strip_model()->GetActiveWebContents();
DCHECK(source);
}
// Return nullptr to cancel the navigation. Otherwise, proceed with default // Return nullptr to cancel the navigation. Otherwise, proceed with default
// chrome handling. // chrome handling.
if (auto delegate = GetDelegateForWebContents(source)) { if (auto delegate = GetDelegateForWebContents(source)) {