bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace NOTREACHED() with DCHECK(false) (fixes #3500)

Browse Source 
Restores the old behavior of assertion in Debug build only.
This commit is contained in:
Marshall Greenblatt
2023-05-08 18:22:46 +03:00
parent 153b1862fa
commit 4dbecb3301
88 changed files with 389 additions and 389 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libcef/browser/native/browser_platform_delegate_native_aura.cc
View File

@@ -161,7 +161,7 @@ ui::MouseEvent CefBrowserPlatformDelegateNativeAura::TranslateUiClickEvent(
changed_button_flags |= ui::EF_RIGHT_MOUSE_BUTTON;
break;
default:
NOTREACHED();
DCHECK(false);
}
ui::MouseEvent result(event_type, location, root_location, time_stamp, flags,

2
libcef/browser/native/browser_platform_delegate_native_linux.cc
View File

@@ -276,7 +276,7 @@ ui::KeyEvent CefBrowserPlatformDelegateNativeLinux::TranslateUiKeyEvent(
type = ui::ET_KEY_RELEASED;
break;
default:
NOTREACHED();
DCHECK(false);
}
#if BUILDFLAG(OZONE_PLATFORM_X11)

2
libcef/browser/native/browser_platform_delegate_native_mac.mm
View File

@@ -563,7 +563,7 @@ CefBrowserPlatformDelegateNativeMac::TranslateWebClickEvent(
result.button = blink::WebMouseEvent::Button::kRight;
break;
default:
NOTREACHED();
DCHECK(false);
}
result.click_count = clickCount;

4
libcef/browser/native/browser_platform_delegate_native_win.cc
View File

@@ -466,7 +466,7 @@ bool CefBrowserPlatformDelegateNativeWin::HandleKeyboardEvent(
msg.message = event.is_system_key ? WM_SYSCHAR : WM_CHAR;
break;
default:
NOTREACHED();
DCHECK(false);
return false;
}
@@ -521,7 +521,7 @@ ui::KeyEvent CefBrowserPlatformDelegateNativeWin::TranslateUiKeyEvent(
type = ui::ET_KEY_RELEASED;
break;
default:
NOTREACHED();
DCHECK(false);
}
ui::DomKey dom_key =

2
libcef/browser/native/cursor_util_aura.cc
View File

@@ -70,7 +70,7 @@ display::Display::Rotation OrientationAngleToRotation(
if (orientation_angle == 270) {
return display::Display::ROTATE_90;
}
NOTREACHED();
DCHECK(false);
return display::Display::ROTATE_0;
}