From 47798d3dbfe71e77a12a95f9305f0afb40a38100 Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Tue, 4 Jun 2024 14:11:57 -0400 Subject: [PATCH] Fix potential dangling PendingRequest::request_ (see #3239) See https://magpcss.org/ceforum/viewtopic.php?f=6&t=19802 for error. --- libcef/browser/net_service/resource_request_handler_wrapper.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libcef/browser/net_service/resource_request_handler_wrapper.cc b/libcef/browser/net_service/resource_request_handler_wrapper.cc index 0fa4dd94e..4dbfebd8c 100644 --- a/libcef/browser/net_service/resource_request_handler_wrapper.cc +++ b/libcef/browser/net_service/resource_request_handler_wrapper.cc @@ -140,10 +140,11 @@ class InterceptedRequestHandlerWrapper : public InterceptedRequestHandler { void Run(InterceptedRequestHandlerWrapper* self) { self->OnBeforeRequest(id_, request_, request_was_redirected_, std::move(callback_), std::move(cancel_callback_)); + request_ = nullptr; } const int32_t id_; - const raw_ptr request_; + raw_ptr request_; const bool request_was_redirected_; OnBeforeRequestResultCallback callback_; CancelRequestCallback cancel_callback_;