mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2025-06-05 21:39:12 +02:00
Fix command-line override of the User-Agent product component (see issue #2622).
When the NetworkService is enabled the U-A string is configured via SystemNetworkContextManager::CreateDefaultNetworkContextParams, which calls chrome_content_browser_client.cc GetUserAgent(). This change modifies the Chrome implementation to match CEF, so that the U-A product component can still be overridden via the `--product-version` command-line flag. To test: Verify that chrome://version, navigator.userAgent (JS executed from DevTools console) and network requests (headers shown in DevTools Network tab) show the expected User-Agent value in the following cases: - Running `cefclient --enable-network-service --user-agent="<value>"` - Running `cefclient --enable-network-service --product-version="<value>"`
This commit is contained in:
37
patch/patches/chrome_browser_product_override.patch
Normal file
37
patch/patches/chrome_browser_product_override.patch
Normal file
@@ -0,0 +1,37 @@
|
||||
diff --git chrome/browser/chrome_content_browser_client.cc chrome/browser/chrome_content_browser_client.cc
|
||||
index 52a1a31ee131..5a1e29fec9c8 100644
|
||||
--- chrome/browser/chrome_content_browser_client.cc
|
||||
+++ chrome/browser/chrome_content_browser_client.cc
|
||||
@@ -1033,12 +1033,16 @@ void LaunchURL(
|
||||
}
|
||||
}
|
||||
|
||||
+} // namespace
|
||||
+
|
||||
std::string GetProduct() {
|
||||
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
|
||||
+ if (command_line->HasSwitch(switches::kProductVersion))
|
||||
+ return command_line->GetSwitchValueASCII(switches::kProductVersion);
|
||||
+
|
||||
return version_info::GetProductNameAndVersionForUserAgent();
|
||||
}
|
||||
|
||||
-} // namespace
|
||||
-
|
||||
std::string GetUserAgent() {
|
||||
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
|
||||
if (command_line->HasSwitch(switches::kUserAgent)) {
|
||||
diff --git chrome/browser/chrome_content_browser_client.h chrome/browser/chrome_content_browser_client.h
|
||||
index cbf1e2218e91..a42d2a4d71bb 100644
|
||||
--- chrome/browser/chrome_content_browser_client.h
|
||||
+++ chrome/browser/chrome_content_browser_client.h
|
||||
@@ -77,7 +77,8 @@ class Origin;
|
||||
|
||||
class ChromeSerialDelegate;
|
||||
|
||||
-// Returns the user agent of Chrome.
|
||||
+// Returns the product and user agent of Chrome.
|
||||
+std::string GetProduct();
|
||||
std::string GetUserAgent();
|
||||
|
||||
blink::UserAgentMetadata GetUserAgentMetadata();
|
Reference in New Issue
Block a user