bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve the timing of OnLoadEnd (fixes issue #3341)

Browse Source 
Use WebContentsDelegate::DidFinishLoad instead of a custom Mojo message.
This fixes flaky OnLoadEnd behavior with NavigationTest.Order.
This commit is contained in:
Marshall Greenblatt
2022-08-25 18:17:51 -04:00
parent 5ec6e62656
commit 37aee4d3a0
12 changed files with 42 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/ceftests/resource_request_handler_unittest.cc
View File

@@ -842,10 +842,15 @@ class BasicResponseTest : public TestHandler {
EXPECT_EQ(browser_id_, browser->GetIdentifier());
EXPECT_TRUE(frame->IsMain());
if (unhandled_)
EXPECT_EQ(httpStatusCode, 0);
else
if (unhandled_) {
if (IsRedirect()) {
EXPECT_EQ(httpStatusCode, 307);
} else {
EXPECT_EQ(httpStatusCode, 0);
}
} else {
EXPECT_EQ(httpStatusCode, 200);
}
on_load_end_ct_++;