bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

- Fix memory leaks in V8 usage (issue #323).

Browse Source 
- Improve performance of V8 string conversions (issue #323).
- Add V8 performance test to cefclient (issue #323).
- Add the ability to return exceptions from V8 accessors (issue #327).
- Return undefined instead of null from a V8 handler if no return value is specified (issue #329).


git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@291 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
Marshall Greenblatt
2011-09-20 20:41:54 +00:00
parent 792e78795f
commit 32402b2287
16 changed files with 376 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libcef_dll/cpptoc/v8accessor_cpptoc.cc
View File

@@ -18,7 +18,7 @@
int CEF_CALLBACK v8accessor_get(struct _cef_v8accessor_t* self,
const cef_string_t* name, struct _cef_v8value_t* object,
struct _cef_v8value_t** retval)
struct _cef_v8value_t** retval, cef_string_t* exception)
{
DCHECK(self);
if(!self)
@@ -29,8 +29,9 @@ int CEF_CALLBACK v8accessor_get(struct _cef_v8accessor_t* self,
objectPtr = CefV8ValueCToCpp::Wrap(object);
CefRefPtr<CefV8Value> retValPtr;
CefString exceptionStr(exception);
bool rv = CefV8AccessorCppToC::Get(self)->Get(CefString(name), objectPtr,
retValPtr);
retValPtr, exceptionStr);
if(rv) {
if(retValPtr.get() && retval)
*retval = CefV8ValueCToCpp::Unwrap(retValPtr);
@@ -41,7 +42,7 @@ int CEF_CALLBACK v8accessor_get(struct _cef_v8accessor_t* self,
int CEF_CALLBACK v8accessor_set(struct _cef_v8accessor_t* self,
const cef_string_t* name, struct _cef_v8value_t* object,
struct _cef_v8value_t* value)
struct _cef_v8value_t* value, cef_string_t* exception)
{
DCHECK(self);
if(!self)
@@ -55,8 +56,9 @@ int CEF_CALLBACK v8accessor_set(struct _cef_v8accessor_t* self,
if(value)
valuePtr = CefV8ValueCToCpp::Wrap(value);
CefString exceptionStr(exception);
bool rv = CefV8AccessorCppToC::Get(self)->Set(CefString(name), objectPtr,
valuePtr);
valuePtr, exceptionStr);
return rv;
}

12
libcef_dll/ctocpp/v8accessor_ctocpp.cc
View File

@@ -17,7 +17,8 @@
// VIRTUAL METHODS - Body may be edited by hand.
bool CefV8AccessorCToCpp::Get(const CefString& name,
const CefRefPtr<CefV8Value> object, CefRefPtr<CefV8Value>& retval)
const CefRefPtr<CefV8Value> object, CefRefPtr<CefV8Value>& retval,
CefString& exception)
{
if(CEF_MEMBER_MISSING(struct_, get))
return false;
@@ -25,7 +26,8 @@ bool CefV8AccessorCToCpp::Get(const CefString& name,
cef_v8value_t* retvalStruct = NULL;
int rv = struct_->get(struct_, name.GetStruct(),
CefV8ValueCppToC::Wrap(object), &retvalStruct);
CefV8ValueCppToC::Wrap(object), &retvalStruct,
exception.GetWritableStruct());
if(retvalStruct)
retval = CefV8ValueCppToC::Unwrap(retvalStruct);
@@ -33,14 +35,16 @@ bool CefV8AccessorCToCpp::Get(const CefString& name,
}
bool CefV8AccessorCToCpp::Set(const CefString& name,
const CefRefPtr<CefV8Value> object, const CefRefPtr<CefV8Value> value)
const CefRefPtr<CefV8Value> object, const CefRefPtr<CefV8Value> value,
CefString& exception)
{
if(CEF_MEMBER_MISSING(struct_, set))
return false;
int rv = struct_->set(struct_, name.GetStruct(),
CefV8ValueCppToC::Wrap(object),
CefV8ValueCppToC::Wrap(value));
CefV8ValueCppToC::Wrap(value),
exception.GetWritableStruct());
return rv ? true : false;
}

4
libcef_dll/ctocpp/v8accessor_ctocpp.h
View File

@@ -32,9 +32,9 @@ public:
// CefV8Accessor methods
virtual bool Get(const CefString& name, const CefRefPtr<CefV8Value> object,
CefRefPtr<CefV8Value>& retval) OVERRIDE;
CefRefPtr<CefV8Value>& retval, CefString& exception) OVERRIDE;
virtual bool Set(const CefString& name, const CefRefPtr<CefV8Value> object,
const CefRefPtr<CefV8Value> value) OVERRIDE;
const CefRefPtr<CefV8Value> value, CefString& exception) OVERRIDE;
};
#endif // BUILDING_CEF_SHARED