From 2c0f941830bad0fbae0db13f7d184a05f78bc638 Mon Sep 17 00:00:00 2001 From: Marshall Greenblatt Date: Tue, 10 May 2011 16:41:41 +0000 Subject: [PATCH] - Explicitly load the URL after calling UIT_CreatePopupWindow (issue #215). git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@231 5089003a-bbd8-11dd-ad1f-f1f9622dbc98 --- libcef/browser_impl.cc | 1 + libcef/browser_webview_delegate.cc | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libcef/browser_impl.cc b/libcef/browser_impl.cc index 11ce72600..29a970a18 100644 --- a/libcef/browser_impl.cc +++ b/libcef/browser_impl.cc @@ -1380,6 +1380,7 @@ void CefBrowserImpl::UIT_ShowDevTools() CefRefPtr browser = UIT_CreatePopupWindow(devtools_path.value(), features); browser->UIT_CreateDevToolsClient(dev_tools_agent_.get()); + browser->UIT_LoadURL(browser->GetMainFrame(), devtools_path.value()); browser->UIT_Show(WebKit::WebNavigationPolicyNewWindow); } else { // Give focus to the existing inspector window. diff --git a/libcef/browser_webview_delegate.cc b/libcef/browser_webview_delegate.cc index 18c465870..62fc4ac39 100644 --- a/libcef/browser_webview_delegate.cc +++ b/libcef/browser_webview_delegate.cc @@ -638,8 +638,11 @@ void BrowserWebViewDelegate::loadURLExternally( WebFrame* frame, const WebURLRequest& request, WebNavigationPolicy policy) { DCHECK_NE(policy, WebKit::WebNavigationPolicyCurrentTab); - browser_->UIT_CreatePopupWindow(std::string(request.url().spec().data()), - CefPopupFeatures()); + std::string url = request.url().spec().data(); + CefRefPtr newBrowser = + browser_->UIT_CreatePopupWindow(url, CefPopupFeatures()); + if (newBrowser.get() && !url.empty()) + newBrowser->GetMainFrame()->LoadURL(url); } WebNavigationPolicy BrowserWebViewDelegate::decidePolicyForNavigation(