Move message routing from CefBrowser to CefFrame (see issue #2498).

This change moves the SendProcessMessage method from CefBrowser to CefFrame and
adds CefBrowser parameters to OnProcessMessageReceived and
OnDraggableRegionsChanged.

The internal implementation has changed as follows:
- Frame IDs are now a 64-bit combination of the 32-bit render_process_id and
  render_routing_id values that uniquely identify a RenderFrameHost (RFH).
- CefFrameHostImpl objects are now managed by CefBrowserInfo with life span tied
  to RFH expectations. Specifically, a CefFrameHostImpl object representing a
  sub-frame will be created when a RenderFrame is created in the renderer
  process and detached when the associated RenderFrame is deleted or the
  renderer process in which it runs has died.
- The CefFrameHostImpl object representing the main frame will always be valid
  but the underlying RFH (and associated frame ID) may change over time as a
  result of cross-origin navigations. Despite these changes calling LoadURL on
  the main frame object in the browser process will always navigate as expected.
- Speculative RFHs, which may be created as a result of a cross-origin
  navigation and discarded if that navigation is not committed, are now handled
  correctly (e.g. ignored in most cases until they're committed).
- It is less likely, but still possible, to receive a CefFrame object with an
  invalid frame ID (ID < 0). This can happen in cases where a RFH has not yet
  been created for a sub-frame. For example, when OnBeforeBrowse is called
  before initiating navigation in a previously nonexisting sub-frame.

To test: All tests pass with NetworkService enabled and disabled.
This commit is contained in:
Marshall Greenblatt
2019-05-24 23:23:43 +03:00
parent 35295d2e27
commit 241941a44a
80 changed files with 2382 additions and 2378 deletions

View File

@@ -9,14 +9,13 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=97f834d04878d403755dd16060a55dd53a6c7b1a$
// $hash=2124256e7c33c16c141e46243eec1a815539199d$
//
#include "libcef_dll/cpptoc/browser_cpptoc.h"
#include <algorithm>
#include "libcef_dll/cpptoc/browser_host_cpptoc.h"
#include "libcef_dll/cpptoc/frame_cpptoc.h"
#include "libcef_dll/cpptoc/process_message_cpptoc.h"
#include "libcef_dll/shutdown_checker.h"
#include "libcef_dll/transfer_util.h"
@@ -374,30 +373,6 @@ void CEF_CALLBACK browser_get_frame_names(struct _cef_browser_t* self,
transfer_string_list_contents(namesList, names);
}
int CEF_CALLBACK
browser_send_process_message(struct _cef_browser_t* self,
cef_process_id_t target_process,
struct _cef_process_message_t* message) {
shutdown_checker::AssertNotShutdown();
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
DCHECK(self);
if (!self)
return 0;
// Verify param: message; type: refptr_same
DCHECK(message);
if (!message)
return 0;
// Execute
bool _retval = CefBrowserCppToC::Get(self)->SendProcessMessage(
target_process, CefProcessMessageCppToC::Unwrap(message));
// Return type: bool
return _retval;
}
} // namespace
// CONSTRUCTOR - Do not edit by hand.
@@ -423,7 +398,6 @@ CefBrowserCppToC::CefBrowserCppToC() {
GetStruct()->get_frame_count = browser_get_frame_count;
GetStruct()->get_frame_identifiers = browser_get_frame_identifiers;
GetStruct()->get_frame_names = browser_get_frame_names;
GetStruct()->send_process_message = browser_send_process_message;
}
// DESTRUCTOR - Do not edit by hand.

View File

@@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=47ed1f92a294b94c071f554621484722483c3bd6$
// $hash=64b2576447d3776b829e06007036acf579b2c47c$
//
#include "libcef_dll/cpptoc/client_cpptoc.h"
@@ -28,6 +28,7 @@
#include "libcef_dll/cpptoc/render_handler_cpptoc.h"
#include "libcef_dll/cpptoc/request_handler_cpptoc.h"
#include "libcef_dll/ctocpp/browser_ctocpp.h"
#include "libcef_dll/ctocpp/frame_ctocpp.h"
#include "libcef_dll/ctocpp/process_message_ctocpp.h"
namespace {
@@ -261,6 +262,7 @@ client_get_request_handler(struct _cef_client_t* self) {
int CEF_CALLBACK
client_on_process_message_received(struct _cef_client_t* self,
cef_browser_t* browser,
struct _cef_frame_t* frame,
cef_process_id_t source_process,
struct _cef_process_message_t* message) {
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
@@ -272,6 +274,10 @@ client_on_process_message_received(struct _cef_client_t* self,
DCHECK(browser);
if (!browser)
return 0;
// Verify param: frame; type: refptr_diff
DCHECK(frame);
if (!frame)
return 0;
// Verify param: message; type: refptr_diff
DCHECK(message);
if (!message)
@@ -279,8 +285,8 @@ client_on_process_message_received(struct _cef_client_t* self,
// Execute
bool _retval = CefClientCppToC::Get(self)->OnProcessMessageReceived(
CefBrowserCToCpp::Wrap(browser), source_process,
CefProcessMessageCToCpp::Wrap(message));
CefBrowserCToCpp::Wrap(browser), CefFrameCToCpp::Wrap(frame),
source_process, CefProcessMessageCToCpp::Wrap(message));
// Return type: bool
return _retval;

View File

@@ -9,12 +9,13 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=c85e942b6518aa3951dbd47b3ff1097f4a6f88fa$
// $hash=9c1c7a83aab83ba8cdb751db09373aaa49601ded$
//
#include "libcef_dll/cpptoc/drag_handler_cpptoc.h"
#include "libcef_dll/ctocpp/browser_ctocpp.h"
#include "libcef_dll/ctocpp/drag_data_ctocpp.h"
#include "libcef_dll/ctocpp/frame_ctocpp.h"
#include "libcef_dll/shutdown_checker.h"
namespace {
@@ -52,6 +53,7 @@ int CEF_CALLBACK drag_handler_on_drag_enter(struct _cef_drag_handler_t* self,
void CEF_CALLBACK drag_handler_on_draggable_regions_changed(
struct _cef_drag_handler_t* self,
cef_browser_t* browser,
struct _cef_frame_t* frame,
size_t regionsCount,
cef_draggable_region_t const* regions) {
shutdown_checker::AssertNotShutdown();
@@ -65,6 +67,10 @@ void CEF_CALLBACK drag_handler_on_draggable_regions_changed(
DCHECK(browser);
if (!browser)
return;
// Verify param: frame; type: refptr_diff
DCHECK(frame);
if (!frame)
return;
// Verify param: regions; type: simple_vec_byref_const
DCHECK(regionsCount == 0 || regions);
if (regionsCount > 0 && !regions)
@@ -81,7 +87,8 @@ void CEF_CALLBACK drag_handler_on_draggable_regions_changed(
// Execute
CefDragHandlerCppToC::Get(self)->OnDraggableRegionsChanged(
CefBrowserCToCpp::Wrap(browser), regionsList);
CefBrowserCToCpp::Wrap(browser), CefFrameCToCpp::Wrap(frame),
regionsList);
}
} // namespace

View File

@@ -9,11 +9,12 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=eaff0c45fa3549df59bb9e64d5ac189205136ed3$
// $hash=49a9d7412f4d9b8d5d7e15ce9f6f62e1b03ea248$
//
#include "libcef_dll/cpptoc/frame_cpptoc.h"
#include "libcef_dll/cpptoc/browser_cpptoc.h"
#include "libcef_dll/cpptoc/process_message_cpptoc.h"
#include "libcef_dll/cpptoc/request_cpptoc.h"
#include "libcef_dll/cpptoc/urlrequest_cpptoc.h"
#include "libcef_dll/cpptoc/v8context_cpptoc.h"
@@ -440,6 +441,27 @@ frame_create_urlrequest(struct _cef_frame_t* self,
return CefURLRequestCppToC::Wrap(_retval);
}
void CEF_CALLBACK
frame_send_process_message(struct _cef_frame_t* self,
cef_process_id_t target_process,
struct _cef_process_message_t* message) {
shutdown_checker::AssertNotShutdown();
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
DCHECK(self);
if (!self)
return;
// Verify param: message; type: refptr_same
DCHECK(message);
if (!message)
return;
// Execute
CefFrameCppToC::Get(self)->SendProcessMessage(
target_process, CefProcessMessageCppToC::Unwrap(message));
}
} // namespace
// CONSTRUCTOR - Do not edit by hand.
@@ -470,6 +492,7 @@ CefFrameCppToC::CefFrameCppToC() {
GetStruct()->get_v8context = frame_get_v8context;
GetStruct()->visit_dom = frame_visit_dom;
GetStruct()->create_urlrequest = frame_create_urlrequest;
GetStruct()->send_process_message = frame_send_process_message;
}
// DESTRUCTOR - Do not edit by hand.

View File

@@ -9,7 +9,7 @@
// implementations. See the translator.README.txt file in the tools directory
// for more information.
//
// $hash=7b918e87169c8fee39d93a9093ac700eceb6a061$
// $hash=1abf9303cc2c0f6d86b9e84b4edddcb294330294$
//
#include "libcef_dll/cpptoc/render_process_handler_cpptoc.h"
@@ -239,6 +239,7 @@ void CEF_CALLBACK render_process_handler_on_focused_node_changed(
int CEF_CALLBACK render_process_handler_on_process_message_received(
struct _cef_render_process_handler_t* self,
cef_browser_t* browser,
cef_frame_t* frame,
cef_process_id_t source_process,
cef_process_message_t* message) {
// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING
@@ -250,6 +251,10 @@ int CEF_CALLBACK render_process_handler_on_process_message_received(
DCHECK(browser);
if (!browser)
return 0;
// Verify param: frame; type: refptr_diff
DCHECK(frame);
if (!frame)
return 0;
// Verify param: message; type: refptr_diff
DCHECK(message);
if (!message)
@@ -258,8 +263,8 @@ int CEF_CALLBACK render_process_handler_on_process_message_received(
// Execute
bool _retval =
CefRenderProcessHandlerCppToC::Get(self)->OnProcessMessageReceived(
CefBrowserCToCpp::Wrap(browser), source_process,
CefProcessMessageCToCpp::Wrap(message));
CefBrowserCToCpp::Wrap(browser), CefFrameCToCpp::Wrap(frame),
source_process, CefProcessMessageCToCpp::Wrap(message));
// Return type: bool
return _retval;