Introduce the use of Chromium types (issue #1336).

Changes to the CEF public API:
- Add base::Bind, base::Callback, base::Lock, base::WeakPtr, scoped_refptr, scoped_ptr and supporting types.
- Add include/wrapper/cef_closure_task.h helpers for converting a base::Closure to a CefTask.
- Change CefRefPtr to extend scoped_refptr.
-- Change CefBase method signatures to match RefCountedThreadSafeBase.
- Change IMPLEMENT_REFCOUNTING to use base::AtomicRefCount*.
-- Remove the CefAtomic* functions.
-- IMPLEMENT_REFCOUNTING now enforces via a compile-time error that the correct class name was passed to the macro.
- Change IMPLEMENT_LOCKING to use base::Lock.
-- Remove the CefCriticalSection class.
-- Deprecate the IMPLEMENT_LOCKING macro.
-- base::Lock will DCHECK() in Debug builds if lock usage is reentrant.
- Move include/internal/cef_tuple.h to include/base/cef_tuple.h.
- Allow an empty |callback| parameter passed to CefBeginTracing.

Changes to the CEF implementation:
- Fix incorrect names passed to the IMPLEMENT_REFCOUNTING macro.
- Fix instances of reentrant locking in the CefXmlObject and CefRequest implementations.
- Remove use of the IMPLEMENT_LOCKING macro.

Changes to cef_unittests:
- Add tests/unittests/chromium_includes.h and always include it first from unit test .cc files to avoid name conflicts with Chromium types.
- Fix wrong header include ordering.
- Remove use of the IMPLEMENT_LOCKING macro.

Changes to cefclient and cefsimple:
- Use base::Bind and cef_closure_task.h instead of NewCefRunnable*.
- Remove use of the IMPEMENT_LOCKING macro.
- Fix incorrect/unnecessary locking.
- Add additional runtime thread checks.
- Windows: Perform actions on the UI thread instead of the main thread when running in multi-threaded-message-loop mode to avoid excessive locking.

git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@1769 5089003a-bbd8-11dd-ad1f-f1f9622dbc98

libcef/common/drag_data_impl.cc

@@ -32,65 +32,65 @@ CefRefPtr<CefDragData> CefDragData::Create() {
 CefRefPtr<CefDragData> CefDragDataImpl::Clone() {
   CefDragDataImpl* drag_data = NULL;
   {
-    AutoLock lock_scope(this);
+    base::AutoLock lock_scope(lock_);
     drag_data = new CefDragDataImpl(data_);
   }
   return drag_data;
 }
 
 bool CefDragDataImpl::IsReadOnly() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return read_only_;
 }
 
 bool CefDragDataImpl::IsLink() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return (data_.url.is_valid() && data_.file_description_filename.empty());
 }
 
 bool CefDragDataImpl::IsFragment() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return (!data_.url.is_valid() && data_.file_description_filename.empty() &&
           data_.filenames.empty());
 }
 
 bool CefDragDataImpl::IsFile() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return (!data_.file_description_filename.empty() || !data_.filenames.empty());
 }
 
 CefString CefDragDataImpl::GetLinkURL() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.url.spec();
 }
 
 CefString CefDragDataImpl::GetLinkTitle() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.url_title;
 }
 
 CefString CefDragDataImpl::GetLinkMetadata() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.download_metadata;
 }
 
 CefString CefDragDataImpl::GetFragmentText() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.text.is_null() ? CefString() : CefString(data_.text.string());
 }
 
 CefString CefDragDataImpl::GetFragmentHtml() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.html.is_null() ? CefString() : CefString(data_.html.string());
 }
 
 CefString CefDragDataImpl::GetFragmentBaseURL() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   return data_.html_base_url.spec();
 }
 
 CefString CefDragDataImpl::GetFileName() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   if (data_.file_description_filename.empty())
     return CefString();
 
@@ -108,7 +108,7 @@ CefString CefDragDataImpl::GetFileName() {
 }
 
 size_t CefDragDataImpl::GetFileContents(CefRefPtr<CefStreamWriter> writer) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   if (data_.file_contents.empty())
     return 0;
 
@@ -122,7 +122,7 @@ size_t CefDragDataImpl::GetFileContents(CefRefPtr<CefStreamWriter> writer) {
 }
 
 bool CefDragDataImpl::GetFileNames(std::vector<CefString>& names) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   if (data_.filenames.empty())
     return false;
 
@@ -135,43 +135,43 @@ bool CefDragDataImpl::GetFileNames(std::vector<CefString>& names) {
 }
 
 void CefDragDataImpl::SetLinkURL(const CefString& url) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.url = GURL(url.ToString());
 }
 
 void CefDragDataImpl::SetLinkTitle(const CefString& title) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.url_title = title.ToString16();
 }
 
 void CefDragDataImpl::SetLinkMetadata(const CefString& data) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.download_metadata = data.ToString16();
 }
 
 void CefDragDataImpl::SetFragmentText(const CefString& text) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.text = base::NullableString16(text.ToString16(), false);
 }
 
 void CefDragDataImpl::SetFragmentHtml(const CefString& fragment) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.html = base::NullableString16(fragment.ToString16(), false);
 }
 
 void CefDragDataImpl::SetFragmentBaseURL(const CefString& fragment) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.html_base_url = GURL(fragment.ToString());
 }
 
 void CefDragDataImpl::ResetFileContents() {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.file_contents.erase();
   data_.file_description_filename.erase();
@@ -179,14 +179,14 @@ void CefDragDataImpl::ResetFileContents() {
 
 void CefDragDataImpl::AddFile(const CefString& path,
                               const CefString& display_name) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   CHECK_READONLY_RETURN_VOID();
   data_.filenames.push_back(ui::FileInfo(base::FilePath(path),
                                          base::FilePath(display_name)));
 }
 
 void CefDragDataImpl::SetReadOnly(bool read_only) {
-  AutoLock lock_scope(this);
+  base::AutoLock lock_scope(lock_);
   if (read_only_ == read_only)
     return;