tests: Format with clang-tidy (see #3632)

This commit is contained in:
Marshall Greenblatt
2024-01-19 21:22:56 -05:00
parent 9fd312ce04
commit 0a64bb6f9b
108 changed files with 505 additions and 647 deletions

View File

@@ -22,34 +22,34 @@
namespace client {
#define DEFAULT_QUERY_INTERFACE(__Class) \
HRESULT __stdcall QueryInterface(const IID& iid, void** object) { \
*object = nullptr; \
if (IsEqualIID(iid, IID_IUnknown)) { \
IUnknown* obj = this; \
*object = obj; \
} else if (IsEqualIID(iid, IID_##__Class)) { \
__Class* obj = this; \
*object = obj; \
} else { \
return E_NOINTERFACE; \
} \
AddRef(); \
return S_OK; \
#define DEFAULT_QUERY_INTERFACE(__Class) \
HRESULT __stdcall QueryInterface(const IID& iid, void** object) override { \
*object = nullptr; \
if (IsEqualIID(iid, IID_IUnknown)) { \
IUnknown* obj = this; \
*object = obj; \
} else if (IsEqualIID(iid, IID_##__Class)) { \
__Class* obj = this; \
*object = obj; \
} else { \
return E_NOINTERFACE; \
} \
AddRef(); \
return S_OK; \
}
#define IUNKNOWN_IMPLEMENTATION \
ULONG __stdcall AddRef() { \
return ++ref_count_; \
} \
ULONG __stdcall Release() { \
if (--ref_count_ == 0) { \
delete this; \
return 0U; \
} \
return ref_count_; \
} \
\
protected: \
#define IUNKNOWN_IMPLEMENTATION \
ULONG __stdcall AddRef() override { \
return ++ref_count_; \
} \
ULONG __stdcall Release() override { \
if (--ref_count_ == 0) { \
delete this; \
return 0U; \
} \
return ref_count_; \
} \
\
protected: \
ULONG ref_count_;
class DropTargetWin : public IDropTarget {
@@ -67,18 +67,18 @@ class DropTargetWin : public IDropTarget {
HRESULT __stdcall DragEnter(IDataObject* data_object,
DWORD key_state,
POINTL cursor_position,
DWORD* effect);
DWORD* effect) override;
HRESULT __stdcall DragOver(DWORD key_state,
POINTL cursor_position,
DWORD* effect);
DWORD* effect) override;
HRESULT __stdcall DragLeave();
HRESULT __stdcall DragLeave() override;
HRESULT __stdcall Drop(IDataObject* data_object,
DWORD key_state,
POINTL cursor_position,
DWORD* effect);
DWORD* effect) override;
DEFAULT_QUERY_INTERFACE(IDropTarget)
IUNKNOWN_IMPLEMENTATION
@@ -86,7 +86,7 @@ class DropTargetWin : public IDropTarget {
protected:
DropTargetWin(OsrDragEvents* callback, HWND hWnd)
: ref_count_(0), callback_(callback), hWnd_(hWnd) {}
virtual ~DropTargetWin() {}
virtual ~DropTargetWin() = default;
private:
OsrDragEvents* callback_;
@@ -100,16 +100,17 @@ class DropSourceWin : public IDropSource {
static CComPtr<DropSourceWin> Create();
// IDropSource implementation:
HRESULT __stdcall GiveFeedback(DWORD dwEffect);
HRESULT __stdcall GiveFeedback(DWORD dwEffect) override;
HRESULT __stdcall QueryContinueDrag(BOOL fEscapePressed, DWORD grfKeyState);
HRESULT __stdcall QueryContinueDrag(BOOL fEscapePressed,
DWORD grfKeyState) override;
DEFAULT_QUERY_INTERFACE(IDropSource)
IUNKNOWN_IMPLEMENTATION
protected:
explicit DropSourceWin() : ref_count_(0) {}
virtual ~DropSourceWin() {}
virtual ~DropSourceWin() = default;
};
class DragEnumFormatEtc : public IEnumFORMATETC {
@@ -123,10 +124,10 @@ class DragEnumFormatEtc : public IEnumFORMATETC {
//
HRESULT __stdcall Next(ULONG celt,
FORMATETC* pFormatEtc,
ULONG* pceltFetched);
HRESULT __stdcall Skip(ULONG celt);
HRESULT __stdcall Reset(void);
HRESULT __stdcall Clone(IEnumFORMATETC** ppEnumFormatEtc);
ULONG* pceltFetched) override;
HRESULT __stdcall Skip(ULONG celt) override;
HRESULT __stdcall Reset() override;
HRESULT __stdcall Clone(IEnumFORMATETC** ppEnumFormatEtc) override;
//
// Construction / Destruction
@@ -152,23 +153,24 @@ class DataObjectWin : public IDataObject {
int count);
// IDataObject memberS
HRESULT __stdcall GetDataHere(FORMATETC* pFormatEtc, STGMEDIUM* pmedium);
HRESULT __stdcall QueryGetData(FORMATETC* pFormatEtc);
HRESULT __stdcall GetDataHere(FORMATETC* pFormatEtc,
STGMEDIUM* pmedium) override;
HRESULT __stdcall QueryGetData(FORMATETC* pFormatEtc) override;
HRESULT __stdcall GetCanonicalFormatEtc(FORMATETC* pFormatEct,
FORMATETC* pFormatEtcOut);
FORMATETC* pFormatEtcOut) override;
HRESULT __stdcall SetData(FORMATETC* pFormatEtc,
STGMEDIUM* pMedium,
BOOL fRelease);
BOOL fRelease) override;
HRESULT __stdcall DAdvise(FORMATETC* pFormatEtc,
DWORD advf,
IAdviseSink*,
DWORD*);
HRESULT __stdcall DUnadvise(DWORD dwConnection);
HRESULT __stdcall EnumDAdvise(IEnumSTATDATA** ppEnumAdvise);
DWORD*) override;
HRESULT __stdcall DUnadvise(DWORD dwConnection) override;
HRESULT __stdcall EnumDAdvise(IEnumSTATDATA** ppEnumAdvise) override;
HRESULT __stdcall EnumFormatEtc(DWORD dwDirection,
IEnumFORMATETC** ppEnumFormatEtc);
HRESULT __stdcall GetData(FORMATETC* pFormatEtc, STGMEDIUM* pMedium);
IEnumFORMATETC** ppEnumFormatEtc) override;
HRESULT __stdcall GetData(FORMATETC* pFormatEtc, STGMEDIUM* pMedium) override;
DEFAULT_QUERY_INTERFACE(IDataObject)
IUNKNOWN_IMPLEMENTATION
@@ -183,7 +185,7 @@ class DataObjectWin : public IDataObject {
int LookupFormatEtc(FORMATETC* pFormatEtc);
explicit DataObjectWin(FORMATETC* fmtetc, STGMEDIUM* stgmed, int count);
virtual ~DataObjectWin() {}
virtual ~DataObjectWin() = default;
};
} // namespace client