Disable Chromium field trials in official builds (fixes #3560)

This commit is contained in:
Marshall Greenblatt 2023-08-30 13:21:06 -04:00
parent 5f8d100619
commit 0726eefbe0

View File

@ -466,14 +466,18 @@ def GetConfigArgs(args, is_debug, cpu):
""" """
add_args = {} add_args = {}
# Cannot create is_official_build=true is_debug=true builds. if GetArgValue(args, 'is_official_build'):
# This restriction is enforced in //build/config/BUILDCONFIG.gn. # Disable Chromium field trials in official builds.
# Instead, our "official Debug" build is a Release build with dchecks and add_args['disable_fieldtrial_testing_config'] = True
# symbols. Symbols will be generated by default for official builds; see the
# definition of 'symbol_level' in //build/config/compiler/compiler.gni. # Cannot create is_official_build=true is_debug=true builds.
if is_debug and GetArgValue(args, 'is_official_build'): # This restriction is enforced in //build/config/BUILDCONFIG.gn.
is_debug = False # Instead, our "official Debug" build is a Release build with dchecks and
add_args['dcheck_always_on'] = True # symbols. Symbols will be generated by default for official builds; see the
# definition of 'symbol_level' in //build/config/compiler/compiler.gni.
if is_debug:
is_debug = False
add_args['dcheck_always_on'] = True
result = MergeDicts(args, add_args, { result = MergeDicts(args, add_args, {
'is_debug': is_debug, 'is_debug': is_debug,