mirror of
https://bitbucket.org/chromiumembedded/cef
synced 2025-06-05 21:39:12 +02:00
Improvements to unit test behavior.
- Standardize the test timeout implementation using a new TestHandler::SetTestTimeout method and enable timeouts for almost all tests. The test timeout can be disabled globally using a new `--disable-test-timeout` command-line flag. - Wait for TestHandler object destruction at the end of each test using a new ReleaseAndWaitForDestructor function. This avoids test state leakage and verifies that no object references are leaked. git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@1964 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
@@ -123,6 +123,9 @@ class NetNotifyTestHandler : public TestHandler {
|
||||
// Navigate to the 2nd URL.
|
||||
context_handler_->SetURL(url2_);
|
||||
GetBrowser()->GetMainFrame()->LoadURL(url2_);
|
||||
|
||||
// Time out the test after a reasonable period of time.
|
||||
SetTestTimeout();
|
||||
}
|
||||
|
||||
bool OnBeforeResourceLoad(CefRefPtr<CefBrowser> browser,
|
||||
@@ -448,6 +451,10 @@ void RunNetNotifyTest(NetNotifyTestType test_type, bool same_origin) {
|
||||
|
||||
collection.ExecuteTests();
|
||||
|
||||
ReleaseAndWaitForDestructor(handler1);
|
||||
ReleaseAndWaitForDestructor(handler2);
|
||||
ReleaseAndWaitForDestructor(handler3);
|
||||
|
||||
g_net_notify_test = false;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user