bcarrella
/
cef
mirror of https://bitbucket.org/chromiumembedded/cef
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cef/patch/patches/win_cpp17_msvc_sandbox_2819...

29 lines
847 B
Diff
Raw Normal View History

Windows: Build the double_conversion target as C++17 (fixes issue #2819) This works around a bug in the Visual C++ standard library where the std::is_integral templates are exported instead of inlined when building with C++14. See also https://bugs.llvm.org/show_bug.cgi?id=42027.
2020-01-07 14:07:03 +01:00
diff --git base/third_party/double_conversion/BUILD.gn base/third_party/double_conversion/BUILD.gn
index 0083efdcd9c8..6f647c31e28a 100644
--- base/third_party/double_conversion/BUILD.gn
+++ base/third_party/double_conversion/BUILD.gn
@@ -9,6 +9,11 @@ config("config") {
"-Wno-unused-const-variable",
"-Wno-unused-function",
]
+
+ # Build as C++17 to avoid export of templates that should be inlined.
+ if (is_win) {
+ cflags_cc = [ "/std:c++17" ]
+ }
}
static_library("double_conversion") {
Windows: Build the pe_image target as C++17 (see issue #2819) This works around a bug in the Visual C++ standard library where the std::is_integral templates are exported instead of inlined when building with C++14. See also https://bugs.llvm.org/show_bug.cgi?id=42027.
2020-02-19 02:18:35 +01:00
diff --git base/win/BUILD.gn base/win/BUILD.gn
Update to Chromium version 86.0.4240.0 (#800218) - CefURLRequest::Create is no longer supported in the renderer process (see https://crbug.com/891872). Use CefFrame::CreateURLRequest instead. - Mac platform definitions have been changed from `MACOSX` to `MAC` (see https://crbug.com/1105907) and related CMake macro names have been updated. The old `OS_MACOSX` define is still set in code and CMake for backwards compatibility. - Linux ARM build is currently broken (see https://crbug.com/1123214).
2020-08-29 00:39:23 +02:00
index eb5dca74bcea..be10cc59b39c 100644
Windows: Build the pe_image target as C++17 (see issue #2819) This works around a bug in the Visual C++ standard library where the std::is_integral templates are exported instead of inlined when building with C++14. See also https://bugs.llvm.org/show_bug.cgi?id=42027.
2020-02-19 02:18:35 +01:00
--- base/win/BUILD.gn
+++ base/win/BUILD.gn
Update to Chromium version 86.0.4240.0 (#800218) - CefURLRequest::Create is no longer supported in the renderer process (see https://crbug.com/891872). Use CefFrame::CreateURLRequest instead. - Mac platform definitions have been changed from `MACOSX` to `MAC` (see https://crbug.com/1105907) and related CMake macro names have been updated. The old `OS_MACOSX` define is still set in code and CMake for backwards compatibility. - Linux ARM build is currently broken (see https://crbug.com/1123214).
2020-08-29 00:39:23 +02:00
@@ -33,4 +33,7 @@ static_library("pe_image") {
Windows: Build the pe_image target as C++17 (see issue #2819) This works around a bug in the Visual C++ standard library where the std::is_integral templates are exported instead of inlined when building with C++14. See also https://bugs.llvm.org/show_bug.cgi?id=42027.
2020-02-19 02:18:35 +01:00
"pe_image.cc",
"pe_image.h",
]
+
+ # Build as C++17 to avoid export of templates that should be inlined.
+ cflags_cc = [ "/std:c++17" ]
}