2017-12-07 22:44:24 +01:00
|
|
|
diff --git chrome/browser/plugins/plugin_info_host_impl.cc chrome/browser/plugins/plugin_info_host_impl.cc
|
|
|
|
index 1afbaf86ac40..e2edec854ca7 100644
|
|
|
|
--- chrome/browser/plugins/plugin_info_host_impl.cc
|
|
|
|
+++ chrome/browser/plugins/plugin_info_host_impl.cc
|
|
|
|
@@ -18,6 +18,7 @@
|
|
|
|
#include "base/task_runner_util.h"
|
|
|
|
#include "base/threading/thread_task_runner_handle.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#include "chrome/browser/browser_process.h"
|
|
|
|
#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
|
|
|
|
#include "chrome/browser/plugins/chrome_plugin_service_filter.h"
|
|
|
|
@@ -56,6 +57,11 @@
|
|
|
|
#include "url/origin.h"
|
|
|
|
#include "widevine_cdm_version.h" // In SHARED_INTERMEDIATE_DIR.
|
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+#include "cef/libcef/browser/plugins/plugin_service_filter.h"
|
|
|
|
+#include "cef/libcef/common/extensions/extensions_util.h"
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
#if BUILDFLAG(ENABLE_EXTENSIONS)
|
|
|
|
#include "components/guest_view/browser/guest_view_base.h"
|
|
|
|
#include "extensions/browser/extension_registry.h"
|
|
|
|
@@ -77,12 +83,10 @@ namespace {
|
|
|
|
class ShutdownNotifierFactory
|
|
|
|
: public BrowserContextKeyedServiceShutdownNotifierFactory {
|
|
|
|
public:
|
|
|
|
- static ShutdownNotifierFactory* GetInstance() {
|
|
|
|
- return base::Singleton<ShutdownNotifierFactory>::get();
|
|
|
|
- }
|
|
|
|
+ static ShutdownNotifierFactory* GetInstance();
|
|
|
|
|
|
|
|
private:
|
|
|
|
- friend struct base::DefaultSingletonTraits<ShutdownNotifierFactory>;
|
|
|
|
+ friend struct base::LazyInstanceTraitsBase<ShutdownNotifierFactory>;
|
|
|
|
|
|
|
|
ShutdownNotifierFactory()
|
|
|
|
: BrowserContextKeyedServiceShutdownNotifierFactory(
|
|
|
|
@@ -93,6 +97,14 @@ class ShutdownNotifierFactory
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ShutdownNotifierFactory);
|
|
|
|
};
|
|
|
|
|
|
|
|
+base::LazyInstance<ShutdownNotifierFactory>::Leaky g_shutdown_notifier_factory =
|
|
|
|
+ LAZY_INSTANCE_INITIALIZER;
|
|
|
|
+
|
|
|
|
+// static
|
|
|
|
+ShutdownNotifierFactory* ShutdownNotifierFactory::GetInstance() {
|
|
|
|
+ return g_shutdown_notifier_factory.Pointer();
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
#if BUILDFLAG(ENABLE_LIBRARY_CDMS)
|
|
|
|
|
|
|
|
enum PluginAvailabilityStatusForUMA {
|
|
|
|
@@ -124,6 +136,9 @@ bool IsPluginLoadingAccessibleResourceInWebView(
|
|
|
|
extensions::ExtensionRegistry* extension_registry,
|
|
|
|
int process_id,
|
|
|
|
const GURL& resource) {
|
|
|
|
+ if (!extension_registry)
|
|
|
|
+ return false;
|
|
|
|
+
|
|
|
|
extensions::WebViewRendererState* renderer_state =
|
|
|
|
extensions::WebViewRendererState::GetInstance();
|
|
|
|
std::string partition_id;
|
|
|
|
@@ -153,12 +168,16 @@ bool IsPluginLoadingAccessibleResourceInWebView(
|
|
|
|
PluginInfoHostImpl::Context::Context(int render_process_id, Profile* profile)
|
|
|
|
: render_process_id_(render_process_id),
|
|
|
|
resource_context_(profile->GetResourceContext()),
|
|
|
|
-#if BUILDFLAG(ENABLE_EXTENSIONS)
|
|
|
|
- extension_registry_(extensions::ExtensionRegistry::Get(profile)),
|
|
|
|
-#endif
|
|
|
|
host_content_settings_map_(
|
|
|
|
HostContentSettingsMapFactory::GetForProfile(profile)),
|
|
|
|
plugin_prefs_(PluginPrefs::GetForProfile(profile)) {
|
|
|
|
+#if BUILDFLAG(ENABLE_EXTENSIONS)
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ if (extensions::ExtensionsEnabled())
|
|
|
|
+#endif
|
|
|
|
+ extension_registry_ = extensions::ExtensionRegistry::Get(profile);
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
allow_outdated_plugins_.Init(prefs::kPluginsAllowOutdated,
|
|
|
|
profile->GetPrefs());
|
|
|
|
allow_outdated_plugins_.MoveToThread(
|
|
|
|
@@ -325,6 +344,14 @@ void PluginInfoHostImpl::Context::DecidePluginStatus(
|
|
|
|
PluginMetadata::SecurityStatus security_status,
|
|
|
|
const std::string& plugin_identifier,
|
|
|
|
chrome::mojom::PluginStatus* status) const {
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ // Don't override the user decision.
|
|
|
|
+ if (*status == chrome::mojom::PluginStatus::kBlocked ||
|
|
|
|
+ *status == chrome::mojom::PluginStatus::kDisabled) {
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
if (security_status == PluginMetadata::SECURITY_STATUS_FULLY_TRUSTED) {
|
|
|
|
*status = chrome::mojom::PluginStatus::kAllowed;
|
|
|
|
return;
|
|
|
|
@@ -450,16 +477,36 @@ bool PluginInfoHostImpl::Context::FindEnabledPlugin(
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
+ const bool is_main_frame =
|
|
|
|
+ main_frame_origin.IsSameOriginWith(url::Origin::Create(url));
|
|
|
|
+
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ CefPluginServiceFilter* filter = static_cast<CefPluginServiceFilter*>(
|
|
|
|
+ PluginService::GetInstance()->GetFilter());
|
|
|
|
+ DCHECK(filter);
|
|
|
|
+
|
|
|
|
+ size_t i = 0;
|
|
|
|
+ for (; i < matching_plugins.size(); ++i) {
|
|
|
|
+ if (filter->IsPluginAvailable(render_process_id_, render_frame_id,
|
|
|
|
+ resource_context_, url, is_main_frame,
|
|
|
|
+ main_frame_origin, &matching_plugins[i],
|
|
|
|
+ status)) {
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+#else // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
content::PluginServiceFilter* filter =
|
|
|
|
PluginService::GetInstance()->GetFilter();
|
|
|
|
size_t i = 0;
|
|
|
|
for (; i < matching_plugins.size(); ++i) {
|
|
|
|
if (!filter || filter->IsPluginAvailable(
|
|
|
|
render_process_id_, render_frame_id, resource_context_,
|
|
|
|
- url, main_frame_origin, &matching_plugins[i])) {
|
|
|
|
+ url, is_main_frame, main_frame_origin,
|
|
|
|
+ &matching_plugins[i])) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
// If we broke out of the loop, we have found an enabled plugin.
|
|
|
|
bool enabled = i < matching_plugins.size();
|
|
|
|
diff --git chrome/renderer/chrome_content_renderer_client.cc chrome/renderer/chrome_content_renderer_client.cc
|
|
|
|
index 5dc888bfb2df..297737be682e 100644
|
|
|
|
--- chrome/renderer/chrome_content_renderer_client.cc
|
|
|
|
+++ chrome/renderer/chrome_content_renderer_client.cc
|
|
|
|
@@ -805,6 +805,7 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
|
|
|
|
|
|
|
|
if ((status == chrome::mojom::PluginStatus::kUnauthorized ||
|
|
|
|
status == chrome::mojom::PluginStatus::kBlocked) &&
|
|
|
|
+ observer &&
|
|
|
|
observer->IsPluginTemporarilyAllowed(identifier)) {
|
|
|
|
status = chrome::mojom::PluginStatus::kAllowed;
|
|
|
|
}
|
|
|
|
@@ -992,7 +993,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
|
|
|
|
render_frame->GetRemoteAssociatedInterfaces()->GetInterface(
|
|
|
|
&plugin_auth_host);
|
|
|
|
plugin_auth_host->BlockedUnauthorizedPlugin(group_name, identifier);
|
|
|
|
- observer->DidBlockContentType(content_type, group_name);
|
|
|
|
+ if (observer)
|
|
|
|
+ observer->DidBlockContentType(content_type, group_name);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case chrome::mojom::PluginStatus::kBlocked: {
|
|
|
|
@@ -1001,7 +1003,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
|
|
|
|
l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name));
|
|
|
|
placeholder->AllowLoading();
|
|
|
|
RenderThread::Get()->RecordAction(UserMetricsAction("Plugin_Blocked"));
|
|
|
|
- observer->DidBlockContentType(content_type, group_name);
|
|
|
|
+ if (observer)
|
|
|
|
+ observer->DidBlockContentType(content_type, group_name);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case chrome::mojom::PluginStatus::kBlockedByPolicy: {
|
|
|
|
@@ -1011,7 +1014,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
|
|
|
|
group_name));
|
|
|
|
RenderThread::Get()->RecordAction(
|
|
|
|
UserMetricsAction("Plugin_BlockedByPolicy"));
|
|
|
|
- observer->DidBlockContentType(content_type, group_name);
|
|
|
|
+ if (observer)
|
|
|
|
+ observer->DidBlockContentType(content_type, group_name);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case chrome::mojom::PluginStatus::kBlockedNoLoading: {
|
|
|
|
@@ -1019,7 +1023,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
|
|
|
|
IDR_BLOCKED_PLUGIN_HTML,
|
|
|
|
l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED_NO_LOADING,
|
|
|
|
group_name));
|
|
|
|
- observer->DidBlockContentType(content_type, group_name);
|
|
|
|
+ if (observer)
|
|
|
|
+ observer->DidBlockContentType(content_type, group_name);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case chrome::mojom::PluginStatus::kComponentUpdateRequired: {
|
2018-02-03 01:01:36 +01:00
|
|
|
diff --git chrome/renderer/plugins/chrome_plugin_placeholder.cc chrome/renderer/plugins/chrome_plugin_placeholder.cc
|
|
|
|
index 7a814bb072dc..79c7d65118cb 100644
|
|
|
|
--- chrome/renderer/plugins/chrome_plugin_placeholder.cc
|
|
|
|
+++ chrome/renderer/plugins/chrome_plugin_placeholder.cc
|
|
|
|
@@ -349,8 +349,11 @@ void ChromePluginPlaceholder::OnBlockedContent(
|
|
|
|
|
|
|
|
if (status ==
|
|
|
|
content::RenderFrame::PeripheralContentStatus::CONTENT_STATUS_TINY) {
|
|
|
|
- ContentSettingsObserver::Get(render_frame())
|
|
|
|
- ->DidBlockContentType(CONTENT_SETTINGS_TYPE_PLUGINS, title_);
|
|
|
|
+ ContentSettingsObserver* observer =
|
|
|
|
+ ContentSettingsObserver::Get(render_frame());
|
|
|
|
+ if (observer) {
|
|
|
|
+ observer->DidBlockContentType(CONTENT_SETTINGS_TYPE_PLUGINS, title_);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
|
|
|
|
std::string message = base::StringPrintf(
|