2014-09-04 19:53:40 +02:00
|
|
|
diff --git Source/web/ChromeClientImpl.cpp Source/web/ChromeClientImpl.cpp
|
2016-10-21 21:52:29 +02:00
|
|
|
index f1a79c4..021a083 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- Source/web/ChromeClientImpl.cpp
|
|
|
|
+++ Source/web/ChromeClientImpl.cpp
|
2016-10-21 21:52:29 +02:00
|
|
|
@@ -892,7 +892,7 @@ bool ChromeClientImpl::hasOpenedPopup() const {
|
|
|
|
PopupMenu* ChromeClientImpl::openPopupMenu(LocalFrame& frame,
|
|
|
|
HTMLSelectElement& select) {
|
|
|
|
notifyPopupOpeningObservers();
|
|
|
|
- if (WebViewImpl::useExternalPopupMenus())
|
|
|
|
+ if (m_webView->useExternalPopupMenus())
|
|
|
|
return new ExternalPopupMenu(frame, select, *m_webView);
|
2014-07-01 00:30:29 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
DCHECK(RuntimeEnabledFeatures::pagePopupEnabled());
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git Source/web/WebViewImpl.cpp Source/web/WebViewImpl.cpp
|
2016-10-26 02:19:54 +02:00
|
|
|
index 6c8ca56..3f0d9a8 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- Source/web/WebViewImpl.cpp
|
|
|
|
+++ Source/web/WebViewImpl.cpp
|
2016-10-21 21:52:29 +02:00
|
|
|
@@ -405,6 +405,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
|
|
|
|
m_enableFakePageScaleAnimationForTesting(false),
|
|
|
|
m_fakePageScaleAnimationPageScaleFactor(0),
|
|
|
|
m_fakePageScaleAnimationUseAnchor(false),
|
|
|
|
+ m_shouldUseExternalPopupMenus(shouldUseExternalPopupMenus),
|
|
|
|
m_doingDragAndDrop(false),
|
|
|
|
m_ignoreInputEvents(false),
|
|
|
|
m_compositorDeviceScaleFactorOverride(0),
|
2016-10-26 02:19:54 +02:00
|
|
|
@@ -4246,8 +4247,13 @@ void WebViewImpl::mainFrameScrollOffsetChanged() {
|
2016-10-21 21:52:29 +02:00
|
|
|
m_devToolsEmulator->mainFrameScrollOrScaleChanged();
|
2014-07-01 00:30:29 +02:00
|
|
|
}
|
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
+void WebViewImpl::setUseExternalPopupMenusThisInstance(
|
|
|
|
+ bool useExternalPopupMenus) {
|
|
|
|
+ m_shouldUseExternalPopupMenus = useExternalPopupMenus;
|
2014-07-01 00:30:29 +02:00
|
|
|
+}
|
|
|
|
+
|
2016-10-21 21:52:29 +02:00
|
|
|
bool WebViewImpl::useExternalPopupMenus() {
|
|
|
|
- return shouldUseExternalPopupMenus;
|
|
|
|
+ return m_shouldUseExternalPopupMenus;
|
2014-07-01 00:30:29 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void WebViewImpl::startDragging(LocalFrame* frame,
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git Source/web/WebViewImpl.h Source/web/WebViewImpl.h
|
2016-10-26 02:19:54 +02:00
|
|
|
index 238b096..c4feb3b 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- Source/web/WebViewImpl.h
|
|
|
|
+++ Source/web/WebViewImpl.h
|
2016-10-26 02:19:54 +02:00
|
|
|
@@ -379,7 +379,8 @@ class WEB_EXPORT WebViewImpl final
|
2014-07-01 00:30:29 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
// Returns true if popup menus should be rendered by the browser, false if
|
|
|
|
// they should be rendered by WebKit (which is the default).
|
|
|
|
- static bool useExternalPopupMenus();
|
|
|
|
+ void setUseExternalPopupMenusThisInstance(bool);
|
|
|
|
+ bool useExternalPopupMenus();
|
2014-07-01 00:30:29 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
bool shouldAutoResize() const { return m_shouldAutoResize; }
|
2014-07-01 00:30:29 +02:00
|
|
|
|
2016-10-26 02:19:54 +02:00
|
|
|
@@ -684,6 +685,8 @@ class WEB_EXPORT WebViewImpl final
|
2016-10-21 21:52:29 +02:00
|
|
|
float m_fakePageScaleAnimationPageScaleFactor;
|
|
|
|
bool m_fakePageScaleAnimationUseAnchor;
|
|
|
|
|
|
|
|
+ bool m_shouldUseExternalPopupMenus;
|
2014-07-01 00:30:29 +02:00
|
|
|
+
|
2016-10-21 21:52:29 +02:00
|
|
|
bool m_doingDragAndDrop;
|
2014-07-01 00:30:29 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
bool m_ignoreInputEvents;
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git public/web/WebView.h public/web/WebView.h
|
2016-10-26 02:19:54 +02:00
|
|
|
index d877ff0..edfc975 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- public/web/WebView.h
|
|
|
|
+++ public/web/WebView.h
|
2016-10-26 02:19:54 +02:00
|
|
|
@@ -440,6 +440,7 @@ class WebView : protected WebWidget {
|
2014-09-04 19:53:40 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
// Sets whether select popup menus should be rendered by the browser.
|
|
|
|
BLINK_EXPORT static void setUseExternalPopupMenus(bool);
|
|
|
|
+ virtual void setUseExternalPopupMenusThisInstance(bool) = 0;
|
2014-09-04 19:53:40 +02:00
|
|
|
|
2016-10-21 21:52:29 +02:00
|
|
|
// Hides any popup (suggestions, selects...) that might be showing.
|
|
|
|
virtual void hidePopups() = 0;
|