2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/client/prune_crash_reports.cc third_party/crashpad/crashpad/client/prune_crash_reports.cc
|
2017-12-07 22:44:24 +01:00
|
|
|
index d045eb6a65a0..bc347a30ea26 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/client/prune_crash_reports.cc
|
|
|
|
+++ third_party/crashpad/crashpad/client/prune_crash_reports.cc
|
2017-12-07 22:44:24 +01:00
|
|
|
@@ -66,13 +66,19 @@ void PruneCrashReportDatabase(CrashReportDatabase* database,
|
2016-12-12 11:05:29 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
|
|
|
-std::unique_ptr<PruneCondition> PruneCondition::GetDefault() {
|
|
|
|
+std::unique_ptr<PruneCondition> PruneCondition::GetDefault(
|
|
|
|
+ int max_size_in_mb,
|
|
|
|
+ int max_age_in_days) {
|
|
|
|
// DatabaseSizePruneCondition must be the LHS so that it is always evaluated,
|
|
|
|
// due to the short-circuting behavior of BinaryPruneCondition.
|
|
|
|
+ if (max_size_in_mb <= 0)
|
|
|
|
+ max_size_in_mb = 128;
|
|
|
|
+ if (max_age_in_days <= 0)
|
|
|
|
+ max_age_in_days = 365;
|
2017-12-07 22:44:24 +01:00
|
|
|
return std::make_unique<BinaryPruneCondition>(
|
|
|
|
BinaryPruneCondition::OR,
|
|
|
|
- new DatabaseSizePruneCondition(1024 * 128),
|
|
|
|
- new AgePruneCondition(365));
|
|
|
|
+ new DatabaseSizePruneCondition(1024 * max_size_in_mb),
|
|
|
|
+ new AgePruneCondition(max_age_in_days));
|
2016-12-12 11:05:29 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static const time_t kSecondsInDay = 60 * 60 * 24;
|
2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/client/prune_crash_reports.h third_party/crashpad/crashpad/client/prune_crash_reports.h
|
2017-09-06 23:40:58 +02:00
|
|
|
index 6dac5f3002b3..34f5ee111d3d 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/client/prune_crash_reports.h
|
|
|
|
+++ third_party/crashpad/crashpad/client/prune_crash_reports.h
|
2016-12-12 11:05:29 +01:00
|
|
|
@@ -57,7 +57,8 @@ class PruneCondition {
|
|
|
|
//! of 128 MB.
|
|
|
|
//!
|
|
|
|
//! \return A PruneCondition for use with PruneCrashReportDatabase().
|
|
|
|
- static std::unique_ptr<PruneCondition> GetDefault();
|
|
|
|
+ static std::unique_ptr<PruneCondition> GetDefault(int max_size_in_mb,
|
|
|
|
+ int max_age_in_days);
|
|
|
|
|
|
|
|
virtual ~PruneCondition() {}
|
|
|
|
|
2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/client/settings.cc third_party/crashpad/crashpad/client/settings.cc
|
2017-09-06 23:40:58 +02:00
|
|
|
index 15d16f2e0928..5e8eadfd3ad1 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/client/settings.cc
|
|
|
|
+++ third_party/crashpad/crashpad/client/settings.cc
|
2016-12-12 11:05:29 +01:00
|
|
|
@@ -38,7 +38,7 @@ void ScopedLockedFileHandleTraits::Free(FileHandle handle) {
|
|
|
|
|
|
|
|
struct Settings::Data {
|
|
|
|
static const uint32_t kSettingsMagic = 'CPds';
|
|
|
|
- static const uint32_t kSettingsVersion = 1;
|
|
|
|
+ static const uint32_t kSettingsVersion = 2;
|
|
|
|
|
|
|
|
enum Options : uint32_t {
|
|
|
|
kUploadsEnabled = 1 << 0,
|
|
|
|
@@ -49,6 +49,9 @@ struct Settings::Data {
|
|
|
|
options(0),
|
|
|
|
padding_0(0),
|
|
|
|
last_upload_attempt_time(0),
|
|
|
|
+ next_upload_attempt_time(0),
|
|
|
|
+ backoff_step(0),
|
|
|
|
+ padding_1(0),
|
|
|
|
client_id() {}
|
|
|
|
|
|
|
|
uint32_t magic;
|
|
|
|
@@ -56,6 +59,9 @@ struct Settings::Data {
|
|
|
|
uint32_t options;
|
|
|
|
uint32_t padding_0;
|
2017-01-23 18:36:54 +01:00
|
|
|
int64_t last_upload_attempt_time; // time_t
|
|
|
|
+ int64_t next_upload_attempt_time; // time_t
|
2016-12-12 11:05:29 +01:00
|
|
|
+ uint32_t backoff_step;
|
|
|
|
+ uint32_t padding_1;
|
|
|
|
UUID client_id;
|
|
|
|
};
|
|
|
|
|
|
|
|
@@ -141,6 +147,56 @@ bool Settings::SetLastUploadAttemptTime(time_t time) {
|
|
|
|
return WriteSettings(handle.get(), settings);
|
|
|
|
}
|
|
|
|
|
|
|
|
+bool Settings::GetNextUploadAttemptTime(time_t* time) {
|
|
|
|
+ DCHECK(initialized_.is_valid());
|
|
|
|
+
|
|
|
|
+ Data settings;
|
|
|
|
+ if (!OpenAndReadSettings(&settings))
|
|
|
|
+ return false;
|
|
|
|
+
|
|
|
|
+ *time = InRangeCast<time_t>(settings.next_upload_attempt_time,
|
|
|
|
+ std::numeric_limits<time_t>::max());
|
|
|
|
+ return true;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+bool Settings::SetNextUploadAttemptTime(time_t time) {
|
|
|
|
+ DCHECK(initialized_.is_valid());
|
|
|
|
+
|
|
|
|
+ Data settings;
|
|
|
|
+ ScopedLockedFileHandle handle = OpenForWritingAndReadSettings(&settings);
|
|
|
|
+ if (!handle.is_valid())
|
|
|
|
+ return false;
|
|
|
|
+
|
2017-01-23 18:36:54 +01:00
|
|
|
+ settings.next_upload_attempt_time = InRangeCast<int64_t>(time, 0);
|
2016-12-12 11:05:29 +01:00
|
|
|
+
|
|
|
|
+ return WriteSettings(handle.get(), settings);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+bool Settings::GetBackoffStep(int* step) {
|
|
|
|
+ DCHECK(initialized_.is_valid());
|
|
|
|
+
|
|
|
|
+ Data settings;
|
|
|
|
+ if (!OpenAndReadSettings(&settings))
|
|
|
|
+ return false;
|
|
|
|
+
|
|
|
|
+ *step = InRangeCast<int>(settings.backoff_step,
|
|
|
|
+ std::numeric_limits<int>::max());
|
|
|
|
+ return true;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+bool Settings::SetBackoffStep(int step) {
|
|
|
|
+ DCHECK(initialized_.is_valid());
|
|
|
|
+
|
|
|
|
+ Data settings;
|
|
|
|
+ ScopedLockedFileHandle handle = OpenForWritingAndReadSettings(&settings);
|
|
|
|
+ if (!handle.is_valid())
|
|
|
|
+ return false;
|
|
|
|
+
|
|
|
|
+ settings.backoff_step = InRangeCast<uint32_t>(step, 0);
|
|
|
|
+
|
|
|
|
+ return WriteSettings(handle.get(), settings);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
// static
|
|
|
|
Settings::ScopedLockedFileHandle Settings::MakeScopedLockedFileHandle(
|
|
|
|
FileHandle file,
|
2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/client/settings.h third_party/crashpad/crashpad/client/settings.h
|
2017-09-06 23:40:58 +02:00
|
|
|
index b64f74fbaf28..0c3c22e215b6 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/client/settings.h
|
|
|
|
+++ third_party/crashpad/crashpad/client/settings.h
|
2016-12-12 11:05:29 +01:00
|
|
|
@@ -102,6 +102,11 @@ class Settings {
|
|
|
|
//! error logged.
|
|
|
|
bool SetLastUploadAttemptTime(time_t time);
|
|
|
|
|
|
|
|
+ bool GetNextUploadAttemptTime(time_t* time);
|
|
|
|
+ bool SetNextUploadAttemptTime(time_t time);
|
|
|
|
+ bool GetBackoffStep(int* step);
|
|
|
|
+ bool SetBackoffStep(int step);
|
|
|
|
+
|
|
|
|
private:
|
|
|
|
struct Data;
|
|
|
|
|
2017-12-07 22:44:24 +01:00
|
|
|
diff --git third_party/crashpad/crashpad/handler/BUILD.gn third_party/crashpad/crashpad/handler/BUILD.gn
|
2018-02-15 01:12:09 +01:00
|
|
|
index 71037bb04d5d..61f7e8ca04ca 100644
|
2017-12-07 22:44:24 +01:00
|
|
|
--- third_party/crashpad/crashpad/handler/BUILD.gn
|
|
|
|
+++ third_party/crashpad/crashpad/handler/BUILD.gn
|
|
|
|
@@ -12,6 +12,7 @@
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
+import("//cef/libcef/features/features.gni")
|
2018-02-15 01:12:09 +01:00
|
|
|
import("../build/crashpad_buildconfig.gni")
|
2017-12-07 22:44:24 +01:00
|
|
|
|
|
|
|
static_library("handler") {
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -75,8 +76,20 @@ static_library("handler") {
|
|
|
|
"../third_party/mini_chromium:base",
|
2017-12-07 22:44:24 +01:00
|
|
|
"../tools:tool_support",
|
|
|
|
"../util",
|
|
|
|
+ "//cef/libcef/features",
|
|
|
|
]
|
|
|
|
|
|
|
|
+ if (enable_cef) {
|
|
|
|
+ sources += [
|
|
|
|
+ "//cef/libcef/common/cef_crash_report_upload_thread.cc",
|
|
|
|
+ "//cef/libcef/common/cef_crash_report_upload_thread.h",
|
2018-02-15 01:12:09 +01:00
|
|
|
+ "//cef/libcef/common/cef_crash_report_utils.cc",
|
|
|
|
+ "//cef/libcef/common/cef_crash_report_utils.h",
|
2017-12-07 22:44:24 +01:00
|
|
|
+ ]
|
|
|
|
+
|
|
|
|
+ configs += [ "//cef/libcef/features:config" ]
|
|
|
|
+ }
|
|
|
|
+
|
2018-02-15 01:12:09 +01:00
|
|
|
if (crashpad_is_win) {
|
2017-12-07 22:44:24 +01:00
|
|
|
cflags = [ "/wd4201" ] # nonstandard extension used : nameless struct/union
|
|
|
|
}
|
2018-02-15 01:12:09 +01:00
|
|
|
diff --git third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
|
|
|
|
index 7505524b693b..4f8ceaa43bd6 100644
|
|
|
|
--- third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
|
|
|
|
+++ third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
|
|
|
|
@@ -302,6 +302,8 @@ CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport(
|
|
|
|
if (minidump_process_snapshot.Initialize(&minidump_file_reader)) {
|
|
|
|
parameters =
|
|
|
|
BreakpadHTTPFormParametersFromMinidump(&minidump_process_snapshot);
|
|
|
|
+ if (!parameters.empty())
|
|
|
|
+ parameters = FilterParameters(parameters);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!minidump_file_reader.SeekSet(start_offset)) {
|
2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/handler/crash_report_upload_thread.h third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
|
2018-02-15 01:12:09 +01:00
|
|
|
index cdd1502b7e2f..cb8450a892ba 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
|
|
|
|
+++ third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -15,6 +15,7 @@
|
|
|
|
#ifndef CRASHPAD_HANDLER_CRASH_REPORT_UPLOAD_THREAD_H_
|
|
|
|
#define CRASHPAD_HANDLER_CRASH_REPORT_UPLOAD_THREAD_H_
|
|
|
|
|
|
|
|
+#include <map>
|
|
|
|
#include <memory>
|
|
|
|
#include <string>
|
|
|
|
|
|
|
|
@@ -99,7 +100,7 @@ class CrashReportUploadThread : public WorkerThread::Delegate {
|
2016-12-12 11:05:29 +01:00
|
|
|
//! This method may be called from any thread.
|
2017-05-31 17:33:30 +02:00
|
|
|
void ReportPending(const UUID& report_uuid);
|
2016-12-12 11:05:29 +01:00
|
|
|
|
|
|
|
- private:
|
|
|
|
+ protected:
|
|
|
|
//! \brief The result code from UploadReport().
|
|
|
|
enum class UploadResult {
|
|
|
|
//! \brief The crash report was uploaded successfully.
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -127,7 +128,7 @@ class CrashReportUploadThread : public WorkerThread::Delegate {
|
2017-05-31 17:33:30 +02:00
|
|
|
//! object was constructed with \a watch_pending_reports, it will also scan
|
|
|
|
//! the crash report database for other pending reports, and process those as
|
|
|
|
//! well.
|
2016-12-12 11:05:29 +01:00
|
|
|
- void ProcessPendingReports();
|
|
|
|
+ virtual void ProcessPendingReports();
|
|
|
|
|
|
|
|
//! \brief Processes a single pending report from the database.
|
|
|
|
//!
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -141,7 +142,7 @@ class CrashReportUploadThread : public WorkerThread::Delegate {
|
2016-12-12 11:05:29 +01:00
|
|
|
//! remain in the “pending” state. If the upload fails and no more retries are
|
|
|
|
//! desired, or report upload is disabled, it will be marked as “completed” in
|
|
|
|
//! the database without ever having been uploaded.
|
|
|
|
- void ProcessPendingReport(const CrashReportDatabase::Report& report);
|
|
|
|
+ virtual void ProcessPendingReport(const CrashReportDatabase::Report& report);
|
|
|
|
|
|
|
|
//! \brief Attempts to upload a crash report.
|
|
|
|
//!
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -158,6 +159,11 @@ class CrashReportUploadThread : public WorkerThread::Delegate {
|
|
|
|
UploadResult UploadReport(const CrashReportDatabase::Report* report,
|
|
|
|
std::string* response_body);
|
|
|
|
|
|
|
|
+ using ParameterMap = std::map<std::string, std::string>;
|
|
|
|
+ virtual ParameterMap FilterParameters(const ParameterMap& parameters) {
|
|
|
|
+ return parameters;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
// WorkerThread::Delegate:
|
|
|
|
//! \brief Calls ProcessPendingReports() in response to ReportPending() having
|
|
|
|
//! been called on any thread, as well as periodically on a timer.
|
2017-04-27 03:59:52 +02:00
|
|
|
diff --git third_party/crashpad/crashpad/handler/handler_main.cc third_party/crashpad/crashpad/handler/handler_main.cc
|
2018-02-15 01:12:09 +01:00
|
|
|
index f175fddf6084..d6285bbf28bf 100644
|
2017-04-27 03:59:52 +02:00
|
|
|
--- third_party/crashpad/crashpad/handler/handler_main.cc
|
|
|
|
+++ third_party/crashpad/crashpad/handler/handler_main.cc
|
2017-04-20 21:28:17 +02:00
|
|
|
@@ -35,8 +35,10 @@
|
2016-12-12 11:05:29 +01:00
|
|
|
#include "base/metrics/persistent_histogram_allocator.h"
|
|
|
|
#include "base/scoped_generic.h"
|
2017-04-20 21:28:17 +02:00
|
|
|
#include "base/strings/stringprintf.h"
|
2016-12-12 11:05:29 +01:00
|
|
|
+#include "base/strings/string_number_conversions.h"
|
|
|
|
#include "base/strings/utf_string_conversions.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#include "client/crash_report_database.h"
|
|
|
|
#include "client/crashpad_client.h"
|
2017-04-20 21:28:17 +02:00
|
|
|
#include "client/crashpad_info.h"
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -79,6 +81,10 @@
|
|
|
|
#include "handler/fuchsia/exception_handler_server.h"
|
2016-12-12 11:05:29 +01:00
|
|
|
#endif // OS_MACOSX
|
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+#include "cef/libcef/common/cef_crash_report_upload_thread.h"
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
namespace crashpad {
|
|
|
|
|
|
|
|
namespace {
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -154,6 +160,9 @@ struct Options {
|
2017-05-31 17:33:30 +02:00
|
|
|
bool periodic_tasks;
|
2017-04-20 21:28:17 +02:00
|
|
|
bool rate_limit;
|
|
|
|
bool upload_gzip;
|
|
|
|
+ int max_uploads;
|
|
|
|
+ int max_database_size;
|
|
|
|
+ int max_database_age;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Splits |key_value| on '=' and inserts the resulting key and value into |map|.
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -451,6 +460,9 @@ int HandlerMain(int argc,
|
2017-04-20 21:28:17 +02:00
|
|
|
kOptionResetOwnCrashExceptionPortToSystemDefault,
|
2016-12-12 11:05:29 +01:00
|
|
|
#endif // OS_MACOSX
|
|
|
|
kOptionURL,
|
|
|
|
+ kOptionMaxUploads,
|
|
|
|
+ kOptionMaxDatabaseSize,
|
|
|
|
+ kOptionMaxDatabaseAge,
|
|
|
|
|
|
|
|
// Standard options.
|
|
|
|
kOptionHelp = -2,
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -501,6 +513,9 @@ int HandlerMain(int argc,
|
2016-12-12 11:05:29 +01:00
|
|
|
{"url", required_argument, nullptr, kOptionURL},
|
|
|
|
{"help", no_argument, nullptr, kOptionHelp},
|
|
|
|
{"version", no_argument, nullptr, kOptionVersion},
|
|
|
|
+ {"max-uploads", required_argument, nullptr, kOptionMaxUploads},
|
|
|
|
+ {"max-db-size", required_argument, nullptr, kOptionMaxDatabaseSize},
|
|
|
|
+ {"max-db-age", required_argument, nullptr, kOptionMaxDatabaseAge},
|
|
|
|
{nullptr, 0, nullptr, 0},
|
|
|
|
};
|
|
|
|
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -605,6 +620,27 @@ int HandlerMain(int argc,
|
2016-12-12 11:05:29 +01:00
|
|
|
options.url = optarg;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
+ case kOptionMaxUploads: {
|
|
|
|
+ if (base::StringToInt(optarg, &options.max_uploads)) {
|
|
|
|
+ if (options.max_uploads < 0)
|
|
|
|
+ options.max_uploads = 0;
|
|
|
|
+ }
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
+ case kOptionMaxDatabaseSize: {
|
|
|
|
+ if (base::StringToInt(optarg, &options.max_database_size)) {
|
|
|
|
+ if (options.max_database_size < 0)
|
|
|
|
+ options.max_database_size = 0;
|
|
|
|
+ }
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
+ case kOptionMaxDatabaseAge: {
|
|
|
|
+ if (base::StringToInt(optarg, &options.max_database_age)) {
|
|
|
|
+ if (options.max_database_age < 0)
|
|
|
|
+ options.max_database_age = 0;
|
|
|
|
+ }
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
case kOptionHelp: {
|
|
|
|
Usage(me);
|
2017-03-03 23:37:23 +01:00
|
|
|
MetricsRecordExit(Metrics::LifetimeMilestone::kExitedEarly);
|
2018-02-15 01:12:09 +01:00
|
|
|
@@ -772,15 +808,23 @@ int HandlerMain(int argc,
|
2017-12-07 22:44:24 +01:00
|
|
|
upload_thread_options.rate_limit = options.rate_limit;
|
|
|
|
upload_thread_options.upload_gzip = options.upload_gzip;
|
|
|
|
upload_thread_options.watch_pending_reports = options.periodic_tasks;
|
2016-12-12 11:05:29 +01:00
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
2017-05-31 17:33:30 +02:00
|
|
|
+ CefCrashReportUploadThread upload_thread(database.get(),
|
|
|
|
+ options.url,
|
2017-12-07 22:44:24 +01:00
|
|
|
+ upload_thread_options,
|
2017-05-31 17:33:30 +02:00
|
|
|
+ options.max_uploads);
|
2016-12-12 11:05:29 +01:00
|
|
|
+#else
|
2017-05-31 17:33:30 +02:00
|
|
|
CrashReportUploadThread upload_thread(database.get(),
|
|
|
|
options.url,
|
2017-12-07 22:44:24 +01:00
|
|
|
upload_thread_options);
|
2016-12-12 11:05:29 +01:00
|
|
|
+#endif
|
|
|
|
upload_thread.Start();
|
|
|
|
|
2017-05-31 17:33:30 +02:00
|
|
|
std::unique_ptr<PruneCrashReportThread> prune_thread;
|
|
|
|
if (options.periodic_tasks) {
|
|
|
|
prune_thread.reset(new PruneCrashReportThread(
|
|
|
|
- database.get(), PruneCondition::GetDefault()));
|
|
|
|
+ database.get(), PruneCondition::GetDefault(options.max_database_size,
|
|
|
|
+ options.max_database_age)));
|
|
|
|
prune_thread->Start();
|
|
|
|
}
|
2016-12-12 11:05:29 +01:00
|
|
|
|