2021-04-11 22:10:11 +02:00
|
|
|
diff --git chrome/browser/ui/browser_command_controller.cc chrome/browser/ui/browser_command_controller.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index 100baefb933be..4e1501387aa6c 100644
|
2021-04-11 22:10:11 +02:00
|
|
|
--- chrome/browser/ui/browser_command_controller.cc
|
|
|
|
+++ chrome/browser/ui/browser_command_controller.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -390,6 +390,7 @@ bool BrowserCommandController::ExecuteCommandWithDisposition(
|
2021-04-11 22:10:11 +02:00
|
|
|
// choose to not implement CommandUpdaterDelegate inside this class and
|
|
|
|
// therefore command_updater_ doesn't have the delegate set).
|
2023-01-30 18:43:54 +01:00
|
|
|
if (!SupportsCommand(id) || !IsCommandEnabled(id)) {
|
2021-04-11 22:10:11 +02:00
|
|
|
+ LOG(WARNING) << "Invalid/disabled command " << id;
|
|
|
|
return false;
|
2023-01-30 18:43:54 +01:00
|
|
|
}
|
2021-04-11 22:10:11 +02:00
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -406,6 +407,13 @@ bool BrowserCommandController::ExecuteCommandWithDisposition(
|
2022-03-22 19:31:30 +01:00
|
|
|
DCHECK(command_updater_.IsCommandEnabled(id))
|
|
|
|
<< "Invalid/disabled command " << id;
|
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ if (browser_->cef_delegate() &&
|
|
|
|
+ browser_->cef_delegate()->HandleCommand(id, disposition)) {
|
|
|
|
+ return true;
|
|
|
|
+ }
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
// The order of commands in this switch statement must match the function
|
|
|
|
// declaration order in browser.h!
|
|
|
|
switch (id) {
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -1040,11 +1048,13 @@ void BrowserCommandController::TabRestoreServiceLoaded(
|
2021-04-11 22:10:11 +02:00
|
|
|
// BrowserCommandController, private:
|
|
|
|
|
|
|
|
bool BrowserCommandController::IsShowingMainUI() {
|
|
|
|
- return browser_->SupportsWindowFeature(Browser::FEATURE_TABSTRIP);
|
|
|
|
+ return browser_->SupportsWindowFeature(Browser::FEATURE_TABSTRIP) ||
|
|
|
|
+ browser_->toolbar_overridden();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserCommandController::IsShowingLocationBar() {
|
|
|
|
- return browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR);
|
|
|
|
+ return browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR) ||
|
|
|
|
+ browser_->toolbar_overridden();
|
|
|
|
}
|
|
|
|
|
2022-02-21 23:23:40 +01:00
|
|
|
bool BrowserCommandController::IsWebAppOrCustomTab() const {
|
2021-02-18 02:58:25 +01:00
|
|
|
diff --git chrome/browser/ui/views/frame/browser_frame.cc chrome/browser/ui/views/frame/browser_frame.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index 1b8cd7a3ff295..b837a9379bd04 100644
|
2021-02-18 02:58:25 +01:00
|
|
|
--- chrome/browser/ui/views/frame/browser_frame.cc
|
|
|
|
+++ chrome/browser/ui/views/frame/browser_frame.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -67,15 +67,23 @@ bool IsUsingLinuxSystemTheme(Profile* profile) {
|
2021-02-18 02:58:25 +01:00
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
// BrowserFrame, public:
|
|
|
|
|
|
|
|
+BrowserFrame::BrowserFrame() : BrowserFrame(nullptr) {}
|
|
|
|
+
|
|
|
|
BrowserFrame::BrowserFrame(BrowserView* browser_view)
|
|
|
|
: native_browser_frame_(nullptr),
|
|
|
|
root_view_(nullptr),
|
|
|
|
browser_frame_view_(nullptr),
|
|
|
|
- browser_view_(browser_view) {
|
|
|
|
- browser_view_->set_frame(this);
|
|
|
|
+ browser_view_(nullptr) {
|
|
|
|
set_is_secondary_widget(false);
|
|
|
|
// Don't focus anything on creation, selecting a tab will set the focus.
|
|
|
|
set_focus_on_creation(false);
|
|
|
|
+ if (browser_view)
|
|
|
|
+ InitBrowserView(browser_view);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+void BrowserFrame::InitBrowserView(BrowserView* browser_view) {
|
|
|
|
+ browser_view_ = browser_view;
|
|
|
|
+ browser_view_->set_frame(this);
|
|
|
|
}
|
|
|
|
|
|
|
|
BrowserFrame::~BrowserFrame() {}
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -147,6 +155,12 @@ gfx::Rect BrowserFrame::GetBoundsForTabStripRegion(
|
2021-02-18 02:58:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
int BrowserFrame::GetTopInset() const {
|
|
|
|
+ if (!browser_frame_view_) {
|
|
|
|
+ // With CEF the browser may already be part of a larger Views layout. Zero
|
|
|
|
+ // out the adjustment in BrowserView::GetTopInsetInBrowserView() so that
|
|
|
|
+ // the browser isn't shifted to the top of the window.
|
|
|
|
+ return browser_view_->y();
|
|
|
|
+ }
|
|
|
|
return browser_frame_view_->GetTopInset(false);
|
|
|
|
}
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -163,6 +177,8 @@ BrowserNonClientFrameView* BrowserFrame::GetFrameView() const {
|
2022-08-09 21:42:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserFrame::UseCustomFrame() const {
|
|
|
|
+ if (!native_browser_frame_)
|
|
|
|
+ return true;
|
|
|
|
return native_browser_frame_->UseCustomFrame();
|
|
|
|
}
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -176,20 +192,30 @@ bool BrowserFrame::ShouldDrawFrameHeader() const {
|
2022-03-23 01:42:03 +01:00
|
|
|
|
|
|
|
void BrowserFrame::GetWindowPlacement(gfx::Rect* bounds,
|
|
|
|
ui::WindowShowState* show_state) const {
|
|
|
|
+ if (!native_browser_frame_) {
|
|
|
|
+ *show_state = ui::SHOW_STATE_DEFAULT;
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
return native_browser_frame_->GetWindowPlacement(bounds, show_state);
|
|
|
|
}
|
2021-02-18 02:58:25 +01:00
|
|
|
|
|
|
|
content::KeyboardEventProcessingResult BrowserFrame::PreHandleKeyboardEvent(
|
|
|
|
const content::NativeWebKeyboardEvent& event) {
|
|
|
|
+ if (!native_browser_frame_)
|
|
|
|
+ return content::KeyboardEventProcessingResult::NOT_HANDLED;
|
|
|
|
return native_browser_frame_->PreHandleKeyboardEvent(event);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserFrame::HandleKeyboardEvent(
|
|
|
|
const content::NativeWebKeyboardEvent& event) {
|
|
|
|
+ if (!native_browser_frame_)
|
|
|
|
+ return false;
|
|
|
|
return native_browser_frame_->HandleKeyboardEvent(event);
|
|
|
|
}
|
|
|
|
|
|
|
|
void BrowserFrame::OnBrowserViewInitViewsComplete() {
|
|
|
|
+ if (!browser_frame_view_)
|
|
|
|
+ return;
|
|
|
|
browser_frame_view_->OnBrowserViewInitViewsComplete();
|
|
|
|
}
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -251,7 +277,7 @@ const ui::ThemeProvider* BrowserFrame::GetThemeProvider() const {
|
2022-03-26 02:12:30 +01:00
|
|
|
ui::ColorProviderManager::ThemeInitializerSupplier*
|
|
|
|
BrowserFrame::GetCustomTheme() const {
|
2022-11-15 18:50:53 +01:00
|
|
|
// Do not return any custom theme if the browser has to use the dark theme.
|
|
|
|
- if (ShouldUseDarkTheme())
|
|
|
|
+ if (ShouldUseDarkTheme() || !browser_view_)
|
|
|
|
return nullptr;
|
|
|
|
|
2021-10-19 00:17:16 +02:00
|
|
|
Browser* browser = browser_view_->browser();
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -268,6 +294,8 @@ BrowserFrame::GetCustomTheme() const {
|
2022-04-08 22:48:56 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void BrowserFrame::OnNativeWidgetWorkspaceChanged() {
|
|
|
|
+ if (!browser_view_)
|
|
|
|
+ return;
|
|
|
|
chrome::SaveWindowWorkspace(browser_view_->browser(), GetWorkspace());
|
|
|
|
chrome::SaveWindowVisibleOnAllWorkspaces(browser_view_->browser(),
|
|
|
|
IsVisibleOnAllWorkspaces());
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -355,6 +383,8 @@ void BrowserFrame::SetTabDragKind(TabDragKind tab_drag_kind) {
|
2022-03-26 02:12:30 +01:00
|
|
|
|
|
|
|
ui::ColorProviderManager::Key BrowserFrame::GetColorProviderKey() const {
|
|
|
|
auto key = Widget::GetColorProviderKey();
|
|
|
|
+ if (!browser_view_)
|
|
|
|
+ return key;
|
2022-07-21 19:26:10 +02:00
|
|
|
key.frame_type = UseCustomFrame()
|
|
|
|
? ui::ColorProviderManager::FrameType::kChromium
|
|
|
|
: ui::ColorProviderManager::FrameType::kNative;
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -441,5 +471,7 @@ bool BrowserFrame::RegenerateFrameOnThemeChange(
|
2022-11-15 18:50:53 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserFrame::ShouldUseDarkTheme() const {
|
|
|
|
+ if (!browser_view_)
|
|
|
|
+ return false;
|
2023-01-30 18:43:54 +01:00
|
|
|
return browser_view_->browser()->profile()->IsIncognitoProfile();
|
2022-11-15 18:50:53 +01:00
|
|
|
}
|
2021-02-18 02:58:25 +01:00
|
|
|
diff --git chrome/browser/ui/views/frame/browser_frame.h chrome/browser/ui/views/frame/browser_frame.h
|
2022-11-15 18:50:53 +01:00
|
|
|
index 28085aa32d7d8..312911b8a4564 100644
|
2021-02-18 02:58:25 +01:00
|
|
|
--- chrome/browser/ui/views/frame/browser_frame.h
|
|
|
|
+++ chrome/browser/ui/views/frame/browser_frame.h
|
2022-09-26 21:30:45 +02:00
|
|
|
@@ -56,7 +56,9 @@ enum class TabDragKind {
|
2021-02-18 02:58:25 +01:00
|
|
|
// This is a virtual interface that allows system specific browser frames.
|
|
|
|
class BrowserFrame : public views::Widget, public views::ContextMenuController {
|
|
|
|
public:
|
|
|
|
+ BrowserFrame();
|
|
|
|
explicit BrowserFrame(BrowserView* browser_view);
|
|
|
|
+ void InitBrowserView(BrowserView* browser_view);
|
|
|
|
|
2021-10-19 00:17:16 +02:00
|
|
|
BrowserFrame(const BrowserFrame&) = delete;
|
|
|
|
BrowserFrame& operator=(const BrowserFrame&) = delete;
|
2021-02-18 02:58:25 +01:00
|
|
|
diff --git chrome/browser/ui/views/frame/browser_view.cc chrome/browser/ui/views/frame/browser_view.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index bc22da820add3..04798b83011e2 100644
|
2021-02-18 02:58:25 +01:00
|
|
|
--- chrome/browser/ui/views/frame/browser_view.cc
|
|
|
|
+++ chrome/browser/ui/views/frame/browser_view.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -307,11 +307,10 @@ using content::NativeWebKeyboardEvent;
|
2022-06-17 15:28:55 +02:00
|
|
|
using content::WebContents;
|
2021-08-28 03:55:15 +02:00
|
|
|
using web_modal::WebContentsModalDialogHost;
|
|
|
|
|
|
|
|
-namespace {
|
|
|
|
+// static
|
|
|
|
+const char BrowserView::kBrowserViewKey[] = "__BROWSER_VIEW__";
|
|
|
|
|
|
|
|
-// The name of a key to store on the window handle so that other code can
|
|
|
|
-// locate this object using just the handle.
|
|
|
|
-const char* const kBrowserViewKey = "__BROWSER_VIEW__";
|
|
|
|
+namespace {
|
|
|
|
|
|
|
|
#if BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
// UMA histograms that record animation smoothness for tab loading animation.
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -826,11 +825,22 @@ class BrowserView::SidePanelVisibilityController : public views::ViewObserver {
|
2021-03-04 23:36:57 +01:00
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
// BrowserView, public:
|
2021-02-18 02:58:25 +01:00
|
|
|
|
|
|
|
+BrowserView::BrowserView() : BrowserView(nullptr) {}
|
|
|
|
+
|
|
|
|
BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
|
|
|
: views::ClientView(nullptr, nullptr),
|
|
|
|
- browser_(std::move(browser)),
|
|
|
|
accessibility_mode_observer_(
|
|
|
|
std::make_unique<AccessibilityModeObserver>(this)) {
|
|
|
|
+ if (browser)
|
|
|
|
+ InitBrowser(std::move(browser));
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+void BrowserView::InitBrowser(std::unique_ptr<Browser> browser) {
|
|
|
|
+ DCHECK(!browser_);
|
|
|
|
+ browser_ = std::move(browser);
|
|
|
|
+
|
2022-09-26 21:30:45 +02:00
|
|
|
+ immersive_mode_controller_ = chrome::CreateImmersiveModeController(this);
|
2021-02-18 02:58:25 +01:00
|
|
|
+
|
2022-03-26 02:12:30 +01:00
|
|
|
SetShowIcon(
|
|
|
|
::ShouldShowWindowIcon(browser_.get(), AppUsesWindowControlsOverlay()));
|
2021-03-04 23:36:57 +01:00
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -874,7 +884,6 @@ BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
2021-03-04 23:36:57 +01:00
|
|
|
}
|
2021-02-18 02:58:25 +01:00
|
|
|
|
|
|
|
browser_->tab_strip_model()->AddObserver(this);
|
2022-09-26 21:30:45 +02:00
|
|
|
- immersive_mode_controller_ = chrome::CreateImmersiveModeController(this);
|
2021-02-18 02:58:25 +01:00
|
|
|
|
|
|
|
// Top container holds tab strip region and toolbar and lives at the front of
|
|
|
|
// the view hierarchy.
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -920,8 +929,15 @@ BrowserView::BrowserView(std::unique_ptr<Browser> browser)
|
2021-04-11 22:10:11 +02:00
|
|
|
contents_container->SetLayoutManager(std::make_unique<ContentsLayoutManager>(
|
|
|
|
devtools_web_view_, contents_web_view_));
|
|
|
|
|
|
|
|
- toolbar_ = top_container_->AddChildView(
|
|
|
|
- std::make_unique<ToolbarView>(browser_.get(), this));
|
|
|
|
+ toolbar_ = OverrideCreateToolbar(browser_.get(), this);
|
|
|
|
+ if (!toolbar_) {
|
2021-07-23 18:40:13 +02:00
|
|
|
+ toolbar_ = new ToolbarView(browser_.get(), this, absl::nullopt);
|
2021-04-11 22:10:11 +02:00
|
|
|
+ } else {
|
|
|
|
+ browser_->set_toolbar_overridden(true);
|
|
|
|
+ // Update state that depends on the above flag.
|
|
|
|
+ browser_->command_controller()->FullscreenStateChanged();
|
|
|
|
+ }
|
2021-12-16 23:35:54 +01:00
|
|
|
+ top_container_->AddChildView(base::WrapUnique(toolbar_.get()));
|
2021-04-11 22:10:11 +02:00
|
|
|
|
|
|
|
contents_separator_ =
|
|
|
|
top_container_->AddChildView(std::make_unique<ContentsSeparator>());
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -1839,6 +1855,8 @@ bool BrowserView::ShouldHideUIForFullscreen() const {
|
2021-02-18 02:58:25 +01:00
|
|
|
if (immersive_mode_controller_->IsEnabled())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
+ if (!frame_->GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return frame_->GetFrameView()->ShouldHideTopUIForFullscreen();
|
|
|
|
}
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -2734,7 +2752,8 @@ DownloadShelf* BrowserView::GetDownloadShelf() {
|
2022-10-17 19:27:40 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
DownloadBubbleUIController* BrowserView::GetDownloadBubbleUIController() {
|
|
|
|
- DCHECK(toolbar_button_provider_);
|
|
|
|
+ if (!toolbar_button_provider_)
|
|
|
|
+ return nullptr;
|
|
|
|
if (auto* download_button = toolbar_button_provider_->GetDownloadButton())
|
|
|
|
return download_button->bubble_controller();
|
|
|
|
return nullptr;
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -3226,7 +3245,8 @@ void BrowserView::ReparentTopContainerForEndOfImmersive() {
|
2022-08-23 03:37:40 +02:00
|
|
|
if (top_container()->parent() == this)
|
|
|
|
return;
|
2021-02-18 02:58:25 +01:00
|
|
|
|
|
|
|
- overlay_view_->SetVisible(false);
|
|
|
|
+ if (overlay_view_)
|
|
|
|
+ overlay_view_->SetVisible(false);
|
|
|
|
top_container()->DestroyLayer();
|
|
|
|
AddChildViewAt(top_container(), 0);
|
|
|
|
EnsureFocusOrder();
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -3765,8 +3785,10 @@ void BrowserView::Layout() {
|
2021-04-11 22:10:11 +02:00
|
|
|
|
2021-02-18 02:58:25 +01:00
|
|
|
// TODO(jamescook): Why was this in the middle of layout code?
|
|
|
|
toolbar_->location_bar()->omnibox_view()->SetFocusBehavior(
|
2021-04-11 22:10:11 +02:00
|
|
|
- IsToolbarVisible() ? FocusBehavior::ALWAYS : FocusBehavior::NEVER);
|
2021-02-18 02:58:25 +01:00
|
|
|
- frame()->GetFrameView()->UpdateMinimumSize();
|
2021-04-11 22:10:11 +02:00
|
|
|
+ (IsToolbarVisible() || browser_->toolbar_overridden()) ?
|
|
|
|
+ FocusBehavior::ALWAYS : FocusBehavior::NEVER);
|
2021-02-18 02:58:25 +01:00
|
|
|
+ if (frame()->GetFrameView())
|
|
|
|
+ frame()->GetFrameView()->UpdateMinimumSize();
|
|
|
|
|
|
|
|
// Some of the situations when the BrowserView is laid out are:
|
|
|
|
// - Enter/exit immersive fullscreen mode.
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -3832,6 +3854,11 @@ void BrowserView::AddedToWidget() {
|
2021-04-11 22:10:11 +02:00
|
|
|
SetThemeProfileForWindow(GetNativeWindow(), browser_->profile());
|
|
|
|
#endif
|
|
|
|
|
|
|
|
+ // This browser view may already have a custom button provider set (e.g the
|
|
|
|
+ // hosted app frame).
|
|
|
|
+ if (!toolbar_button_provider_)
|
|
|
|
+ SetToolbarButtonProvider(toolbar_);
|
|
|
|
+
|
|
|
|
toolbar_->Init();
|
2021-02-18 02:58:25 +01:00
|
|
|
|
2021-11-10 22:57:31 +01:00
|
|
|
// TODO(pbos): Manage this either inside SidePanel or the corresponding button
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -3887,13 +3914,9 @@ void BrowserView::AddedToWidget() {
|
2021-04-11 22:10:11 +02:00
|
|
|
|
|
|
|
EnsureFocusOrder();
|
|
|
|
|
|
|
|
- // This browser view may already have a custom button provider set (e.g the
|
|
|
|
- // hosted app frame).
|
|
|
|
- if (!toolbar_button_provider_)
|
|
|
|
- SetToolbarButtonProvider(toolbar_);
|
|
|
|
-
|
2021-02-18 02:58:25 +01:00
|
|
|
frame_->OnBrowserViewInitViewsComplete();
|
|
|
|
- frame_->GetFrameView()->UpdateMinimumSize();
|
|
|
|
+ if (frame_->GetFrameView())
|
|
|
|
+ frame_->GetFrameView()->UpdateMinimumSize();
|
|
|
|
using_native_frame_ = frame_->ShouldUseNativeFrame();
|
|
|
|
|
|
|
|
MaybeInitializeWebUITabStrip();
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -4302,7 +4325,8 @@ void BrowserView::ProcessFullscreen(bool fullscreen,
|
2022-01-13 00:11:27 +01:00
|
|
|
// Undo our anti-jankiness hacks and force a re-layout.
|
|
|
|
in_process_fullscreen_ = false;
|
|
|
|
ToolbarSizeChanged(false);
|
|
|
|
- frame_->GetFrameView()->OnFullscreenStateChanged();
|
|
|
|
+ if (frame_->GetFrameView())
|
|
|
|
+ frame_->GetFrameView()->OnFullscreenStateChanged();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserView::ShouldUseImmersiveFullscreenForUrl(const GURL& url) const {
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -4650,6 +4674,8 @@ Profile* BrowserView::GetProfile() {
|
2022-01-13 00:11:27 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void BrowserView::UpdateUIForTabFullscreen() {
|
|
|
|
+ if (!frame_->GetFrameView())
|
|
|
|
+ return;
|
|
|
|
frame()->GetFrameView()->UpdateFullscreenTopUI();
|
|
|
|
}
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -4672,6 +4698,8 @@ void BrowserView::HideDownloadShelf() {
|
2022-01-13 00:11:27 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserView::CanUserExitFullscreen() const {
|
|
|
|
+ if (!frame_->GetFrameView())
|
|
|
|
+ return true;
|
|
|
|
return frame_->GetFrameView()->CanUserExitFullscreen();
|
|
|
|
}
|
|
|
|
|
2021-02-18 02:58:25 +01:00
|
|
|
diff --git chrome/browser/ui/views/frame/browser_view.h chrome/browser/ui/views/frame/browser_view.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index 673e626f60cd4..1444e9db81cfc 100644
|
2021-02-18 02:58:25 +01:00
|
|
|
--- chrome/browser/ui/views/frame/browser_view.h
|
|
|
|
+++ chrome/browser/ui/views/frame/browser_view.h
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -124,11 +124,16 @@ class BrowserView : public BrowserWindow,
|
2021-03-04 23:36:57 +01:00
|
|
|
public webapps::AppBannerManager::Observer {
|
|
|
|
public:
|
|
|
|
METADATA_HEADER(BrowserView);
|
2021-02-18 02:58:25 +01:00
|
|
|
+ BrowserView();
|
|
|
|
explicit BrowserView(std::unique_ptr<Browser> browser);
|
|
|
|
+ void InitBrowser(std::unique_ptr<Browser> browser);
|
2021-03-04 23:36:57 +01:00
|
|
|
BrowserView(const BrowserView&) = delete;
|
|
|
|
BrowserView& operator=(const BrowserView&) = delete;
|
2021-02-18 02:58:25 +01:00
|
|
|
~BrowserView() override;
|
2021-08-28 03:55:15 +02:00
|
|
|
|
|
|
|
+ // Key used to bind BrowserView to the Widget with which it is associated.
|
|
|
|
+ static const char kBrowserViewKey[];
|
|
|
|
+
|
2023-01-30 18:43:54 +01:00
|
|
|
void set_frame(BrowserFrame* frame) {
|
|
|
|
frame_ = frame;
|
|
|
|
paint_as_active_subscription_ =
|
|
|
|
@@ -777,6 +782,12 @@ class BrowserView : public BrowserWindow,
|
2022-10-17 19:27:40 +02:00
|
|
|
void SetLoadingAnimationStateChangeClosureForTesting(
|
|
|
|
base::OnceClosure closure);
|
2021-04-11 22:10:11 +02:00
|
|
|
|
|
|
|
+ protected:
|
|
|
|
+ virtual ToolbarView* OverrideCreateToolbar(Browser* browser,
|
|
|
|
+ BrowserView* browser_view) {
|
|
|
|
+ return nullptr;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
private:
|
|
|
|
// Do not friend BrowserViewLayout. Use the BrowserViewLayoutDelegate
|
|
|
|
// interface to keep these two classes decoupled and testable.
|
|
|
|
diff --git chrome/browser/ui/views/frame/browser_view_layout.cc chrome/browser/ui/views/frame/browser_view_layout.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index 991e095456a35..2373048a30123 100644
|
2021-04-11 22:10:11 +02:00
|
|
|
--- chrome/browser/ui/views/frame/browser_view_layout.cc
|
|
|
|
+++ chrome/browser/ui/views/frame/browser_view_layout.cc
|
2023-01-03 00:34:43 +01:00
|
|
|
@@ -46,6 +46,10 @@
|
2021-08-28 03:55:15 +02:00
|
|
|
#include "ui/views/widget/widget.h"
|
|
|
|
#include "ui/views/window/client_view.h"
|
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+#include "cef/libcef/browser/chrome/views/chrome_views_util.h"
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
using views::View;
|
|
|
|
using web_modal::ModalDialogHostObserver;
|
2023-01-03 00:34:43 +01:00
|
|
|
using web_modal::WebContentsModalDialogHost;
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -466,6 +470,13 @@ int BrowserViewLayout::LayoutWebUITabStrip(int top) {
|
2021-04-11 22:10:11 +02:00
|
|
|
|
|
|
|
int BrowserViewLayout::LayoutToolbar(int top) {
|
|
|
|
TRACE_EVENT0("ui", "BrowserViewLayout::LayoutToolbar");
|
2023-01-23 18:58:40 +01:00
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
2021-08-28 03:55:15 +02:00
|
|
|
+ if (cef::IsCefView(toolbar_)) {
|
2021-04-11 22:10:11 +02:00
|
|
|
+ // CEF may take ownership of the toolbar. Early exit to avoid the DCHECK
|
|
|
|
+ // in LayoutManager::SetViewVisibility().
|
|
|
|
+ return top;
|
|
|
|
+ }
|
2023-01-23 18:58:40 +01:00
|
|
|
+#endif
|
2021-04-11 22:10:11 +02:00
|
|
|
int browser_view_width = vertical_layout_rect_.width();
|
|
|
|
bool toolbar_visible = delegate_->IsToolbarVisible();
|
|
|
|
int height = toolbar_visible ? toolbar_->GetPreferredSize().height() : 0;
|
2022-04-14 21:12:23 +02:00
|
|
|
diff --git chrome/browser/ui/views/frame/contents_web_view.cc chrome/browser/ui/views/frame/contents_web_view.cc
|
2022-09-26 21:30:45 +02:00
|
|
|
index 5e059b9878fc2..c1f6fbcd40ec4 100644
|
2022-04-14 21:12:23 +02:00
|
|
|
--- chrome/browser/ui/views/frame/contents_web_view.cc
|
|
|
|
+++ chrome/browser/ui/views/frame/contents_web_view.cc
|
2022-04-21 20:58:48 +02:00
|
|
|
@@ -26,6 +26,11 @@
|
2022-04-14 21:12:23 +02:00
|
|
|
ContentsWebView::ContentsWebView(content::BrowserContext* browser_context)
|
|
|
|
: views::WebView(browser_context),
|
|
|
|
status_bubble_(nullptr) {
|
|
|
|
+ // Mouse events on draggable regions will not be handled by the WebView.
|
|
|
|
+ // Avoid the resulting DCHECK in NativeViewHost::OnMousePressed by
|
|
|
|
+ // configuring the NativeViewHost not to process events via the view
|
|
|
|
+ // hierarchy.
|
|
|
|
+ holder()->SetCanProcessEventsWithinSubtree(false);
|
|
|
|
}
|
|
|
|
|
|
|
|
ContentsWebView::~ContentsWebView() {
|
2021-02-18 02:58:25 +01:00
|
|
|
diff --git chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index 4f04525fafb8e..eea2013607200 100644
|
2021-02-18 02:58:25 +01:00
|
|
|
--- chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
|
|
|
+++ chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
2023-01-03 00:34:43 +01:00
|
|
|
@@ -564,33 +564,47 @@ gfx::Range BrowserTabStripController::ListTabsInGroup(
|
2021-02-18 02:58:25 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserTabStripController::IsFrameCondensed() const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return GetFrameView()->IsFrameCondensed();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserTabStripController::HasVisibleBackgroundTabShapes() const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return GetFrameView()->HasVisibleBackgroundTabShapes(
|
|
|
|
BrowserFrameActiveState::kUseCurrent);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserTabStripController::EverHasVisibleBackgroundTabShapes() const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return GetFrameView()->EverHasVisibleBackgroundTabShapes();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserTabStripController::ShouldPaintAsActiveFrame() const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return GetFrameView()->ShouldPaintAsActive();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool BrowserTabStripController::CanDrawStrokes() const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return false;
|
|
|
|
return GetFrameView()->CanDrawStrokes();
|
|
|
|
}
|
|
|
|
|
|
|
|
SkColor BrowserTabStripController::GetFrameColor(
|
|
|
|
BrowserFrameActiveState active_state) const {
|
|
|
|
+ if (!GetFrameView())
|
|
|
|
+ return SK_ColorWHITE;
|
|
|
|
return GetFrameView()->GetFrameColor(active_state);
|
|
|
|
}
|
|
|
|
|
2021-06-04 03:34:56 +02:00
|
|
|
absl::optional<int> BrowserTabStripController::GetCustomBackgroundId(
|
2021-02-18 02:58:25 +01:00
|
|
|
BrowserFrameActiveState active_state) const {
|
|
|
|
+ if (!GetFrameView())
|
2021-06-04 03:34:56 +02:00
|
|
|
+ return absl::nullopt;
|
2021-02-18 02:58:25 +01:00
|
|
|
return GetFrameView()->GetCustomBackgroundId(active_state);
|
|
|
|
}
|
|
|
|
|
2021-04-11 22:10:11 +02:00
|
|
|
diff --git chrome/browser/ui/views/toolbar/toolbar_view.cc chrome/browser/ui/views/toolbar/toolbar_view.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
index 46ce747cfdec8..99a718aaffe01 100644
|
2021-04-11 22:10:11 +02:00
|
|
|
--- chrome/browser/ui/views/toolbar/toolbar_view.cc
|
|
|
|
+++ chrome/browser/ui/views/toolbar/toolbar_view.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -164,12 +164,13 @@ auto& GetViewCommandMap() {
|
2021-04-11 22:10:11 +02:00
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
// ToolbarView, public:
|
|
|
|
|
|
|
|
-ToolbarView::ToolbarView(Browser* browser, BrowserView* browser_view)
|
|
|
|
+ToolbarView::ToolbarView(Browser* browser, BrowserView* browser_view,
|
2021-07-23 18:40:13 +02:00
|
|
|
+ absl::optional<DisplayMode> display_mode)
|
2021-04-11 22:10:11 +02:00
|
|
|
: AnimationDelegateViews(this),
|
|
|
|
browser_(browser),
|
|
|
|
browser_view_(browser_view),
|
|
|
|
app_menu_icon_controller_(browser->profile(), this),
|
|
|
|
- display_mode_(GetDisplayMode(browser)) {
|
|
|
|
+ display_mode_(display_mode ? *display_mode : GetDisplayMode(browser)) {
|
|
|
|
SetID(VIEW_ID_TOOLBAR);
|
|
|
|
|
2023-01-30 18:43:54 +01:00
|
|
|
if (display_mode_ == DisplayMode::NORMAL) {
|
|
|
|
@@ -200,7 +201,7 @@ void ToolbarView::Init() {
|
2021-04-21 00:52:34 +02:00
|
|
|
#endif
|
2021-04-11 22:10:11 +02:00
|
|
|
auto location_bar = std::make_unique<LocationBarView>(
|
|
|
|
browser_, browser_->profile(), browser_->command_controller(), this,
|
|
|
|
- display_mode_ != DisplayMode::NORMAL);
|
|
|
|
+ display_mode_ != DisplayMode::NORMAL && !browser_->toolbar_overridden());
|
|
|
|
// Make sure the toolbar shows by default.
|
|
|
|
size_animation_.Reset(1);
|
|
|
|
|
|
|
|
diff --git chrome/browser/ui/views/toolbar/toolbar_view.h chrome/browser/ui/views/toolbar/toolbar_view.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index 8c2ea74023637..a24cab7c58f93 100644
|
2021-04-11 22:10:11 +02:00
|
|
|
--- chrome/browser/ui/views/toolbar/toolbar_view.h
|
|
|
|
+++ chrome/browser/ui/views/toolbar/toolbar_view.h
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -92,7 +92,8 @@ class ToolbarView : public views::AccessiblePaneView,
|
2021-04-11 22:10:11 +02:00
|
|
|
// needs to be displayed.
|
|
|
|
};
|
|
|
|
|
|
|
|
- ToolbarView(Browser* browser, BrowserView* browser_view);
|
|
|
|
+ ToolbarView(Browser* browser, BrowserView* browser_view,
|
2021-07-23 18:40:13 +02:00
|
|
|
+ absl::optional<DisplayMode> display_mode);
|
2021-04-11 22:10:11 +02:00
|
|
|
ToolbarView(const ToolbarView&) = delete;
|
|
|
|
ToolbarView& operator=(const ToolbarView&) = delete;
|
|
|
|
~ToolbarView() override;
|