2020-07-06 20:14:57 +02:00
|
|
|
diff --git chrome/app/chrome_main_delegate.cc chrome/app/chrome_main_delegate.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index 227843d1197b0..eba67645bb16b 100644
|
2020-07-06 20:14:57 +02:00
|
|
|
--- chrome/app/chrome_main_delegate.cc
|
|
|
|
+++ chrome/app/chrome_main_delegate.cc
|
2023-09-15 21:51:43 +02:00
|
|
|
@@ -41,6 +41,7 @@
|
2020-07-06 20:14:57 +02:00
|
|
|
#include "base/trace_event/trace_event_impl.h"
|
|
|
|
#include "build/build_config.h"
|
2021-01-28 00:13:12 +01:00
|
|
|
#include "build/chromeos_buildflags.h"
|
2020-07-06 20:14:57 +02:00
|
|
|
+#include "cef/libcef/features/runtime.h"
|
2023-04-26 21:55:59 +02:00
|
|
|
#include "chrome/browser/buildflags.h"
|
2020-07-06 20:14:57 +02:00
|
|
|
#include "chrome/browser/chrome_content_browser_client.h"
|
|
|
|
#include "chrome/browser/chrome_resource_bundle_helper.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -608,6 +609,9 @@ struct MainFunction {
|
2020-07-06 20:14:57 +02:00
|
|
|
|
|
|
|
// Initializes the user data dir. Must be called before InitializeLocalState().
|
|
|
|
void InitializeUserDataDir(base::CommandLine* command_line) {
|
2023-12-06 21:16:15 +01:00
|
|
|
+ if (cef::IsChromeRuntimeEnabled()) {
|
2020-07-06 20:14:57 +02:00
|
|
|
+ return;
|
2023-12-06 21:16:15 +01:00
|
|
|
+ }
|
|
|
|
#if BUILDFLAG(IS_CHROMEOS_LACROS)
|
2023-11-21 20:17:55 +01:00
|
|
|
// In debug builds of Lacros, we keep track of when the user data dir
|
|
|
|
// is initialized, to ensure the cryptohome is not accessed before login
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -823,6 +827,10 @@ ChromeMainDelegate::~ChromeMainDelegate() {
|
2022-09-29 18:37:59 +02:00
|
|
|
ChromeMainDelegate::~ChromeMainDelegate() = default;
|
2022-11-15 18:50:53 +01:00
|
|
|
#endif // !BUILDFLAG(IS_ANDROID)
|
2022-09-29 18:37:59 +02:00
|
|
|
|
|
|
|
+void ChromeMainDelegate::CleanupOnUIThread() {
|
2023-04-04 20:00:13 +02:00
|
|
|
+ memory_system_.reset();
|
2022-09-29 18:37:59 +02:00
|
|
|
+}
|
|
|
|
+
|
2024-01-26 03:12:43 +01:00
|
|
|
std::optional<int> ChromeMainDelegate::PostEarlyInitialization(
|
2022-09-29 18:37:59 +02:00
|
|
|
InvokedIn invoked_in) {
|
2023-12-06 21:16:15 +01:00
|
|
|
DUMP_WILL_BE_CHECK(base::ThreadPoolInstance::Get());
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -857,7 +865,7 @@ std::optional<int> ChromeMainDelegate::PostEarlyInitialization(
|
2023-11-29 02:33:44 +01:00
|
|
|
// future session's metrics.
|
|
|
|
DeferBrowserMetrics(user_data_dir);
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_WIN)
|
|
|
|
+#if BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// In the case the process is not the singleton process, the uninstall tasks
|
|
|
|
// need to be executed here. A window will be displayed asking to close all
|
|
|
|
// running instances.
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1032,7 +1040,8 @@ std::optional<int> ChromeMainDelegate::PostEarlyInitialization(
|
2020-07-06 20:14:57 +02:00
|
|
|
|
2023-02-27 19:52:38 +01:00
|
|
|
if (base::FeatureList::IsEnabled(
|
|
|
|
features::kWriteBasicSystemProfileToPersistentHistogramsFile)) {
|
|
|
|
- bool record = true;
|
|
|
|
+ // Avoid CEF crash with multi-threaded-message-loop.
|
|
|
|
+ bool record = !cef::IsChromeRuntimeEnabled();
|
|
|
|
#if BUILDFLAG(IS_ANDROID)
|
|
|
|
record =
|
|
|
|
base::FeatureList::IsEnabled(chrome::android::kUmaBackgroundSessions);
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1487,6 +1496,7 @@ void ChromeMainDelegate::PreSandboxStartup() {
|
2020-07-06 20:14:57 +02:00
|
|
|
std::string process_type =
|
|
|
|
command_line.GetSwitchValueASCII(switches::kProcessType);
|
|
|
|
|
|
|
|
+ if (!cef::IsChromeRuntimeEnabled()) {
|
|
|
|
crash_reporter::InitializeCrashKeys();
|
|
|
|
|
2023-08-09 23:17:17 +02:00
|
|
|
#if BUILDFLAG(IS_CHROMEOS_LACROS)
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1505,6 +1515,7 @@ void ChromeMainDelegate::PreSandboxStartup() {
|
2020-07-06 20:14:57 +02:00
|
|
|
InitMacCrashReporter(command_line, process_type);
|
|
|
|
SetUpInstallerPreferences(command_line);
|
|
|
|
#endif
|
|
|
|
+ } // !cef::IsChromeRuntimeEnabled()
|
|
|
|
|
2022-01-25 21:26:51 +01:00
|
|
|
#if BUILDFLAG(IS_WIN)
|
2020-07-06 20:14:57 +02:00
|
|
|
child_process_logging::Init();
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1717,6 +1728,7 @@ void ChromeMainDelegate::PreSandboxStartup() {
|
2022-07-25 19:49:32 +02:00
|
|
|
CHECK(!loaded_locale.empty()) << "Locale could not be found for " << locale;
|
2020-07-06 20:14:57 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
+ if (!cef::IsChromeRuntimeEnabled()) {
|
2022-01-25 21:26:51 +01:00
|
|
|
#if BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_MAC)
|
2020-07-06 20:14:57 +02:00
|
|
|
// Zygote needs to call InitCrashReporter() in RunZygote().
|
2020-10-08 21:54:42 +02:00
|
|
|
if (process_type != switches::kZygoteProcess) {
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1760,6 +1772,7 @@ void ChromeMainDelegate::PreSandboxStartup() {
|
2020-07-06 20:14:57 +02:00
|
|
|
// After all the platform Breakpads have been initialized, store the command
|
|
|
|
// line for crash reporting.
|
|
|
|
crash_keys::SetCrashKeysFromCommandLine(command_line);
|
|
|
|
+ } // !cef::IsChromeRuntimeEnabled()
|
|
|
|
|
|
|
|
#if BUILDFLAG(ENABLE_PDF)
|
2021-09-20 11:06:23 +02:00
|
|
|
MaybePatchGdiGetFontData();
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1885,6 +1898,7 @@ void ChromeMainDelegate::ZygoteForked() {
|
2020-07-06 20:14:57 +02:00
|
|
|
SetUpProfilingShutdownHandler();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ if (!cef::IsChromeRuntimeEnabled()) {
|
|
|
|
// Needs to be called after we have chrome::DIR_USER_DATA. BrowserMain sets
|
|
|
|
// this up for the browser process in a different manner.
|
|
|
|
const base::CommandLine* command_line =
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1907,6 +1921,7 @@ void ChromeMainDelegate::ZygoteForked() {
|
2020-07-06 20:14:57 +02:00
|
|
|
|
|
|
|
// Reset the command line for the newly spawned process.
|
|
|
|
crash_keys::SetCrashKeysFromCommandLine(*command_line);
|
|
|
|
+ } // !cef::IsChromeRuntimeEnabled()
|
|
|
|
}
|
|
|
|
|
2022-01-25 21:26:51 +01:00
|
|
|
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -2006,6 +2021,7 @@ void ChromeMainDelegate::InitializeMemorySystem() {
|
2023-04-04 20:00:13 +02:00
|
|
|
channel == version_info::Channel::DEV);
|
|
|
|
const bool gwp_asan_boost_sampling = is_canary_dev || is_browser_process;
|
|
|
|
|
|
|
|
+ memory_system_ = std::make_unique<memory_system::MemorySystem>();
|
|
|
|
memory_system::Initializer()
|
|
|
|
.SetGwpAsanParameters(gwp_asan_boost_sampling, process_type)
|
|
|
|
.SetProfilingClientParameters(channel,
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -2015,5 +2031,5 @@ void ChromeMainDelegate::InitializeMemorySystem() {
|
2023-04-26 21:55:59 +02:00
|
|
|
memory_system::DispatcherParameters::
|
2023-07-21 00:11:34 +02:00
|
|
|
AllocationTraceRecorderInclusion::kDynamic,
|
|
|
|
process_type)
|
2023-04-04 20:00:13 +02:00
|
|
|
- .Initialize(memory_system_);
|
|
|
|
+ .Initialize(*memory_system_);
|
|
|
|
}
|
2022-09-29 18:37:59 +02:00
|
|
|
diff --git chrome/app/chrome_main_delegate.h chrome/app/chrome_main_delegate.h
|
2024-01-26 03:12:43 +01:00
|
|
|
index 3553377e96017..5207128b768f2 100644
|
2022-09-29 18:37:59 +02:00
|
|
|
--- chrome/app/chrome_main_delegate.h
|
|
|
|
+++ chrome/app/chrome_main_delegate.h
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -49,6 +49,8 @@ class ChromeMainDelegate : public content::ContentMainDelegate {
|
2022-09-29 18:37:59 +02:00
|
|
|
|
|
|
|
~ChromeMainDelegate() override;
|
|
|
|
|
|
|
|
+ virtual void CleanupOnUIThread();
|
|
|
|
+
|
|
|
|
protected:
|
|
|
|
// content::ContentMainDelegate:
|
2024-01-26 03:12:43 +01:00
|
|
|
std::optional<int> BasicStartupComplete() override;
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -98,7 +100,7 @@ class ChromeMainDelegate : public content::ContentMainDelegate {
|
|
|
|
|
|
|
|
ChromeContentClient chrome_content_client_;
|
|
|
|
|
|
|
|
- memory_system::MemorySystem memory_system_;
|
|
|
|
+ std::unique_ptr<memory_system::MemorySystem> memory_system_;
|
|
|
|
|
|
|
|
#if BUILDFLAG(IS_CHROMEOS_LACROS)
|
|
|
|
std::unique_ptr<chromeos::LacrosService> lacros_service_;
|
2020-06-25 04:34:12 +02:00
|
|
|
diff --git chrome/browser/chrome_browser_main.cc chrome/browser/chrome_browser_main.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index b5859c06d56e9..3a702aad4f453 100644
|
2020-06-25 04:34:12 +02:00
|
|
|
--- chrome/browser/chrome_browser_main.cc
|
|
|
|
+++ chrome/browser/chrome_browser_main.cc
|
2023-09-15 21:51:43 +02:00
|
|
|
@@ -52,6 +52,7 @@
|
2020-06-25 04:34:12 +02:00
|
|
|
#include "build/build_config.h"
|
2020-10-08 21:54:42 +02:00
|
|
|
#include "build/chromeos_buildflags.h"
|
2020-06-25 04:34:12 +02:00
|
|
|
#include "cc/base/switches.h"
|
2020-06-28 20:29:44 +02:00
|
|
|
+#include "cef/libcef/features/runtime.h"
|
2020-06-25 04:34:12 +02:00
|
|
|
#include "chrome/browser/about_flags.h"
|
|
|
|
#include "chrome/browser/active_use_util.h"
|
|
|
|
#include "chrome/browser/after_startup_task_utils.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -503,7 +504,7 @@ void ProcessSingletonNotificationCallbackImpl(
|
2023-11-29 02:33:44 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_WIN)
|
|
|
|
+#if BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// The uninstall command-line switch is handled by the origin process; see
|
|
|
|
// ChromeMainDelegate::PostEarlyInitialization(...). The other process won't
|
|
|
|
// be able to become the singleton process and will display a window asking
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -799,7 +800,7 @@ int ChromeBrowserMainParts::PreEarlyInitialization() {
|
2023-11-21 20:17:55 +01:00
|
|
|
return content::RESULT_CODE_NORMAL_EXIT;
|
|
|
|
}
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_WIN)
|
|
|
|
+#if BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// If we are running stale binaries then relaunch and exit immediately.
|
|
|
|
if (upgrade_util::IsRunningOldChrome()) {
|
|
|
|
if (!upgrade_util::RelaunchChromeBrowser(
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -812,7 +813,7 @@ int ChromeBrowserMainParts::PreEarlyInitialization() {
|
2023-11-21 20:17:55 +01:00
|
|
|
// result in browser startup bailing.
|
|
|
|
return chrome::RESULT_CODE_NORMAL_EXIT_UPGRADE_RELAUNCHED;
|
|
|
|
}
|
|
|
|
-#endif // BUILDFLAG(IS_WIN)
|
|
|
|
+#endif // BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
return load_local_state_result;
|
|
|
|
}
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -914,7 +915,7 @@ int ChromeBrowserMainParts::OnLocalStateLoaded(
|
2023-11-21 20:17:55 +01:00
|
|
|
browser_process_->local_state());
|
|
|
|
platform_management_service->RefreshCache(base::NullCallback());
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_WIN)
|
|
|
|
+#if BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
if (first_run::IsChromeFirstRun()) {
|
|
|
|
bool stats_default;
|
|
|
|
if (GoogleUpdateSettings::GetCollectStatsConsentDefault(&stats_default)) {
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -927,7 +928,7 @@ int ChromeBrowserMainParts::OnLocalStateLoaded(
|
2023-11-21 20:17:55 +01:00
|
|
|
: metrics::EnableMetricsDefault::OPT_IN);
|
|
|
|
}
|
2023-01-23 18:58:40 +01:00
|
|
|
}
|
2023-11-21 20:17:55 +01:00
|
|
|
-#endif // BUILDFLAG(IS_WIN)
|
|
|
|
+#endif // BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
std::string locale =
|
|
|
|
startup_data_->chrome_feature_list_creator()->actual_locale();
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -960,6 +961,7 @@ int ChromeBrowserMainParts::ApplyFirstRunPrefs() {
|
2023-11-21 20:17:55 +01:00
|
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
master_prefs_ = std::make_unique<first_run::MasterPrefs>();
|
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
std::unique_ptr<installer::InitialPreferences> installer_initial_prefs =
|
|
|
|
startup_data_->chrome_feature_list_creator()->TakeInitialPrefs();
|
|
|
|
if (!installer_initial_prefs)
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -993,6 +995,7 @@ int ChromeBrowserMainParts::ApplyFirstRunPrefs() {
|
2023-11-21 20:17:55 +01:00
|
|
|
master_prefs_->confirm_to_quit);
|
|
|
|
}
|
|
|
|
#endif // BUILDFLAG(IS_MAC)
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
2023-01-23 18:58:40 +01:00
|
|
|
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
2023-11-21 20:17:55 +01:00
|
|
|
return content::RESULT_CODE_NORMAL_EXIT;
|
|
|
|
}
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1059,6 +1062,7 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
|
2023-01-23 18:58:40 +01:00
|
|
|
|
2023-11-21 20:17:55 +01:00
|
|
|
browser_process_->browser_policy_connector()->OnResourceBundleCreated();
|
2023-01-23 18:58:40 +01:00
|
|
|
|
2023-11-21 20:17:55 +01:00
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// Android does first run in Java instead of native.
|
|
|
|
// Chrome OS has its own out-of-box-experience code.
|
|
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1080,6 +1084,7 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
#endif // BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
|
2023-01-23 18:58:40 +01:00
|
|
|
}
|
2023-11-21 20:17:55 +01:00
|
|
|
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
#if BUILDFLAG(IS_CHROMEOS)
|
|
|
|
// Set the product channel for crash reports.
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1458,6 +1463,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
browser_process_->PreMainMessageLoopRun();
|
2023-01-23 18:58:40 +01:00
|
|
|
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
2023-11-21 20:17:55 +01:00
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// If the command line specifies 'uninstall' then we need to work here
|
|
|
|
// unless we detect another chrome browser running.
|
|
|
|
if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUninstall)) {
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1469,6 +1475,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
return ChromeBrowserMainPartsWin::HandleIconsCommands(
|
|
|
|
*base::CommandLine::ForCurrentProcess());
|
|
|
|
}
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
ui::SelectFileDialog::SetFactory(
|
|
|
|
std::make_unique<ChromeSelectFileDialogFactory>());
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1486,6 +1493,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
}
|
|
|
|
#endif // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
|
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
|
|
|
|
switches::kMakeDefaultBrowser)) {
|
|
|
|
bool is_managed = g_browser_process->local_state()->IsManagedPreference(
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1499,18 +1507,22 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
? static_cast<int>(content::RESULT_CODE_NORMAL_EXIT)
|
|
|
|
: static_cast<int>(chrome::RESULT_CODE_SHELL_INTEGRATION_FAILED);
|
|
|
|
}
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
#if defined(USE_AURA)
|
|
|
|
// Make sure aura::Env has been initialized.
|
|
|
|
CHECK(aura::Env::GetInstance());
|
|
|
|
#endif // defined(USE_AURA)
|
|
|
|
|
|
|
|
+
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
|
|
// We must call DoUpgradeTasks now that we own the browser singleton to
|
|
|
|
// finish upgrade tasks (swap) and relaunch if necessary.
|
|
|
|
if (upgrade_util::DoUpgradeTasks(*base::CommandLine::ForCurrentProcess()))
|
|
|
|
return chrome::RESULT_CODE_NORMAL_EXIT_UPGRADE_RELAUNCHED;
|
|
|
|
#endif // BUILDFLAG(IS_WIN)
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
#if !BUILDFLAG(IS_ANDROID) && BUILDFLAG(ENABLE_DOWNGRADE_PROCESSING)
|
|
|
|
// Begin relaunch processing immediately if User Data migration is required
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1549,7 +1561,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
}
|
|
|
|
#endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_WIN)
|
|
|
|
+#if BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
2023-01-23 18:58:40 +01:00
|
|
|
// Check if there is any machine level Chrome installed on the current
|
2023-11-21 20:17:55 +01:00
|
|
|
// machine. If yes and the current Chrome process is user level, we do not
|
|
|
|
// allow the user level Chrome to run. So we notify the user and uninstall
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1558,7 +1570,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
// obtained but before potentially creating the first run sentinel).
|
|
|
|
if (ChromeBrowserMainPartsWin::CheckMachineLevelInstall())
|
|
|
|
return chrome::RESULT_CODE_MACHINE_LEVEL_INSTALL_EXISTS;
|
|
|
|
-#endif // BUILDFLAG(IS_WIN)
|
|
|
|
+#endif // BUILDFLAG(IS_WIN) && !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
// Desktop construction occurs here, (required before profile creation).
|
|
|
|
PreProfileInit();
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1601,12 +1613,14 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2022-02-17 00:23:45 +01:00
|
|
|
browser_process_->local_state());
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// Needs to be done before PostProfileInit, since login manager on CrOS is
|
|
|
|
// called inside PostProfileInit.
|
|
|
|
content::WebUIControllerFactory::RegisterFactory(
|
|
|
|
ChromeWebUIControllerFactory::GetInstance());
|
2022-05-19 12:28:44 +02:00
|
|
|
RegisterChromeWebUIConfigs();
|
2022-04-21 20:58:48 +02:00
|
|
|
RegisterChromeUntrustedWebUIConfigs();
|
2022-02-17 00:23:45 +01:00
|
|
|
+#endif
|
|
|
|
|
|
|
|
#if BUILDFLAG(IS_ANDROID)
|
|
|
|
page_info::SetPageInfoClient(new ChromePageInfoClient());
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1633,6 +1647,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
// Call `PostProfileInit()`and set it up for profiles created later.
|
|
|
|
profile_init_manager_ = std::make_unique<ProfileInitManager>(this, profile);
|
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
// Execute first run specific code after the PrefService has been initialized
|
|
|
|
// and preferences have been registered since some of the import code depends
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1672,6 +1687,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-11-21 20:17:55 +01:00
|
|
|
*base::CommandLine::ForCurrentProcess());
|
|
|
|
}
|
|
|
|
#endif // BUILDFLAG(IS_WIN)
|
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
|
|
|
// Configure modules that need access to resources.
|
|
|
|
net::NetModule::SetResourceProvider(ChromeNetResourceProvider);
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1751,6 +1767,11 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2023-12-06 21:16:15 +01:00
|
|
|
g_browser_process->profile_manager()->GetLastOpenedProfiles();
|
2023-01-23 18:58:40 +01:00
|
|
|
}
|
|
|
|
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
|
2023-12-06 21:16:15 +01:00
|
|
|
+
|
2023-01-23 18:58:40 +01:00
|
|
|
+ // Bypass StartupBrowserCreator and RunLoop creation with CEF.
|
|
|
|
+ // CEF with the Chrome runtime will create and manage its own RunLoop.
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
+
|
2023-12-06 21:16:15 +01:00
|
|
|
// This step is costly.
|
2023-11-21 20:17:55 +01:00
|
|
|
if (browser_creator_->Start(*base::CommandLine::ForCurrentProcess(),
|
2023-12-06 21:16:15 +01:00
|
|
|
base::FilePath(), profile_info,
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1783,11 +1804,14 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
|
2021-12-16 23:35:54 +01:00
|
|
|
|
|
|
|
// Create the RunLoop for MainMessageLoopRun() to use and transfer
|
|
|
|
// ownership of the browser's lifetime to the BrowserProcess.
|
|
|
|
+ // CEF with the Chrome runtime will create and manage its own RunLoop.
|
|
|
|
DCHECK(!GetMainRunLoopInstance());
|
2023-01-23 18:58:40 +01:00
|
|
|
GetMainRunLoopInstance() = std::make_unique<base::RunLoop>();
|
2021-12-16 23:35:54 +01:00
|
|
|
browser_process_->SetQuitClosure(
|
|
|
|
GetMainRunLoopInstance()->QuitWhenIdleClosure());
|
|
|
|
}
|
2023-01-23 18:58:40 +01:00
|
|
|
+#endif // !BUILDFLAG(ENABLE_CEF)
|
|
|
|
+
|
|
|
|
browser_creator_.reset();
|
|
|
|
#endif // !BUILDFLAG(IS_ANDROID)
|
|
|
|
|
2021-02-23 21:08:33 +01:00
|
|
|
diff --git chrome/browser/chrome_browser_main_mac.mm chrome/browser/chrome_browser_main_mac.mm
|
2024-01-26 03:12:43 +01:00
|
|
|
index 7c438a75e086c..f3088e0e6d564 100644
|
2021-02-23 21:08:33 +01:00
|
|
|
--- chrome/browser/chrome_browser_main_mac.mm
|
|
|
|
+++ chrome/browser/chrome_browser_main_mac.mm
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -16,6 +16,7 @@
|
2021-02-23 21:08:33 +01:00
|
|
|
#include "base/path_service.h"
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
|
|
|
#include "build/branding_buildflags.h"
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#import "chrome/browser/app_controller_mac.h"
|
|
|
|
#include "chrome/browser/apps/app_shim/app_shim_listener.h"
|
|
|
|
#include "chrome/browser/browser_process.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -100,6 +101,7 @@ void ChromeBrowserMainPartsMac::PreCreateMainMessageLoop() {
|
2021-02-23 21:08:33 +01:00
|
|
|
}
|
2023-01-30 18:43:54 +01:00
|
|
|
#endif // !BUILDFLAG(CHROME_FOR_TESTING)
|
2021-02-23 21:08:33 +01:00
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
2023-06-26 12:13:38 +02:00
|
|
|
// Create the app delegate by requesting the shared AppController.
|
|
|
|
CHECK_EQ(nil, NSApp.delegate);
|
|
|
|
AppController* app_controller = AppController.sharedController;
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -108,6 +110,7 @@ void ChromeBrowserMainPartsMac::PreCreateMainMessageLoop() {
|
2021-02-23 21:08:33 +01:00
|
|
|
chrome::BuildMainMenu(NSApp, app_controller,
|
|
|
|
l10n_util::GetStringUTF16(IDS_PRODUCT_NAME), false);
|
|
|
|
[app_controller mainMenuCreated];
|
|
|
|
+#endif // BUILDFLAG(ENABLE_CEF)
|
|
|
|
|
2022-05-19 12:28:44 +02:00
|
|
|
ui::WarmScreenCapture();
|
|
|
|
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -145,5 +148,7 @@ void ChromeBrowserMainPartsMac::PostProfileInit(Profile* profile,
|
2021-02-23 21:08:33 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
2023-06-26 12:13:38 +02:00
|
|
|
[AppController.sharedController didEndMainMessageLoop];
|
2021-02-23 21:08:33 +01:00
|
|
|
+#endif
|
|
|
|
}
|
2021-03-04 23:36:57 +01:00
|
|
|
diff --git chrome/browser/chrome_content_browser_client.cc chrome/browser/chrome_content_browser_client.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index c8f705069d25b..aa9e0fd6efd0e 100644
|
2021-03-04 23:36:57 +01:00
|
|
|
--- chrome/browser/chrome_content_browser_client.cc
|
|
|
|
+++ chrome/browser/chrome_content_browser_client.cc
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -46,6 +46,7 @@
|
2021-03-04 23:36:57 +01:00
|
|
|
#include "build/build_config.h"
|
|
|
|
#include "build/chromeos_buildflags.h"
|
2023-12-06 21:16:15 +01:00
|
|
|
#include "build/config/chromebox_for_meetings/buildflags.h" // PLATFORM_CFM
|
2021-03-04 23:36:57 +01:00
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#include "chrome/browser/accessibility/accessibility_labels_service.h"
|
|
|
|
#include "chrome/browser/accessibility/accessibility_labels_service_factory.h"
|
2021-06-04 03:34:56 +02:00
|
|
|
#include "chrome/browser/after_startup_task_utils.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1409,6 +1410,8 @@ ChromeContentBrowserClient::GetPopupNavigationDelegateFactoryForTesting() {
|
2023-04-04 20:00:13 +02:00
|
|
|
}
|
2022-03-09 20:45:39 +01:00
|
|
|
|
|
|
|
ChromeContentBrowserClient::ChromeContentBrowserClient() {
|
|
|
|
+ keepalive_timer_.reset(new base::OneShotTimer());
|
|
|
|
+
|
|
|
|
#if BUILDFLAG(ENABLE_PLUGINS)
|
2023-04-26 21:55:59 +02:00
|
|
|
extra_parts_.push_back(
|
|
|
|
std::make_unique<ChromeContentBrowserClientPluginsPart>());
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1441,6 +1444,11 @@ ChromeContentBrowserClient::~ChromeContentBrowserClient() {
|
2023-04-26 21:55:59 +02:00
|
|
|
}
|
2022-03-09 20:45:39 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+void ChromeContentBrowserClient::CleanupOnUIThread() {
|
|
|
|
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
|
|
|
+ keepalive_timer_.reset();
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
// static
|
|
|
|
void ChromeContentBrowserClient::RegisterLocalStatePrefs(
|
|
|
|
PrefRegistrySimple* registry) {
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -4299,9 +4307,11 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(
|
2021-03-04 23:36:57 +01:00
|
|
|
&search::HandleNewTabURLReverseRewrite);
|
2022-01-25 21:26:51 +01:00
|
|
|
#endif // BUILDFLAG(IS_ANDROID)
|
2021-03-04 23:36:57 +01:00
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
|
|
|
// chrome: & friends.
|
|
|
|
handler->AddHandlerPair(&ChromeContentBrowserClient::HandleWebUI,
|
|
|
|
&ChromeContentBrowserClient::HandleWebUIReverse);
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
base::FilePath ChromeContentBrowserClient::GetDefaultDownloadDirectory() {
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -6373,7 +6383,7 @@ void ChromeContentBrowserClient::OnNetworkServiceCreated(
|
2023-04-04 20:00:13 +02:00
|
|
|
#endif
|
2021-10-19 00:17:16 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
-void ChromeContentBrowserClient::ConfigureNetworkContextParams(
|
|
|
|
+bool ChromeContentBrowserClient::ConfigureNetworkContextParams(
|
|
|
|
content::BrowserContext* context,
|
|
|
|
bool in_memory,
|
|
|
|
const base::FilePath& relative_partition_path,
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -6391,6 +6401,8 @@ void ChromeContentBrowserClient::ConfigureNetworkContextParams(
|
2021-12-16 23:35:54 +01:00
|
|
|
network_context_params->user_agent = GetUserAgentBasedOnPolicy(context);
|
2021-10-19 00:17:16 +02:00
|
|
|
network_context_params->accept_language = GetApplicationLocale();
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<base::FilePath>
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -7535,10 +7547,10 @@ void ChromeContentBrowserClient::OnKeepaliveRequestStarted(
|
2022-03-09 20:45:39 +01:00
|
|
|
const auto now = base::TimeTicks::Now();
|
|
|
|
const auto timeout = GetKeepaliveTimerTimeout(context);
|
|
|
|
keepalive_deadline_ = std::max(keepalive_deadline_, now + timeout);
|
|
|
|
- if (keepalive_deadline_ > now && !keepalive_timer_.IsRunning()) {
|
|
|
|
+ if (keepalive_deadline_ > now && !keepalive_timer_->IsRunning()) {
|
|
|
|
DVLOG(1) << "Starting a keepalive timer(" << timeout.InSecondsF()
|
|
|
|
<< " seconds)";
|
|
|
|
- keepalive_timer_.Start(
|
|
|
|
+ keepalive_timer_->Start(
|
|
|
|
FROM_HERE, keepalive_deadline_ - now,
|
|
|
|
base::BindOnce(
|
|
|
|
&ChromeContentBrowserClient::OnKeepaliveTimerFired,
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -7557,7 +7569,8 @@ void ChromeContentBrowserClient::OnKeepaliveRequestFinished() {
|
2022-03-09 20:45:39 +01:00
|
|
|
--num_keepalive_requests_;
|
|
|
|
if (num_keepalive_requests_ == 0) {
|
|
|
|
DVLOG(1) << "Stopping the keepalive timer";
|
|
|
|
- keepalive_timer_.Stop();
|
|
|
|
+ if (keepalive_timer_)
|
|
|
|
+ keepalive_timer_->Stop();
|
|
|
|
// This deletes the keep alive handle attached to the timer function and
|
|
|
|
// unblock the shutdown sequence.
|
|
|
|
}
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -7699,7 +7712,7 @@ void ChromeContentBrowserClient::OnKeepaliveTimerFired(
|
2022-03-09 20:45:39 +01:00
|
|
|
const auto now = base::TimeTicks::Now();
|
|
|
|
const auto then = keepalive_deadline_;
|
|
|
|
if (now < then) {
|
|
|
|
- keepalive_timer_.Start(
|
|
|
|
+ keepalive_timer_->Start(
|
|
|
|
FROM_HERE, then - now,
|
|
|
|
base::BindOnce(&ChromeContentBrowserClient::OnKeepaliveTimerFired,
|
|
|
|
weak_factory_.GetWeakPtr(),
|
2021-10-19 00:17:16 +02:00
|
|
|
diff --git chrome/browser/chrome_content_browser_client.h chrome/browser/chrome_content_browser_client.h
|
2024-01-26 03:12:43 +01:00
|
|
|
index 8ac74856217e4..e7632e1e08e96 100644
|
2021-10-19 00:17:16 +02:00
|
|
|
--- chrome/browser/chrome_content_browser_client.h
|
|
|
|
+++ chrome/browser/chrome_content_browser_client.h
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -142,6 +142,8 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
|
2022-03-09 20:45:39 +01:00
|
|
|
|
|
|
|
~ChromeContentBrowserClient() override;
|
|
|
|
|
|
|
|
+ virtual void CleanupOnUIThread();
|
|
|
|
+
|
|
|
|
// TODO(https://crbug.com/787567): This file is about calls from content/ out
|
|
|
|
// to chrome/ to get values or notify about events, but both of these
|
|
|
|
// functions are from chrome/ to chrome/ and don't involve content/ at all.
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -667,7 +669,7 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
|
2021-10-19 00:17:16 +02:00
|
|
|
override;
|
|
|
|
void OnNetworkServiceCreated(
|
|
|
|
network::mojom::NetworkService* network_service) override;
|
|
|
|
- void ConfigureNetworkContextParams(
|
|
|
|
+ bool ConfigureNetworkContextParams(
|
|
|
|
content::BrowserContext* context,
|
|
|
|
bool in_memory,
|
|
|
|
const base::FilePath& relative_partition_path,
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1160,7 +1162,7 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
|
2022-03-09 20:45:39 +01:00
|
|
|
|
|
|
|
#if !BUILDFLAG(IS_ANDROID)
|
|
|
|
uint64_t num_keepalive_requests_ = 0;
|
|
|
|
- base::OneShotTimer keepalive_timer_;
|
|
|
|
+ std::unique_ptr<base::OneShotTimer> keepalive_timer_;
|
|
|
|
base::TimeTicks keepalive_deadline_;
|
|
|
|
#endif
|
|
|
|
|
2021-04-10 04:00:33 +02:00
|
|
|
diff --git chrome/browser/prefs/browser_prefs.cc chrome/browser/prefs/browser_prefs.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index 94a93ca5c715c..17cc9e515d99c 100644
|
2021-04-10 04:00:33 +02:00
|
|
|
--- chrome/browser/prefs/browser_prefs.cc
|
|
|
|
+++ chrome/browser/prefs/browser_prefs.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -15,6 +15,7 @@
|
2021-04-10 04:00:33 +02:00
|
|
|
#include "build/build_config.h"
|
2021-10-19 00:17:16 +02:00
|
|
|
#include "build/chromecast_buildflags.h"
|
2021-04-10 04:00:33 +02:00
|
|
|
#include "build/chromeos_buildflags.h"
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#include "chrome/browser/about_flags.h"
|
|
|
|
#include "chrome/browser/accessibility/accessibility_labels_service.h"
|
|
|
|
#include "chrome/browser/accessibility/accessibility_ui.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -194,6 +195,10 @@
|
2021-04-10 04:00:33 +02:00
|
|
|
#include "chrome/browser/background/background_mode_manager.h"
|
|
|
|
#endif
|
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+#include "cef/libcef/browser/prefs/browser_prefs.h"
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
#if BUILDFLAG(ENABLE_EXTENSIONS)
|
|
|
|
#include "chrome/browser/accessibility/animation_policy_prefs.h"
|
|
|
|
#include "chrome/browser/apps/platform_apps/shortcut_manager.h"
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1626,7 +1631,9 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
|
2023-11-21 20:17:55 +01:00
|
|
|
|
|
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
RegisterDefaultBrowserPromptPrefs(registry);
|
|
|
|
+#if BUILDFLAG(ENABLE_DOWNGRADE_PROCESSING)
|
|
|
|
downgrade::RegisterPrefs(registry);
|
|
|
|
+#endif
|
|
|
|
DeviceOAuth2TokenStoreDesktop::RegisterPrefs(registry);
|
|
|
|
#endif
|
|
|
|
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -1649,6 +1656,11 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
|
2022-10-26 00:50:29 +02:00
|
|
|
|
|
|
|
// This is intentionally last.
|
|
|
|
RegisterLocalStatePrefsForMigration(registry);
|
|
|
|
+
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ // Always call this last.
|
|
|
|
+ browser_prefs::RegisterLocalStatePrefs(registry);
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// Register prefs applicable to all profiles.
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -2085,6 +2097,10 @@ void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
|
2022-10-26 00:50:29 +02:00
|
|
|
const std::string& locale) {
|
|
|
|
RegisterProfilePrefs(registry, locale);
|
2021-04-10 04:00:33 +02:00
|
|
|
|
|
|
|
+#if BUILDFLAG(ENABLE_CEF)
|
|
|
|
+ browser_prefs::RegisterProfilePrefs(registry);
|
|
|
|
+#endif
|
|
|
|
+
|
2022-10-26 00:50:29 +02:00
|
|
|
#if BUILDFLAG(IS_ANDROID)
|
|
|
|
::android::RegisterUserProfilePrefs(registry);
|
|
|
|
#endif
|