2021-07-23 18:40:13 +02:00
|
|
|
diff --git third_party/blink/public/web/web_view.h third_party/blink/public/web/web_view.h
|
2024-01-26 03:12:43 +01:00
|
|
|
index 2ba868f0efb2e..4ec2a9ca69cab 100644
|
2021-07-23 18:40:13 +02:00
|
|
|
--- third_party/blink/public/web/web_view.h
|
|
|
|
+++ third_party/blink/public/web/web_view.h
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -345,6 +345,7 @@ class BLINK_EXPORT WebView {
|
2021-07-23 18:40:13 +02:00
|
|
|
|
|
|
|
// Sets whether select popup menus should be rendered by the browser.
|
2022-09-26 21:30:45 +02:00
|
|
|
static void SetUseExternalPopupMenus(bool);
|
2021-07-23 18:40:13 +02:00
|
|
|
+ virtual void SetUseExternalPopupMenusThisInstance(bool) = 0;
|
|
|
|
|
|
|
|
// Cancels and hides the current popup (datetime, select...) if any.
|
|
|
|
virtual void CancelPagePopup() = 0;
|
|
|
|
diff --git third_party/blink/renderer/core/exported/web_view_impl.cc third_party/blink/renderer/core/exported/web_view_impl.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index aafdfd4fffd0b..4215f48d15284 100644
|
2021-07-23 18:40:13 +02:00
|
|
|
--- third_party/blink/renderer/core/exported/web_view_impl.cc
|
|
|
|
+++ third_party/blink/renderer/core/exported/web_view_impl.cc
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -251,8 +251,13 @@ void WebView::SetUseExternalPopupMenus(bool use_external_popup_menus) {
|
2021-07-23 18:40:13 +02:00
|
|
|
g_should_use_external_popup_menus = use_external_popup_menus;
|
|
|
|
}
|
|
|
|
|
|
|
|
-bool WebViewImpl::UseExternalPopupMenus() {
|
|
|
|
- return g_should_use_external_popup_menus;
|
|
|
|
+void WebViewImpl::SetUseExternalPopupMenusThisInstance(
|
|
|
|
+ bool use_external_popup_menus) {
|
|
|
|
+ should_use_external_popup_menus_ = use_external_popup_menus;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+bool WebViewImpl::UseExternalPopupMenus() const {
|
|
|
|
+ return should_use_external_popup_menus_;
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -584,6 +589,7 @@ WebViewImpl::WebViewImpl(
|
2021-07-23 18:40:13 +02:00
|
|
|
chrome_client_(MakeGarbageCollected<ChromeClientImpl>(this)),
|
|
|
|
minimum_zoom_level_(PageZoomFactorToZoomLevel(kMinimumPageZoomFactor)),
|
|
|
|
maximum_zoom_level_(PageZoomFactorToZoomLevel(kMaximumPageZoomFactor)),
|
|
|
|
+ should_use_external_popup_menus_(g_should_use_external_popup_menus),
|
|
|
|
does_composite_(does_composite),
|
|
|
|
fullscreen_controller_(std::make_unique<FullscreenController>(this)),
|
|
|
|
page_base_background_color_(
|
|
|
|
diff --git third_party/blink/renderer/core/exported/web_view_impl.h third_party/blink/renderer/core/exported/web_view_impl.h
|
2024-01-26 03:12:43 +01:00
|
|
|
index 25566d1e5a367..6ad48660a42ee 100644
|
2021-07-23 18:40:13 +02:00
|
|
|
--- third_party/blink/renderer/core/exported/web_view_impl.h
|
|
|
|
+++ third_party/blink/renderer/core/exported/web_view_impl.h
|
2023-12-06 21:16:15 +01:00
|
|
|
@@ -139,7 +139,8 @@ class CORE_EXPORT WebViewImpl final : public WebView,
|
2021-07-23 18:40:13 +02:00
|
|
|
static HashSet<WebViewImpl*>& AllInstances();
|
|
|
|
// Returns true if popup menus should be rendered by the browser, false if
|
|
|
|
// they should be rendered by WebKit (which is the default).
|
|
|
|
- static bool UseExternalPopupMenus();
|
|
|
|
+ void SetUseExternalPopupMenusThisInstance(bool) override;
|
|
|
|
+ bool UseExternalPopupMenus() const;
|
|
|
|
|
|
|
|
// Returns whether frames under this WebView are backed by a compositor.
|
|
|
|
bool does_composite() const { return does_composite_; }
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -871,6 +872,8 @@ class CORE_EXPORT WebViewImpl final : public WebView,
|
2021-07-23 18:40:13 +02:00
|
|
|
float fake_page_scale_animation_page_scale_factor_ = 0.f;
|
|
|
|
bool fake_page_scale_animation_use_anchor_ = false;
|
|
|
|
|
|
|
|
+ bool should_use_external_popup_menus_;
|
|
|
|
+
|
|
|
|
float compositor_device_scale_factor_override_ = 0.f;
|
2022-11-15 18:50:53 +01:00
|
|
|
gfx::Transform device_emulation_transform_;
|
2021-07-23 18:40:13 +02:00
|
|
|
|
|
|
|
diff --git third_party/blink/renderer/core/page/chrome_client_impl.cc third_party/blink/renderer/core/page/chrome_client_impl.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
index e8c40f756f746..d3738d1388c96 100644
|
2021-07-23 18:40:13 +02:00
|
|
|
--- third_party/blink/renderer/core/page/chrome_client_impl.cc
|
|
|
|
+++ third_party/blink/renderer/core/page/chrome_client_impl.cc
|
2024-01-26 03:12:43 +01:00
|
|
|
@@ -981,7 +981,7 @@ PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,
|
2021-07-23 18:40:13 +02:00
|
|
|
HTMLSelectElement& select) {
|
|
|
|
NotifyPopupOpeningObservers();
|
|
|
|
|
2023-12-06 21:16:15 +01:00
|
|
|
- bool use_external_popup_menus = WebViewImpl::UseExternalPopupMenus();
|
|
|
|
+ bool use_external_popup_menus = web_view_->UseExternalPopupMenus();
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
|
|
// There is a bug that is causing popup menus in PWA windows on macOS to
|
|
|
|
// sometimes not appear if using external popup menus. Until that bug is
|