2017-02-22 19:05:27 +01:00
|
|
|
diff --git ui/base/models/menu_model.h ui/base/models/menu_model.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index 50eeaa9acca98..eb4c7aa70de9c 100644
|
2017-02-22 19:05:27 +01:00
|
|
|
--- ui/base/models/menu_model.h
|
|
|
|
+++ ui/base/models/menu_model.h
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -17,8 +17,11 @@
|
|
|
|
#include "ui/color/color_id.h"
|
2020-06-09 19:48:00 +02:00
|
|
|
#include "ui/gfx/native_widget_types.h"
|
|
|
|
|
|
|
|
+#include "third_party/skia/include/core/SkColor.h"
|
|
|
|
+
|
2017-02-22 19:05:27 +01:00
|
|
|
namespace gfx {
|
|
|
|
class FontList;
|
|
|
|
+class Point;
|
|
|
|
}
|
|
|
|
|
2020-06-09 19:48:00 +02:00
|
|
|
namespace ui {
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -149,6 +152,27 @@ class COMPONENT_EXPORT(UI_BASE) MenuModel
|
2017-02-22 19:05:27 +01:00
|
|
|
// |event_flags| is a bit mask of ui::EventFlags.
|
2022-07-25 19:49:32 +02:00
|
|
|
virtual void ActivatedAt(size_t index, int event_flags);
|
2017-02-22 19:05:27 +01:00
|
|
|
|
|
|
|
+ // Called when the user moves the mouse outside the menu and over the owning
|
|
|
|
+ // window.
|
|
|
|
+ virtual void MouseOutsideMenu(const gfx::Point& screen_point) {}
|
|
|
|
+
|
|
|
|
+ // Called on unhandled open/close submenu keyboard commands. |is_rtl| will be
|
|
|
|
+ // true if the menu is displaying a right-to-left language.
|
|
|
|
+ virtual void UnhandledOpenSubmenu(bool is_rtl) {}
|
|
|
|
+ virtual void UnhandledCloseSubmenu(bool is_rtl) {}
|
2017-02-25 06:03:31 +01:00
|
|
|
+
|
|
|
|
+ // Override the text/background color of a given menu item dependent on the
|
2017-03-03 23:37:23 +01:00
|
|
|
+ // |index| and its |is_hovered| state. |is_minor| will be true for accelerator
|
|
|
|
+ // text. Returns true if it chooses to override the color.
|
2022-07-25 19:49:32 +02:00
|
|
|
+ virtual bool GetTextColor(size_t index,
|
2017-03-03 23:37:23 +01:00
|
|
|
+ bool is_minor,
|
2017-02-25 06:03:31 +01:00
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const { return false; }
|
2022-07-25 19:49:32 +02:00
|
|
|
+ virtual bool GetBackgroundColor(size_t index,
|
2017-02-25 06:03:31 +01:00
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const
|
|
|
|
+ { return false; }
|
2017-02-22 19:05:27 +01:00
|
|
|
+
|
|
|
|
// Called when the menu is about to be shown.
|
|
|
|
virtual void MenuWillShow() {}
|
|
|
|
|
2017-02-24 21:01:42 +01:00
|
|
|
diff --git ui/gfx/render_text.cc ui/gfx/render_text.cc
|
2023-02-27 19:52:38 +01:00
|
|
|
index 2beb8043a684a..52654691534d6 100644
|
2017-02-24 21:01:42 +01:00
|
|
|
--- ui/gfx/render_text.cc
|
|
|
|
+++ ui/gfx/render_text.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -665,6 +665,14 @@ void RenderText::SetWhitespaceElision(absl::optional<bool> whitespace_elision) {
|
2017-02-24 21:01:42 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
+void RenderText::SetDrawStringsFlags(int flags) {
|
|
|
|
+ if (draw_strings_flags_ == flags)
|
|
|
|
+ return;
|
|
|
|
+ draw_strings_flags_ = flags;
|
|
|
|
+ cached_bounds_and_offset_valid_ = false;
|
|
|
|
+ OnTextAttributeChanged();
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
void RenderText::SetDisplayRect(const Rect& r) {
|
|
|
|
if (r != display_rect_) {
|
|
|
|
display_rect_ = r;
|
2023-02-27 19:52:38 +01:00
|
|
|
@@ -2034,6 +2042,19 @@ void RenderText::OnTextAttributeChanged() {
|
2020-02-10 18:10:17 +01:00
|
|
|
|
|
|
|
layout_text_up_to_date_ = false;
|
2017-02-24 21:01:42 +01:00
|
|
|
|
|
|
|
+ if (draw_strings_flags_ != 0) {
|
|
|
|
+ // Compute layout size with the mnemonic character underlined since it might
|
|
|
|
+ // be larger than with the underline hidden.
|
|
|
|
+ int char_pos = -1;
|
|
|
|
+ int char_span = 0;
|
|
|
|
+ layout_text_ =
|
2021-01-28 00:13:12 +01:00
|
|
|
+ gfx::LocateAndRemoveAcceleratorChar(layout_text_, &char_pos, &char_span);
|
2017-02-24 21:01:42 +01:00
|
|
|
+ if (char_pos != -1) {
|
|
|
|
+ gfx::Range range(char_pos, char_pos + char_span);
|
2019-02-01 20:40:18 +01:00
|
|
|
+ styles_[TEXT_STYLE_UNDERLINE].ApplyValue(true, range);
|
2017-02-24 21:01:42 +01:00
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
OnLayoutTextAttributeChanged(true);
|
|
|
|
}
|
|
|
|
|
|
|
|
diff --git ui/gfx/render_text.h ui/gfx/render_text.h
|
2023-02-27 19:52:38 +01:00
|
|
|
index 3c78525361ebf..c922dfe5019a3 100644
|
2017-02-24 21:01:42 +01:00
|
|
|
--- ui/gfx/render_text.h
|
|
|
|
+++ ui/gfx/render_text.h
|
2022-04-21 20:58:48 +02:00
|
|
|
@@ -347,6 +347,10 @@ class GFX_EXPORT RenderText {
|
2019-09-04 17:13:32 +02:00
|
|
|
return whitespace_elision_;
|
|
|
|
}
|
2017-02-24 21:01:42 +01:00
|
|
|
|
|
|
|
+ // Get or set the flags that control display of accelerator characters.
|
|
|
|
+ void SetDrawStringsFlags(int flags);
|
|
|
|
+ int draw_strings_flags() const { return draw_strings_flags_; }
|
|
|
|
+
|
|
|
|
const Rect& display_rect() const { return display_rect_; }
|
|
|
|
void SetDisplayRect(const Rect& r);
|
|
|
|
|
2022-07-21 19:26:10 +02:00
|
|
|
@@ -1050,6 +1054,8 @@ class GFX_EXPORT RenderText {
|
2021-06-04 03:34:56 +02:00
|
|
|
|
2020-03-04 01:29:39 +01:00
|
|
|
// Tell whether or not the |layout_text_| needs an update or is up to date.
|
|
|
|
mutable bool layout_text_up_to_date_ = false;
|
2017-02-24 21:01:42 +01:00
|
|
|
+
|
2021-06-04 03:34:56 +02:00
|
|
|
+ int draw_strings_flags_ = 0;
|
2017-02-24 21:01:42 +01:00
|
|
|
};
|
|
|
|
|
2021-06-04 03:34:56 +02:00
|
|
|
} // namespace gfx
|
2023-01-30 18:43:54 +01:00
|
|
|
diff --git ui/views/animation/ink_drop_host.h ui/views/animation/ink_drop_host.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index 4512e4e37cb76..ca39d737e9723 100644
|
2023-01-30 18:43:54 +01:00
|
|
|
--- ui/views/animation/ink_drop_host.h
|
|
|
|
+++ ui/views/animation/ink_drop_host.h
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -186,6 +186,8 @@ class VIEWS_EXPORT InkDropHost {
|
2021-06-04 03:34:56 +02:00
|
|
|
View* host_view() { return host_view_; }
|
|
|
|
const View* host_view() const { return host_view_; }
|
2017-05-31 17:33:30 +02:00
|
|
|
|
|
|
|
+ InkDropMode ink_drop_mode() const { return ink_drop_mode_; }
|
|
|
|
+
|
2021-06-04 03:34:56 +02:00
|
|
|
private:
|
|
|
|
friend class test::InkDropHostTestApi;
|
|
|
|
|
2017-02-24 21:01:42 +01:00
|
|
|
diff --git ui/views/controls/button/label_button.cc ui/views/controls/button/label_button.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index ca061545ed8f2..711207914f1fa 100644
|
2017-02-24 21:01:42 +01:00
|
|
|
--- ui/views/controls/button/label_button.cc
|
|
|
|
+++ ui/views/controls/button/label_button.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -552,6 +552,12 @@ void LabelButton::OnThemeChanged() {
|
2019-07-16 19:59:21 +02:00
|
|
|
SchedulePaint();
|
2017-05-31 17:33:30 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
+void LabelButton::SetFontList(const gfx::FontList& font_list) {
|
|
|
|
+ cached_normal_font_list_ = font_list;
|
2017-08-08 22:10:24 +02:00
|
|
|
+ cached_default_button_font_list_ = font_list;
|
2017-05-31 17:33:30 +02:00
|
|
|
+ label_->SetFontList(cached_normal_font_list_);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
void LabelButton::StateChanged(ButtonState old_state) {
|
2020-08-29 00:39:23 +02:00
|
|
|
Button::StateChanged(old_state);
|
|
|
|
ResetLabelEnabledColor();
|
2017-05-31 17:33:30 +02:00
|
|
|
diff --git ui/views/controls/button/label_button.h ui/views/controls/button/label_button.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index e641dc163c5fc..785ccd20e4dd4 100644
|
2017-05-31 17:33:30 +02:00
|
|
|
--- ui/views/controls/button/label_button.h
|
|
|
|
+++ ui/views/controls/button/label_button.h
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -150,6 +150,9 @@ class VIEWS_EXPORT LabelButton : public Button, public NativeThemeDelegate {
|
2019-07-16 19:59:21 +02:00
|
|
|
ui::NativeTheme::State GetForegroundThemeState(
|
|
|
|
ui::NativeTheme::ExtraParams* params) const override;
|
2017-05-31 17:33:30 +02:00
|
|
|
|
|
|
|
+ // Sets the font list used by this button.
|
|
|
|
+ void SetFontList(const gfx::FontList& font_list);
|
|
|
|
+
|
|
|
|
protected:
|
|
|
|
ImageView* image() const { return image_; }
|
2019-07-16 19:59:21 +02:00
|
|
|
Label* label() const { return label_; }
|
2017-02-23 21:24:45 +01:00
|
|
|
diff --git ui/views/controls/label.cc ui/views/controls/label.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index 37c22391d5c94..d96f63ed47ec2 100644
|
2017-02-23 21:24:45 +01:00
|
|
|
--- ui/views/controls/label.cc
|
|
|
|
+++ ui/views/controls/label.cc
|
2023-02-27 19:52:38 +01:00
|
|
|
@@ -51,12 +51,29 @@ enum LabelPropertyKey {
|
2020-08-29 00:39:23 +02:00
|
|
|
kLabelLineHeight,
|
|
|
|
kLabelObscured,
|
|
|
|
kLabelAllowCharacterBreak,
|
|
|
|
+ kLabelDrawStringsFlags,
|
|
|
|
};
|
|
|
|
|
|
|
|
bool IsOpaque(SkColor color) {
|
2019-09-04 17:13:32 +02:00
|
|
|
return SkColorGetA(color) == SK_AlphaOPAQUE;
|
|
|
|
}
|
2019-01-17 10:56:52 +01:00
|
|
|
|
2017-02-23 21:24:45 +01:00
|
|
|
+// Strips accelerator character prefixes in |text| if needed, based on |flags|.
|
|
|
|
+// Returns a range in |text| to underline or Range::InvalidRange() if
|
|
|
|
+// underlining is not needed.
|
2021-04-21 00:52:34 +02:00
|
|
|
+gfx::Range StripAcceleratorChars(int flags, std::u16string* text) {
|
2017-02-23 21:24:45 +01:00
|
|
|
+ if (flags & (gfx::Canvas::SHOW_PREFIX | gfx::Canvas::HIDE_PREFIX)) {
|
|
|
|
+ int char_pos = -1;
|
|
|
|
+ int char_span = 0;
|
2021-01-28 00:13:12 +01:00
|
|
|
+ *text = gfx::LocateAndRemoveAcceleratorChar(*text, &char_pos, &char_span);
|
2022-08-23 03:37:40 +02:00
|
|
|
+ if ((flags & gfx::Canvas::SHOW_PREFIX) && char_pos != -1) {
|
|
|
|
+ return gfx::Range(static_cast<size_t>(char_pos),
|
|
|
|
+ static_cast<size_t>(char_pos + char_span));
|
|
|
|
+ }
|
2017-02-23 21:24:45 +01:00
|
|
|
+ }
|
2019-09-04 17:13:32 +02:00
|
|
|
+ return gfx::Range::InvalidRange();
|
2017-02-23 21:24:45 +01:00
|
|
|
+}
|
2019-01-17 10:56:52 +01:00
|
|
|
+
|
2019-09-04 17:13:32 +02:00
|
|
|
} // namespace
|
2019-01-17 10:56:52 +01:00
|
|
|
|
2019-09-04 17:13:32 +02:00
|
|
|
namespace views {
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -458,6 +475,15 @@ void Label::SetElideBehavior(gfx::ElideBehavior elide_behavior) {
|
2021-04-21 00:52:34 +02:00
|
|
|
OnPropertyChanged(&elide_behavior_, kPropertyEffectsPreferredSizeChanged);
|
2017-02-23 21:24:45 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+void Label::SetDrawStringsFlags(int flags) {
|
|
|
|
+ if (draw_strings_flags_ == flags)
|
|
|
|
+ return;
|
|
|
|
+ draw_strings_flags_ = flags;
|
2018-02-15 01:12:09 +01:00
|
|
|
+ full_text_->SetDrawStringsFlags(draw_strings_flags_);
|
2020-08-29 00:39:23 +02:00
|
|
|
+ OnPropertyChanged(&full_text_ + kLabelDrawStringsFlags,
|
|
|
|
+ kPropertyEffectsPreferredSizeChanged);
|
2017-02-23 21:24:45 +01:00
|
|
|
+}
|
|
|
|
+
|
2021-04-21 00:52:34 +02:00
|
|
|
std::u16string Label::GetTooltipText() const {
|
|
|
|
return tooltip_text_;
|
|
|
|
}
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -763,6 +789,16 @@ std::unique_ptr<gfx::RenderText> Label::CreateRenderText() const {
|
2021-01-28 00:13:12 +01:00
|
|
|
render_text->SelectRange(stored_selection_range_);
|
|
|
|
}
|
|
|
|
|
2017-02-23 21:24:45 +01:00
|
|
|
+ if (draw_strings_flags_ != 0) {
|
2021-04-21 00:52:34 +02:00
|
|
|
+ auto text_str = GetText();
|
2017-02-23 21:24:45 +01:00
|
|
|
+ gfx::Range range = StripAcceleratorChars(draw_strings_flags_, &text_str);
|
|
|
|
+ render_text->SetText(text_str);
|
|
|
|
+ if (range.IsValid()) {
|
|
|
|
+ render_text->SetDisplayRect(bounds());
|
2019-02-01 20:40:18 +01:00
|
|
|
+ render_text->ApplyStyle(gfx::TEXT_STYLE_UNDERLINE, true, range);
|
2017-02-23 21:24:45 +01:00
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+
|
2021-01-28 00:13:12 +01:00
|
|
|
return render_text;
|
|
|
|
}
|
|
|
|
|
2017-02-23 21:24:45 +01:00
|
|
|
diff --git ui/views/controls/label.h ui/views/controls/label.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index 03c33a87c8ee2..3cd41c96ab504 100644
|
2017-02-23 21:24:45 +01:00
|
|
|
--- ui/views/controls/label.h
|
|
|
|
+++ ui/views/controls/label.h
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -240,6 +240,10 @@ class VIEWS_EXPORT Label : public View,
|
2019-09-04 17:13:32 +02:00
|
|
|
gfx::ElideBehavior GetElideBehavior() const;
|
2017-02-23 21:24:45 +01:00
|
|
|
void SetElideBehavior(gfx::ElideBehavior elide_behavior);
|
|
|
|
|
|
|
|
+ // Get or set the flags that control display of accelerator characters.
|
|
|
|
+ void SetDrawStringsFlags(int flags);
|
2019-09-04 17:13:32 +02:00
|
|
|
+ int GetDrawStringsFlags() const { return draw_strings_flags_; }
|
2017-02-23 21:24:45 +01:00
|
|
|
+
|
2019-09-04 17:13:32 +02:00
|
|
|
// Gets/Sets the tooltip text. Default behavior for a label (single-line) is
|
|
|
|
// to show the full text if it is wider than its bounds. Calling this
|
|
|
|
// overrides the default behavior and lets you set a custom tooltip. To
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -500,6 +504,7 @@ class VIEWS_EXPORT Label : public View,
|
2020-03-30 22:13:42 +02:00
|
|
|
int max_width_ = 0;
|
2021-03-04 23:36:57 +01:00
|
|
|
// This is used in single-line mode.
|
|
|
|
int max_width_single_line_ = 0;
|
2017-02-23 21:24:45 +01:00
|
|
|
+ int draw_strings_flags_ = 0;
|
|
|
|
|
2018-03-20 21:15:08 +01:00
|
|
|
std::unique_ptr<SelectionController> selection_controller_;
|
|
|
|
|
2017-02-22 19:05:27 +01:00
|
|
|
diff --git ui/views/controls/menu/menu_controller.cc ui/views/controls/menu/menu_controller.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index 9752106bd171b..3a9b02408373d 100644
|
2017-02-22 19:05:27 +01:00
|
|
|
--- ui/views/controls/menu/menu_controller.cc
|
|
|
|
+++ ui/views/controls/menu/menu_controller.cc
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -471,7 +471,8 @@ void MenuController::Run(Widget* parent,
|
2022-05-13 13:38:41 +02:00
|
|
|
MenuAnchorPosition position,
|
|
|
|
bool context_menu,
|
|
|
|
bool is_nested_drag,
|
|
|
|
- gfx::NativeView native_view_for_gestures) {
|
|
|
|
+ gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget) {
|
|
|
|
exit_type_ = ExitType::kNone;
|
|
|
|
possible_drag_ = false;
|
|
|
|
drag_in_progress_ = false;
|
2023-01-30 18:43:54 +01:00
|
|
|
@@ -518,6 +519,7 @@ void MenuController::Run(Widget* parent,
|
2022-05-13 13:38:41 +02:00
|
|
|
owner_->AddObserver(this);
|
|
|
|
|
|
|
|
native_view_for_gestures_ = native_view_for_gestures;
|
|
|
|
+ parent_widget_ = parent_widget;
|
|
|
|
|
|
|
|
// Only create a MenuPreTargetHandler for non-nested menus. Nested menus
|
|
|
|
// will use the existing one.
|
2023-02-27 19:52:38 +01:00
|
|
|
@@ -2196,6 +2198,7 @@ void MenuController::OpenMenuImpl(MenuItemView* item, bool show) {
|
2022-05-13 13:38:41 +02:00
|
|
|
params.do_capture = do_capture;
|
|
|
|
params.native_view_for_gestures = native_view_for_gestures_;
|
|
|
|
params.owned_window_anchor = anchor;
|
|
|
|
+ params.parent_widget = parent_widget_;
|
|
|
|
if (item->GetParentMenuItem()) {
|
2023-04-04 20:00:13 +02:00
|
|
|
params.context = item->GetWidget();
|
|
|
|
// (crbug.com/1414232) The item to be open is a submenu. Make sure
|
|
|
|
@@ -2900,8 +2903,13 @@ MenuItemView* MenuController::FindInitialSelectableMenuItem(
|
2017-02-22 19:05:27 +01:00
|
|
|
|
|
|
|
void MenuController::OpenSubmenuChangeSelectionIfCan() {
|
|
|
|
MenuItemView* item = pending_state_.item;
|
2019-07-16 19:59:21 +02:00
|
|
|
- if (!item->HasSubmenu() || !item->GetEnabled())
|
|
|
|
+ if (!item->HasSubmenu() || !item->GetEnabled() || !item->GetParentMenuItem()) {
|
2017-02-22 19:05:27 +01:00
|
|
|
+ MenuItemView* submenu_item =
|
|
|
|
+ item->GetParentMenuItem() ? item->GetParentMenuItem() : item;
|
|
|
|
+ submenu_item->GetDelegate()->OnUnhandledOpenSubmenu(submenu_item,
|
|
|
|
+ base::i18n::IsRTL());
|
|
|
|
return;
|
|
|
|
+ }
|
2023-04-04 20:00:13 +02:00
|
|
|
|
|
|
|
// Show the sub-menu.
|
|
|
|
SetSelection(item, SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
|
|
|
|
@@ -2921,8 +2929,10 @@ void MenuController::OpenSubmenuChangeSelectionIfCan() {
|
2017-02-22 19:05:27 +01:00
|
|
|
void MenuController::CloseSubmenu() {
|
|
|
|
MenuItemView* item = state_.item;
|
|
|
|
DCHECK(item);
|
|
|
|
- if (!item->GetParentMenuItem())
|
|
|
|
+ if (!item->GetParentMenuItem()) {
|
|
|
|
+ item->GetDelegate()->OnUnhandledCloseSubmenu(item, base::i18n::IsRTL());
|
|
|
|
return;
|
|
|
|
+ }
|
2017-07-27 01:19:27 +02:00
|
|
|
if (item->SubmenuIsShowing())
|
2017-02-22 19:05:27 +01:00
|
|
|
SetSelection(item, SELECTION_UPDATE_IMMEDIATELY);
|
|
|
|
else if (item->GetParentMenuItem()->GetParentMenuItem())
|
2022-05-13 13:38:41 +02:00
|
|
|
diff --git ui/views/controls/menu/menu_controller.h ui/views/controls/menu/menu_controller.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index 2dd7c64ce4328..c456df19ddb53 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_controller.h
|
|
|
|
+++ ui/views/controls/menu/menu_controller.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -113,7 +113,9 @@ class VIEWS_EXPORT MenuController
|
2022-05-13 13:38:41 +02:00
|
|
|
MenuAnchorPosition position,
|
|
|
|
bool context_menu,
|
|
|
|
bool is_nested_drag,
|
|
|
|
- gfx::NativeView native_view_for_gestures = nullptr);
|
|
|
|
+ gfx::NativeView native_view_for_gestures = nullptr,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget =
|
|
|
|
+ gfx::kNullAcceleratedWidget);
|
|
|
|
|
|
|
|
bool for_drop() const { return for_drop_; }
|
|
|
|
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -724,6 +726,8 @@ class VIEWS_EXPORT MenuController
|
2022-05-13 13:38:41 +02:00
|
|
|
// RunType::SEND_GESTURE_EVENTS_TO_OWNER is set.
|
|
|
|
gfx::NativeView native_view_for_gestures_ = nullptr;
|
|
|
|
|
|
|
|
+ gfx::AcceleratedWidget parent_widget_ = gfx::kNullAcceleratedWidget;
|
|
|
|
+
|
|
|
|
// Indicates a possible drag operation.
|
|
|
|
bool possible_drag_ = false;
|
|
|
|
|
2017-02-22 19:05:27 +01:00
|
|
|
diff --git ui/views/controls/menu/menu_delegate.h ui/views/controls/menu/menu_delegate.h
|
2022-09-26 21:30:45 +02:00
|
|
|
index b8fa1c116ebcd..015f15ed72385 100644
|
2017-02-22 19:05:27 +01:00
|
|
|
--- ui/views/controls/menu/menu_delegate.h
|
|
|
|
+++ ui/views/controls/menu/menu_delegate.h
|
2021-08-20 01:40:49 +02:00
|
|
|
@@ -73,6 +73,22 @@ class VIEWS_EXPORT MenuDelegate {
|
|
|
|
virtual const gfx::FontList* GetLabelFontList(int id) const;
|
|
|
|
virtual absl::optional<SkColor> GetLabelColor(int id) const;
|
2017-05-31 17:33:30 +02:00
|
|
|
|
2017-03-03 23:37:23 +01:00
|
|
|
+ // Override the text color of a given menu item dependent on the |command_id|
|
|
|
|
+ // and its |is_hovered| state. |is_minor| will be true for accelerator text.
|
|
|
|
+ // Returns true if it chooses to override the color.
|
|
|
|
+ virtual bool GetTextColor(int command_id,
|
|
|
|
+ bool is_minor,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const { return false; }
|
|
|
|
+
|
|
|
|
+ // Override the background color of a given menu item dependent on the
|
2017-02-25 06:03:31 +01:00
|
|
|
+ // |command_id| and its |is_hovered| state. Returns true if it chooses to
|
|
|
|
+ // override the color.
|
2017-03-03 23:37:23 +01:00
|
|
|
+ virtual bool GetBackgroundColor(int command_id,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const
|
|
|
|
+ { return false; }
|
2017-05-31 17:33:30 +02:00
|
|
|
+
|
2017-03-03 23:37:23 +01:00
|
|
|
// The tooltip shown for the menu item. This is invoked when the user
|
|
|
|
// hovers over the item, and no tooltip text has been set for that item.
|
2021-04-21 00:52:34 +02:00
|
|
|
virtual std::u16string GetTooltipText(int id,
|
2022-02-21 23:23:40 +01:00
|
|
|
@@ -201,6 +217,11 @@ class VIEWS_EXPORT MenuDelegate {
|
2017-02-22 19:05:27 +01:00
|
|
|
bool* has_mnemonics,
|
|
|
|
MenuButton** button);
|
|
|
|
|
|
|
|
+ // Called on unhandled open/close submenu keyboard commands. |is_rtl| will be
|
|
|
|
+ // true if the menu is displaying a right-to-left language.
|
|
|
|
+ virtual void OnUnhandledOpenSubmenu(MenuItemView* menu, bool is_rtl) {}
|
|
|
|
+ virtual void OnUnhandledCloseSubmenu(MenuItemView* menu, bool is_rtl) {}
|
|
|
|
+
|
|
|
|
// Returns the max width menus can grow to be.
|
|
|
|
virtual int GetMaxWidthForMenu(MenuItemView* menu);
|
|
|
|
|
2022-05-13 13:38:41 +02:00
|
|
|
diff --git ui/views/controls/menu/menu_host.cc ui/views/controls/menu/menu_host.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index d246468d9510b..baf6a250bca8d 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_host.cc
|
|
|
|
+++ ui/views/controls/menu/menu_host.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -143,6 +143,8 @@ void MenuHost::InitMenuHost(const InitParams& init_params) {
|
2022-05-13 13:38:41 +02:00
|
|
|
: gfx::kNullNativeWindow;
|
|
|
|
params.bounds = init_params.bounds;
|
|
|
|
|
|
|
|
+ params.parent_widget = init_params.parent_widget;
|
|
|
|
+
|
|
|
|
#if defined(USE_AURA)
|
|
|
|
// TODO(msisov): remove kMenutype once positioning of anchored windows
|
|
|
|
// finally migrates to a new path.
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -154,7 +156,8 @@ void MenuHost::InitMenuHost(const InitParams& init_params) {
|
2022-05-13 13:38:41 +02:00
|
|
|
// If MenuHost has no parent widget, it needs to be marked
|
|
|
|
// Activatable, so that calling Show in ShowMenuHost will
|
|
|
|
// get keyboard focus.
|
|
|
|
- if (init_params.parent == nullptr)
|
|
|
|
+ if (init_params.parent == nullptr &&
|
|
|
|
+ init_params.parent_widget == gfx::kNullAcceleratedWidget)
|
|
|
|
params.activatable = Widget::InitParams::Activatable::kYes;
|
|
|
|
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
|
|
diff --git ui/views/controls/menu/menu_host.h ui/views/controls/menu/menu_host.h
|
2023-01-03 00:34:43 +01:00
|
|
|
index 67cdb883886f8..4ca7d632ad7f9 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_host.h
|
|
|
|
+++ ui/views/controls/menu/menu_host.h
|
2022-10-17 19:27:40 +02:00
|
|
|
@@ -55,6 +55,8 @@ class MenuHost : public Widget, public WidgetObserver {
|
2022-05-13 13:38:41 +02:00
|
|
|
// Additional information that helps to position anchored windows in such
|
|
|
|
// backends as Wayland.
|
|
|
|
ui::OwnedWindowAnchor owned_window_anchor;
|
|
|
|
+
|
|
|
|
+ gfx::AcceleratedWidget parent_widget = gfx::kNullAcceleratedWidget;
|
|
|
|
};
|
|
|
|
|
|
|
|
explicit MenuHost(SubmenuView* submenu);
|
2017-02-25 06:03:31 +01:00
|
|
|
diff --git ui/views/controls/menu/menu_item_view.cc ui/views/controls/menu/menu_item_view.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index 946028ff36e25..7d63a6ba799d5 100644
|
2017-02-25 06:03:31 +01:00
|
|
|
--- ui/views/controls/menu/menu_item_view.cc
|
|
|
|
+++ ui/views/controls/menu/menu_item_view.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -1109,6 +1109,15 @@ void MenuItemView::PaintBackground(gfx::Canvas* canvas,
|
2018-11-30 23:21:07 +01:00
|
|
|
spilling_rect.set_y(spilling_rect.y() - corner_radius_);
|
|
|
|
spilling_rect.set_height(spilling_rect.height() + corner_radius_);
|
|
|
|
canvas->DrawRoundRect(spilling_rect, corner_radius_, flags);
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ MenuDelegate *delegate = GetDelegate();
|
2017-03-03 23:37:23 +01:00
|
|
|
+ SkColor override_color;
|
|
|
|
+ if (delegate && delegate->GetBackgroundColor(GetCommand(),
|
2021-10-19 00:17:16 +02:00
|
|
|
+ paint_as_selected,
|
2017-03-03 23:37:23 +01:00
|
|
|
+ &override_color)) {
|
|
|
|
+ canvas->DrawColor(override_color);
|
2021-10-19 00:17:16 +02:00
|
|
|
} else if (paint_as_selected) {
|
2018-11-30 23:21:07 +01:00
|
|
|
gfx::Rect item_bounds = GetLocalBounds();
|
2020-03-04 01:29:39 +01:00
|
|
|
if (type_ == Type::kActionableSubMenu) {
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -1175,6 +1184,13 @@ void MenuItemView::PaintMinorIconAndText(gfx::Canvas* canvas, SkColor color) {
|
2018-09-04 11:43:21 +02:00
|
|
|
}
|
|
|
|
|
2021-10-19 00:17:16 +02:00
|
|
|
SkColor MenuItemView::GetTextColor(bool minor, bool paint_as_selected) const {
|
2017-02-25 06:03:31 +01:00
|
|
|
+ SkColor text_color;
|
2017-03-03 23:37:23 +01:00
|
|
|
+ const MenuDelegate *delegate = GetDelegate();
|
2021-10-19 00:17:16 +02:00
|
|
|
+ if (delegate && delegate->GetTextColor(GetCommand(), minor, paint_as_selected,
|
2017-03-03 23:37:23 +01:00
|
|
|
+ &text_color)) {
|
|
|
|
+ return text_color;
|
2017-02-25 06:03:31 +01:00
|
|
|
+ }
|
|
|
|
+
|
2023-04-04 20:00:13 +02:00
|
|
|
// Use a custom color if provided by the controller. If the item is selected,
|
|
|
|
// use the default color.
|
|
|
|
if (!paint_as_selected && foreground_color_id_.has_value()) {
|
2017-02-22 19:05:27 +01:00
|
|
|
diff --git ui/views/controls/menu/menu_model_adapter.cc ui/views/controls/menu/menu_model_adapter.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index e826d42492872..2ade4b2f44df5 100644
|
2017-02-22 19:05:27 +01:00
|
|
|
--- ui/views/controls/menu/menu_model_adapter.cc
|
|
|
|
+++ ui/views/controls/menu/menu_model_adapter.cc
|
2022-08-23 03:37:40 +02:00
|
|
|
@@ -4,6 +4,7 @@
|
|
|
|
|
|
|
|
#include "ui/views/controls/menu/menu_model_adapter.h"
|
|
|
|
|
|
|
|
+#include <limits>
|
|
|
|
#include <list>
|
|
|
|
#include <memory>
|
|
|
|
#include <utility>
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -221,6 +222,76 @@ bool MenuModelAdapter::IsItemChecked(int id) const {
|
2023-02-27 19:52:38 +01:00
|
|
|
return model->IsItemCheckedAt(index);
|
2017-02-22 19:05:27 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+MenuItemView* MenuModelAdapter::GetSiblingMenu(MenuItemView* menu,
|
|
|
|
+ const gfx::Point& screen_point,
|
|
|
|
+ MenuAnchorPosition* anchor,
|
|
|
|
+ bool* has_mnemonics,
|
|
|
|
+ MenuButton** button) {
|
|
|
|
+ // Look up the menu model for this menu.
|
|
|
|
+ const std::map<MenuItemView*, ui::MenuModel*>::const_iterator map_iterator =
|
|
|
|
+ menu_map_.find(menu);
|
|
|
|
+ if (map_iterator != menu_map_.end()) {
|
|
|
|
+ map_iterator->second->MouseOutsideMenu(screen_point);
|
|
|
|
+ return nullptr;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ NOTREACHED();
|
|
|
|
+ return nullptr;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+void MenuModelAdapter::OnUnhandledOpenSubmenu(MenuItemView* menu,
|
|
|
|
+ bool is_rtl) {
|
|
|
|
+ // Look up the menu model for this menu.
|
|
|
|
+ const std::map<MenuItemView*, ui::MenuModel*>::const_iterator map_iterator =
|
|
|
|
+ menu_map_.find(menu);
|
|
|
|
+ if (map_iterator != menu_map_.end()) {
|
|
|
|
+ map_iterator->second->UnhandledOpenSubmenu(is_rtl);
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ NOTREACHED();
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+void MenuModelAdapter::OnUnhandledCloseSubmenu(MenuItemView* menu,
|
|
|
|
+ bool is_rtl) {
|
|
|
|
+ // Look up the menu model for this menu.
|
|
|
|
+ const std::map<MenuItemView*, ui::MenuModel*>::const_iterator map_iterator =
|
|
|
|
+ menu_map_.find(menu);
|
|
|
|
+ if (map_iterator != menu_map_.end()) {
|
|
|
|
+ map_iterator->second->UnhandledCloseSubmenu(is_rtl);
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ NOTREACHED();
|
|
|
|
+}
|
2017-02-25 06:03:31 +01:00
|
|
|
+
|
2017-03-03 23:37:23 +01:00
|
|
|
+bool MenuModelAdapter::GetTextColor(int command_id,
|
|
|
|
+ bool is_minor,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const {
|
2017-02-25 06:03:31 +01:00
|
|
|
+ ui::MenuModel* model = menu_model_;
|
2022-07-25 19:49:32 +02:00
|
|
|
+ size_t index = 0;
|
2017-02-25 06:03:31 +01:00
|
|
|
+ if (ui::MenuModel::GetModelAndIndexForCommandId(command_id, &model, &index))
|
2017-03-03 23:37:23 +01:00
|
|
|
+ return model->GetTextColor(index, is_minor, is_hovered, override_color);
|
2017-02-25 06:03:31 +01:00
|
|
|
+
|
2022-08-23 03:37:40 +02:00
|
|
|
+ // Return the default color.
|
|
|
|
+ return menu_model_->GetBackgroundColor(std::numeric_limits<size_t>::max(),
|
|
|
|
+ is_hovered, override_color);
|
2017-02-25 06:03:31 +01:00
|
|
|
+}
|
|
|
|
+
|
|
|
|
+bool MenuModelAdapter::GetBackgroundColor(int command_id,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const {
|
|
|
|
+ ui::MenuModel* model = menu_model_;
|
2022-07-25 19:49:32 +02:00
|
|
|
+ size_t index = 0;
|
2017-02-25 06:03:31 +01:00
|
|
|
+ if (ui::MenuModel::GetModelAndIndexForCommandId(command_id, &model, &index))
|
|
|
|
+ return model->GetBackgroundColor(index, is_hovered, override_color);
|
|
|
|
+
|
2022-08-23 03:37:40 +02:00
|
|
|
+ // Return the default color.
|
|
|
|
+ return menu_model_->GetBackgroundColor(std::numeric_limits<size_t>::max(),
|
|
|
|
+ is_hovered, override_color);
|
2017-02-25 06:03:31 +01:00
|
|
|
+}
|
2017-02-22 19:05:27 +01:00
|
|
|
+
|
|
|
|
void MenuModelAdapter::WillShowMenu(MenuItemView* menu) {
|
|
|
|
// Look up the menu model for this menu.
|
|
|
|
const std::map<MenuItemView*, ui::MenuModel*>::const_iterator map_iterator =
|
|
|
|
diff --git ui/views/controls/menu/menu_model_adapter.h ui/views/controls/menu/menu_model_adapter.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index eaae7fd7a3607..bfc69d7fc86e1 100644
|
2017-02-22 19:05:27 +01:00
|
|
|
--- ui/views/controls/menu/menu_model_adapter.h
|
|
|
|
+++ ui/views/controls/menu/menu_model_adapter.h
|
2021-10-19 00:17:16 +02:00
|
|
|
@@ -88,6 +88,20 @@ class VIEWS_EXPORT MenuModelAdapter : public MenuDelegate,
|
2019-02-01 17:42:40 +01:00
|
|
|
bool IsCommandEnabled(int id) const override;
|
2017-02-22 19:05:27 +01:00
|
|
|
bool IsCommandVisible(int id) const override;
|
|
|
|
bool IsItemChecked(int id) const override;
|
|
|
|
+ MenuItemView* GetSiblingMenu(MenuItemView* menu,
|
|
|
|
+ const gfx::Point& screen_point,
|
|
|
|
+ MenuAnchorPosition* anchor,
|
|
|
|
+ bool* has_mnemonics,
|
|
|
|
+ MenuButton** button) override;
|
|
|
|
+ void OnUnhandledOpenSubmenu(MenuItemView* menu, bool is_rtl) override;
|
|
|
|
+ void OnUnhandledCloseSubmenu(MenuItemView* menu, bool is_rtl) override;
|
2017-03-03 23:37:23 +01:00
|
|
|
+ bool GetTextColor(int command_id,
|
|
|
|
+ bool is_minor,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const override;
|
2017-02-25 06:03:31 +01:00
|
|
|
+ bool GetBackgroundColor(int command_id,
|
|
|
|
+ bool is_hovered,
|
|
|
|
+ SkColor* override_color) const override;
|
2017-02-22 19:05:27 +01:00
|
|
|
void WillShowMenu(MenuItemView* menu) override;
|
|
|
|
void WillHideMenu(MenuItemView* menu) override;
|
2017-05-31 17:33:30 +02:00
|
|
|
void OnMenuClosed(MenuItemView* menu) override;
|
2022-05-13 13:38:41 +02:00
|
|
|
diff --git ui/views/controls/menu/menu_runner.cc ui/views/controls/menu/menu_runner.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
index adb22671b94fa..59cc421e82e1b 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner.cc
|
|
|
|
+++ ui/views/controls/menu/menu_runner.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -36,6 +36,7 @@ void MenuRunner::RunMenuAt(Widget* parent,
|
2022-05-13 13:38:41 +02:00
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
ui::MenuSourceType source_type,
|
2022-11-15 18:50:53 +01:00
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners) {
|
2022-05-13 13:38:41 +02:00
|
|
|
// Do not attempt to show the menu if the application is currently shutting
|
|
|
|
// down. MenuDelegate::OnMenuClosed would not be called.
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -82,7 +83,7 @@ void MenuRunner::RunMenuAt(Widget* parent,
|
2022-05-13 13:38:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
impl_->RunMenuAt(parent, button_controller, bounds, anchor, run_types_,
|
2022-11-15 18:50:53 +01:00
|
|
|
- native_view_for_gestures, corners);
|
|
|
|
+ native_view_for_gestures, parent_widget, corners);
|
2022-05-13 13:38:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
bool MenuRunner::IsRunning() const {
|
|
|
|
diff --git ui/views/controls/menu/menu_runner.h ui/views/controls/menu/menu_runner.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index 9d51c2e38b893..7fbe67198a1e5 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner.h
|
|
|
|
+++ ui/views/controls/menu/menu_runner.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -152,6 +152,8 @@ class VIEWS_EXPORT MenuRunner {
|
2022-05-13 13:38:41 +02:00
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
ui::MenuSourceType source_type,
|
2022-11-15 18:50:53 +01:00
|
|
|
gfx::NativeView native_view_for_gestures = nullptr,
|
2022-05-13 13:38:41 +02:00
|
|
|
+ gfx::AcceleratedWidget parent_widget =
|
2022-11-15 18:50:53 +01:00
|
|
|
+ gfx::kNullAcceleratedWidget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners = absl::nullopt);
|
2022-05-13 13:38:41 +02:00
|
|
|
|
|
|
|
// Returns true if we're in a nested run loop running the menu.
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl.cc ui/views/controls/menu/menu_runner_impl.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
index c2513d2889a2b..5dfef1af49685 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl.cc
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -117,6 +117,7 @@ void MenuRunnerImpl::RunMenuAt(Widget* parent,
|
2022-05-13 13:38:41 +02:00
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t run_types,
|
2022-11-15 18:50:53 +01:00
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners) {
|
2022-05-13 13:38:41 +02:00
|
|
|
closing_event_time_ = base::TimeTicks();
|
|
|
|
if (running_) {
|
|
|
|
@@ -184,7 +185,7 @@ void MenuRunnerImpl::RunMenuAt(Widget* parent,
|
|
|
|
controller->Run(parent, button_controller, menu_, bounds, anchor,
|
|
|
|
(run_types & MenuRunner::CONTEXT_MENU) != 0,
|
|
|
|
(run_types & MenuRunner::NESTED_DRAG) != 0,
|
|
|
|
- native_view_for_gestures);
|
|
|
|
+ native_view_for_gestures, parent_widget);
|
|
|
|
}
|
|
|
|
|
|
|
|
void MenuRunnerImpl::Cancel() {
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl.h ui/views/controls/menu/menu_runner_impl.h
|
2022-11-15 18:50:53 +01:00
|
|
|
index 4d2909b5094ab..245e1a24dd810 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl.h
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -53,6 +53,7 @@ class VIEWS_EXPORT MenuRunnerImpl : public MenuRunnerImplInterface,
|
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t run_types,
|
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners = absl::nullopt) override;
|
2022-05-13 13:38:41 +02:00
|
|
|
void Cancel() override;
|
|
|
|
base::TimeTicks GetClosingEventTime() const override;
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl_adapter.cc ui/views/controls/menu/menu_runner_impl_adapter.cc
|
2022-11-15 18:50:53 +01:00
|
|
|
index b6c680063889b..a1efa677a43a5 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl_adapter.cc
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl_adapter.cc
|
|
|
|
@@ -34,9 +34,10 @@ void MenuRunnerImplAdapter::RunMenuAt(
|
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t types,
|
2022-11-15 18:50:53 +01:00
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners) {
|
2022-05-13 13:38:41 +02:00
|
|
|
impl_->RunMenuAt(parent, button_controller, bounds, anchor, types,
|
|
|
|
- native_view_for_gestures);
|
|
|
|
+ native_view_for_gestures, parent_widget);
|
|
|
|
}
|
|
|
|
|
|
|
|
void MenuRunnerImplAdapter::Cancel() {
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl_adapter.h ui/views/controls/menu/menu_runner_impl_adapter.h
|
2022-11-15 18:50:53 +01:00
|
|
|
index e6587d2208a13..c2c72f7edb89c 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl_adapter.h
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl_adapter.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -44,6 +44,7 @@ class VIEWS_EXPORT MenuRunnerImplAdapter : public MenuRunnerImplInterface {
|
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t types,
|
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners = absl::nullopt) override;
|
2022-05-13 13:38:41 +02:00
|
|
|
void Cancel() override;
|
|
|
|
base::TimeTicks GetClosingEventTime() const override;
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl_cocoa.h ui/views/controls/menu/menu_runner_impl_cocoa.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index 50291eb07440a..9716791a463aa 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl_cocoa.h
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl_cocoa.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -43,6 +43,7 @@ class VIEWS_EXPORT MenuRunnerImplCocoa : public MenuRunnerImplInterface {
|
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t run_types,
|
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners = absl::nullopt) override;
|
2022-05-13 13:38:41 +02:00
|
|
|
void Cancel() override;
|
|
|
|
base::TimeTicks GetClosingEventTime() const override;
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl_cocoa.mm ui/views/controls/menu/menu_runner_impl_cocoa.mm
|
2023-04-04 20:00:13 +02:00
|
|
|
index 46a50f5a808c3..689c7d3afb21c 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl_cocoa.mm
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl_cocoa.mm
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -193,6 +193,7 @@ void MenuRunnerImplCocoa::RunMenuAt(
|
2022-11-15 18:50:53 +01:00
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t run_types,
|
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget /*parent_widget*/,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners) {
|
2022-05-13 13:38:41 +02:00
|
|
|
DCHECK(!IsRunning());
|
|
|
|
DCHECK(parent);
|
|
|
|
diff --git ui/views/controls/menu/menu_runner_impl_interface.h ui/views/controls/menu/menu_runner_impl_interface.h
|
2023-01-30 18:43:54 +01:00
|
|
|
index cf696fbcf0714..5c48fd7410b88 100644
|
2022-05-13 13:38:41 +02:00
|
|
|
--- ui/views/controls/menu/menu_runner_impl_interface.h
|
|
|
|
+++ ui/views/controls/menu/menu_runner_impl_interface.h
|
2022-11-15 18:50:53 +01:00
|
|
|
@@ -46,6 +46,8 @@ class MenuRunnerImplInterface {
|
|
|
|
MenuAnchorPosition anchor,
|
|
|
|
int32_t run_types,
|
|
|
|
gfx::NativeView native_view_for_gestures,
|
|
|
|
+ gfx::AcceleratedWidget parent_widget =
|
|
|
|
+ gfx::kNullAcceleratedWidget,
|
|
|
|
absl::optional<gfx::RoundedCornersF> corners = absl::nullopt) = 0;
|
2022-05-13 13:38:41 +02:00
|
|
|
|
|
|
|
// Hides and cancels the menu.
|
2017-02-25 06:03:31 +01:00
|
|
|
diff --git ui/views/controls/menu/menu_scroll_view_container.cc ui/views/controls/menu/menu_scroll_view_container.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
index 629877961fe6b..d41bfca45103e 100644
|
2017-02-25 06:03:31 +01:00
|
|
|
--- ui/views/controls/menu/menu_scroll_view_container.cc
|
|
|
|
+++ ui/views/controls/menu/menu_scroll_view_container.cc
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -260,6 +260,11 @@ MenuScrollViewContainer::MenuScrollViewContainer(SubmenuView* content_view)
|
2022-04-27 21:24:24 +02:00
|
|
|
scroll_down_button_ = background_view_->AddChildView(
|
|
|
|
std::make_unique<MenuScrollButton>(content_view, false));
|
2017-02-25 06:03:31 +01:00
|
|
|
|
|
|
|
+ SkColor override_color;
|
|
|
|
+ MenuDelegate* delegate = content_view_->GetMenuItem()->GetDelegate();
|
|
|
|
+ if (delegate && delegate->GetBackgroundColor(-1, false, &override_color))
|
2017-07-27 01:19:27 +02:00
|
|
|
+ SetBackground(views::CreateSolidBackground(override_color));
|
2017-02-25 06:03:31 +01:00
|
|
|
+
|
|
|
|
arrow_ = BubbleBorderTypeFromAnchor(
|
|
|
|
content_view_->GetMenuItem()->GetMenuController()->GetAnchorPosition());
|
|
|
|
|
2022-06-17 15:28:55 +02:00
|
|
|
diff --git ui/views/test/ui_controls_factory_desktop_aura_ozone.cc ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
|
2023-02-27 19:52:38 +01:00
|
|
|
index 983f9390aa1f6..d6db1ea93e0ef 100644
|
2022-06-17 15:28:55 +02:00
|
|
|
--- ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
|
|
|
|
+++ ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
|
2023-02-27 19:52:38 +01:00
|
|
|
@@ -15,6 +15,7 @@
|
2023-01-30 18:43:54 +01:00
|
|
|
#include "base/task/single_thread_task_runner.h"
|
2022-06-17 15:28:55 +02:00
|
|
|
#include "build/build_config.h"
|
|
|
|
#include "build/chromeos_buildflags.h"
|
|
|
|
+#include "cef/libcef/features/features.h"
|
|
|
|
#include "ui/aura/client/screen_position_client.h"
|
|
|
|
#include "ui/aura/env.h"
|
|
|
|
#include "ui/aura/test/aura_test_utils.h"
|
2023-02-27 19:52:38 +01:00
|
|
|
@@ -172,9 +173,11 @@ bool SendMouseMoveNotifyWhenDone(int screen_x,
|
|
|
|
aura::test::QueryLatestMousePositionRequestInHost(host);
|
|
|
|
host->ConvertPixelsToDIP(&root_current_location);
|
2022-06-17 15:28:55 +02:00
|
|
|
|
|
|
|
+#if !BUILDFLAG(ENABLE_CEF)
|
2023-02-27 19:52:38 +01:00
|
|
|
auto* screen = views::test::TestDesktopScreenOzone::GetInstance();
|
|
|
|
DCHECK_EQ(screen, display::Screen::GetScreen());
|
|
|
|
screen->set_cursor_screen_point(gfx::Point(screen_x, screen_y));
|
2022-06-17 15:28:55 +02:00
|
|
|
+#endif
|
|
|
|
|
2022-08-23 03:37:40 +02:00
|
|
|
#if !BUILDFLAG(IS_CHROMEOS_LACROS)
|
2023-02-27 19:52:38 +01:00
|
|
|
if (root_location != root_current_location &&
|
2017-05-31 17:33:30 +02:00
|
|
|
diff --git ui/views/view.h ui/views/view.h
|
2023-04-04 20:00:13 +02:00
|
|
|
index d43db49340391..24b68b0d68eed 100644
|
2017-05-31 17:33:30 +02:00
|
|
|
--- ui/views/view.h
|
|
|
|
+++ ui/views/view.h
|
2022-10-17 19:27:40 +02:00
|
|
|
@@ -21,6 +21,7 @@
|
2021-12-16 23:35:54 +01:00
|
|
|
#include "base/memory/raw_ptr.h"
|
2022-04-21 20:58:48 +02:00
|
|
|
#include "base/observer_list.h"
|
2021-01-28 00:13:12 +01:00
|
|
|
#include "base/strings/string_piece.h"
|
2017-05-31 17:33:30 +02:00
|
|
|
+#include "base/supports_user_data.h"
|
|
|
|
#include "build/build_config.h"
|
2021-06-04 03:34:56 +02:00
|
|
|
#include "third_party/abseil-cpp/absl/types/optional.h"
|
2019-01-17 10:56:52 +01:00
|
|
|
#include "third_party/skia/include/core/SkPath.h"
|
2023-04-04 20:00:13 +02:00
|
|
|
@@ -286,7 +287,8 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
|
2020-03-30 22:13:42 +02:00
|
|
|
public ui::EventTarget,
|
2017-07-27 01:19:27 +02:00
|
|
|
public ui::EventHandler,
|
2019-06-05 16:15:45 +02:00
|
|
|
public ui::PropertyHandler,
|
2021-06-04 03:34:56 +02:00
|
|
|
- public ui::metadata::MetaDataProvider {
|
|
|
|
+ public ui::metadata::MetaDataProvider,
|
|
|
|
+ public base::SupportsUserData {
|
2017-05-31 17:33:30 +02:00
|
|
|
public:
|
|
|
|
using Views = std::vector<View*>;
|
2021-06-04 03:34:56 +02:00
|
|
|
|