2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/browser/browser_plugin/browser_plugin_guest.cc content/browser/browser_plugin/browser_plugin_guest.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
index 7b85e54..5afa575 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/browser_plugin/browser_plugin_guest.cc
|
|
|
|
+++ content/browser/browser_plugin/browser_plugin_guest.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -318,14 +318,20 @@ void BrowserPluginGuest::InitInternal(
|
2017-02-10 23:44:11 +01:00
|
|
|
static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
|
2015-07-24 02:06:56 +02:00
|
|
|
}
|
|
|
|
|
2017-02-10 23:44:11 +01:00
|
|
|
- if (owner_web_contents_ && new_view)
|
|
|
|
+ if (owner_web_contents_ && new_view) {
|
|
|
|
new_view->OnGuestDetached(owner_web_contents_->GetView());
|
|
|
|
+ if (delegate_)
|
|
|
|
+ delegate_->OnGuestDetached(owner_web_contents_->GetView());
|
|
|
|
+ }
|
2015-07-16 23:40:01 +02:00
|
|
|
|
|
|
|
// Once a BrowserPluginGuest has an embedder WebContents, it's considered to
|
|
|
|
// be attached.
|
|
|
|
owner_web_contents_ = owner_web_contents;
|
2017-02-10 23:44:11 +01:00
|
|
|
- if (new_view)
|
|
|
|
+ if (new_view) {
|
|
|
|
new_view->OnGuestAttached(owner_web_contents_->GetView());
|
|
|
|
+ if (delegate_)
|
|
|
|
+ delegate_->OnGuestAttached(owner_web_contents_->GetView());
|
|
|
|
+ }
|
2015-07-16 23:40:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
RendererPreferences* renderer_prefs =
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -800,7 +806,8 @@ void BrowserPluginGuest::OnWillAttachComplete(
|
2017-02-10 23:44:11 +01:00
|
|
|
static_cast<WebContentsViewGuest*>(GetWebContents()->GetView());
|
2015-11-10 21:18:16 +01:00
|
|
|
if (!web_contents()->GetRenderViewHost()->GetWidget()->GetView()) {
|
2017-02-10 23:44:11 +01:00
|
|
|
web_contents_view->CreateViewForWidget(
|
2015-11-10 21:18:16 +01:00
|
|
|
- web_contents()->GetRenderViewHost()->GetWidget(), true);
|
2017-02-10 23:44:11 +01:00
|
|
|
+ web_contents()->GetRenderViewHost()->GetWidget(),
|
|
|
|
+ embedder_web_contents->GetRenderViewHost()->GetWidget());
|
2015-11-10 21:18:16 +01:00
|
|
|
}
|
2015-07-16 23:40:01 +02:00
|
|
|
}
|
|
|
|
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/browser/frame_host/interstitial_page_impl.cc content/browser/frame_host/interstitial_page_impl.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
index 1a04a52..4cfe9aa 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/frame_host/interstitial_page_impl.cc
|
|
|
|
+++ content/browser/frame_host/interstitial_page_impl.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -594,7 +594,7 @@ WebContentsView* InterstitialPageImpl::CreateWebContentsView() {
|
2017-02-10 23:44:11 +01:00
|
|
|
WebContentsView* wcv =
|
|
|
|
static_cast<WebContentsImpl*>(web_contents())->GetView();
|
|
|
|
RenderWidgetHostViewBase* view =
|
|
|
|
- wcv->CreateViewForWidget(render_view_host_->GetWidget(), false);
|
|
|
|
+ wcv->CreateViewForWidget(render_view_host_->GetWidget(), nullptr);
|
|
|
|
RenderWidgetHostImpl::From(render_view_host_->GetWidget())->SetView(view);
|
2017-03-03 23:37:23 +01:00
|
|
|
render_view_host_->GetMainFrame()->AllowBindings(
|
|
|
|
BINDINGS_POLICY_DOM_AUTOMATION);
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/browser/web_contents/web_contents_view.h content/browser/web_contents/web_contents_view.h
|
|
|
|
index e4401f8..f2fdb9b 100644
|
|
|
|
--- content/browser/web_contents/web_contents_view.h
|
|
|
|
+++ content/browser/web_contents/web_contents_view.h
|
|
|
|
@@ -86,13 +86,9 @@ class WebContentsView {
|
|
|
|
// Sets up the View that holds the rendered web page, receives messages for
|
|
|
|
// it and contains page plugins. The host view should be sized to the current
|
|
|
|
// size of the WebContents.
|
|
|
|
- //
|
|
|
|
- // |is_guest_view_hack| is temporary hack and will be removed once
|
|
|
|
- // RenderWidgetHostViewGuest is not dependent on platform view.
|
|
|
|
- // TODO(lazyboy): Remove |is_guest_view_hack| once http://crbug.com/330264 is
|
|
|
|
- // fixed.
|
|
|
|
virtual RenderWidgetHostViewBase* CreateViewForWidget(
|
|
|
|
- RenderWidgetHost* render_widget_host, bool is_guest_view_hack) = 0;
|
|
|
|
+ RenderWidgetHost* render_widget_host,
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) = 0;
|
2015-07-16 23:40:01 +02:00
|
|
|
|
2017-02-10 23:44:11 +01:00
|
|
|
// Creates a new View that holds a popup and receives messages for it.
|
|
|
|
virtual RenderWidgetHostViewBase* CreateViewForPopupWidget(
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_aura.cc content/browser/web_contents/web_contents_view_aura.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
index 1bfef2c..7555040 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_aura.cc
|
|
|
|
+++ content/browser/web_contents/web_contents_view_aura.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -843,7 +843,8 @@ void WebContentsViewAura::CreateView(
|
2017-02-10 23:44:11 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
|
|
|
|
- RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
|
|
|
|
+ RenderWidgetHost* render_widget_host,
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) {
|
|
|
|
if (render_widget_host->GetView()) {
|
|
|
|
// During testing, the view will already be set up in most cases to the
|
|
|
|
// test view, so we don't want to clobber it with a real one. To verify that
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -855,6 +856,7 @@ RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
|
|
|
|
render_widget_host->GetView());
|
2017-02-10 23:44:11 +01:00
|
|
|
}
|
|
|
|
|
2017-03-03 23:37:23 +01:00
|
|
|
+ const bool is_guest_view_hack = !!embedder_render_widget_host;
|
2017-02-10 23:44:11 +01:00
|
|
|
RenderWidgetHostViewAura* view =
|
2017-03-03 23:37:23 +01:00
|
|
|
g_create_render_widget_host_view
|
|
|
|
? g_create_render_widget_host_view(render_widget_host,
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/browser/web_contents/web_contents_view_aura.h content/browser/web_contents/web_contents_view_aura.h
|
2017-03-03 23:37:23 +01:00
|
|
|
index ed3641c..f8816357 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_aura.h
|
|
|
|
+++ content/browser/web_contents/web_contents_view_aura.h
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -117,7 +117,7 @@ class CONTENT_EXPORT WebContentsViewAura
|
2017-02-10 23:44:11 +01:00
|
|
|
gfx::NativeView context) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForWidget(
|
|
|
|
RenderWidgetHost* render_widget_host,
|
|
|
|
- bool is_guest_view_hack) override;
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForPopupWidget(
|
|
|
|
RenderWidgetHost* render_widget_host) override;
|
|
|
|
void SetPageTitle(const base::string16& title) override;
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_child_frame.cc content/browser/web_contents/web_contents_view_child_frame.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
index 74a587a..9f02836 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_child_frame.cc
|
|
|
|
+++ content/browser/web_contents/web_contents_view_child_frame.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -94,7 +94,7 @@ void WebContentsViewChildFrame::CreateView(const gfx::Size& initial_size,
|
2015-07-16 23:40:01 +02:00
|
|
|
|
2017-02-10 23:44:11 +01:00
|
|
|
RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForWidget(
|
|
|
|
RenderWidgetHost* render_widget_host,
|
|
|
|
- bool is_guest_view_hack) {
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) {
|
|
|
|
return RenderWidgetHostViewChildFrame::Create(render_widget_host);
|
2015-07-16 23:40:01 +02:00
|
|
|
}
|
|
|
|
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/browser/web_contents/web_contents_view_child_frame.h content/browser/web_contents/web_contents_view_child_frame.h
|
|
|
|
index 86ce68b..fd21e5a 100644
|
|
|
|
--- content/browser/web_contents/web_contents_view_child_frame.h
|
|
|
|
+++ content/browser/web_contents/web_contents_view_child_frame.h
|
|
|
|
@@ -39,7 +39,7 @@ class WebContentsViewChildFrame : public WebContentsView,
|
|
|
|
gfx::NativeView context) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForWidget(
|
|
|
|
RenderWidgetHost* render_widget_host,
|
|
|
|
- bool is_guest_view_hack) override;
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForPopupWidget(
|
|
|
|
RenderWidgetHost* render_widget_host) override;
|
|
|
|
void SetPageTitle(const base::string16& title) override;
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_guest.cc content/browser/web_contents/web_contents_view_guest.cc
|
2017-03-03 23:37:23 +01:00
|
|
|
index a93bc37..18fed2e 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_guest.cc
|
|
|
|
+++ content/browser/web_contents/web_contents_view_guest.cc
|
|
|
|
@@ -72,6 +72,8 @@ void WebContentsViewGuest::GetScreenInfo(ScreenInfo* screen_info) const {
|
|
|
|
|
|
|
|
void WebContentsViewGuest::OnGuestAttached(WebContentsView* parent_view) {
|
|
|
|
#if defined(USE_AURA)
|
|
|
|
+ if (!platform_view_->GetNativeView())
|
|
|
|
+ return;
|
|
|
|
// In aura, ScreenPositionClient doesn't work properly if we do
|
|
|
|
// not have the native view associated with this WebContentsViewGuest in the
|
|
|
|
// view hierarchy. We add this view as embedder's child here.
|
|
|
|
@@ -83,6 +85,8 @@ void WebContentsViewGuest::OnGuestAttached(WebContentsView* parent_view) {
|
|
|
|
|
|
|
|
void WebContentsViewGuest::OnGuestDetached(WebContentsView* old_parent_view) {
|
|
|
|
#if defined(USE_AURA)
|
|
|
|
+ if (!platform_view_->GetNativeView())
|
|
|
|
+ return;
|
|
|
|
old_parent_view->GetNativeView()->RemoveChild(
|
|
|
|
platform_view_->GetNativeView());
|
|
|
|
#endif // defined(USE_AURA)
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -134,7 +138,8 @@ void WebContentsViewGuest::CreateView(const gfx::Size& initial_size,
|
2017-02-10 23:44:11 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForWidget(
|
|
|
|
- RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
|
|
|
|
+ RenderWidgetHost* render_widget_host,
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) {
|
|
|
|
if (render_widget_host->GetView()) {
|
|
|
|
// During testing, the view will already be set up in most cases to the
|
|
|
|
// test view, so we don't want to clobber it with a real one. To verify that
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -146,11 +151,19 @@ RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForWidget(
|
2017-02-10 23:44:11 +01:00
|
|
|
render_widget_host->GetView());
|
|
|
|
}
|
|
|
|
|
|
|
|
+ embedder_render_widget_host =
|
|
|
|
+ guest_->embedder_web_contents()->GetRenderViewHost()->GetWidget();
|
|
|
|
RenderWidgetHostViewBase* platform_widget =
|
|
|
|
- platform_view_->CreateViewForWidget(render_widget_host, true);
|
|
|
|
+ platform_view_->CreateViewForWidget(render_widget_host,
|
|
|
|
+ embedder_render_widget_host);
|
|
|
|
|
|
|
|
- return RenderWidgetHostViewGuest::Create(render_widget_host, guest_,
|
|
|
|
- platform_widget->GetWeakPtr());
|
|
|
|
+ RenderWidgetHostViewGuest* guest_view =
|
|
|
|
+ RenderWidgetHostViewGuest::Create(render_widget_host, guest_,
|
|
|
|
+ platform_widget->GetWeakPtr());
|
|
|
|
+ platform_widget->InitAsGuest(embedder_render_widget_host->GetView(),
|
|
|
|
+ guest_view);
|
2015-07-16 23:40:01 +02:00
|
|
|
+
|
2017-02-10 23:44:11 +01:00
|
|
|
+ return guest_view;
|
|
|
|
}
|
|
|
|
|
|
|
|
RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForPopupWidget(
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_guest.h content/browser/web_contents/web_contents_view_guest.h
|
|
|
|
index 0102d7e..b89d66c 100644
|
|
|
|
--- content/browser/web_contents/web_contents_view_guest.h
|
|
|
|
+++ content/browser/web_contents/web_contents_view_guest.h
|
|
|
|
@@ -58,7 +58,7 @@ class WebContentsViewGuest : public WebContentsView,
|
|
|
|
gfx::NativeView context) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForWidget(
|
|
|
|
RenderWidgetHost* render_widget_host,
|
|
|
|
- bool is_guest_view_hack) override;
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForPopupWidget(
|
|
|
|
RenderWidgetHost* render_widget_host) override;
|
|
|
|
void SetPageTitle(const base::string16& title) override;
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_mac.h content/browser/web_contents/web_contents_view_mac.h
|
2017-03-03 23:37:23 +01:00
|
|
|
index 4141b7f..921bc79 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_mac.h
|
|
|
|
+++ content/browser/web_contents/web_contents_view_mac.h
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -90,7 +90,7 @@ class WebContentsViewMac : public WebContentsView,
|
2017-02-10 23:44:11 +01:00
|
|
|
gfx::NativeView context) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForWidget(
|
|
|
|
RenderWidgetHost* render_widget_host,
|
|
|
|
- bool is_guest_view_hack) override;
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) override;
|
|
|
|
RenderWidgetHostViewBase* CreateViewForPopupWidget(
|
|
|
|
RenderWidgetHost* render_widget_host) override;
|
|
|
|
void SetPageTitle(const base::string16& title) override;
|
|
|
|
diff --git content/browser/web_contents/web_contents_view_mac.mm content/browser/web_contents/web_contents_view_mac.mm
|
2017-03-03 23:37:23 +01:00
|
|
|
index b236639..167f973 100644
|
2017-02-10 23:44:11 +01:00
|
|
|
--- content/browser/web_contents/web_contents_view_mac.mm
|
|
|
|
+++ content/browser/web_contents/web_contents_view_mac.mm
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -348,7 +348,8 @@ void WebContentsViewMac::CreateView(
|
2017-02-10 23:44:11 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
|
|
|
|
- RenderWidgetHost* render_widget_host, bool is_guest_view_hack) {
|
|
|
|
+ RenderWidgetHost* render_widget_host,
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host) {
|
|
|
|
if (render_widget_host->GetView()) {
|
|
|
|
// During testing, the view will already be set up in most cases to the
|
|
|
|
// test view, so we don't want to clobber it with a real one. To verify that
|
2017-03-03 23:37:23 +01:00
|
|
|
@@ -360,6 +361,7 @@ RenderWidgetHostViewBase* WebContentsViewMac::CreateViewForWidget(
|
|
|
|
render_widget_host->GetView());
|
2017-02-10 23:44:11 +01:00
|
|
|
}
|
|
|
|
|
2017-03-03 23:37:23 +01:00
|
|
|
+ const bool is_guest_view_hack = !!embedder_render_widget_host;
|
|
|
|
RenderWidgetHostViewMac* view =
|
|
|
|
g_create_render_widget_host_view
|
|
|
|
? g_create_render_widget_host_view(render_widget_host,
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git content/public/browser/browser_plugin_guest_delegate.h content/public/browser/browser_plugin_guest_delegate.h
|
|
|
|
index a32205c..49f3c35 100644
|
|
|
|
--- content/public/browser/browser_plugin_guest_delegate.h
|
|
|
|
+++ content/public/browser/browser_plugin_guest_delegate.h
|
2016-11-23 21:54:29 +01:00
|
|
|
@@ -19,6 +19,7 @@ namespace content {
|
2015-07-16 23:40:01 +02:00
|
|
|
class GuestHost;
|
2016-11-23 21:54:29 +01:00
|
|
|
class RenderWidgetHost;
|
|
|
|
class SiteInstance;
|
2015-07-16 23:40:01 +02:00
|
|
|
+class WebContentsView;
|
|
|
|
|
|
|
|
// Objects implement this interface to get notified about changes in the guest
|
|
|
|
// WebContents and to provide necessary functionality.
|
2017-02-10 23:44:11 +01:00
|
|
|
@@ -85,6 +86,10 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
|
2015-07-16 23:40:01 +02:00
|
|
|
// content module.
|
|
|
|
virtual void SetGuestHost(GuestHost* guest_host) {}
|
2015-10-09 17:23:12 +02:00
|
|
|
|
2015-07-16 23:40:01 +02:00
|
|
|
+ // Called when a guest is attached or detached.
|
2017-02-10 23:44:11 +01:00
|
|
|
+ virtual void OnGuestAttached(content::WebContentsView* parent_view) {}
|
|
|
|
+ virtual void OnGuestDetached(content::WebContentsView* parent_view) {}
|
2015-10-09 17:23:12 +02:00
|
|
|
+
|
|
|
|
// Sets the position of the context menu for the guest contents. The value
|
|
|
|
// reported from the guest renderer should be ignored. The reported value
|
2016-11-23 21:54:29 +01:00
|
|
|
// from the guest renderer is incorrect in situations where BrowserPlugin is
|
2017-02-10 23:44:11 +01:00
|
|
|
diff --git extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
|
|
|
|
index 6e59562..b517389 100644
|
|
|
|
--- extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
|
|
|
|
+++ extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
|
|
|
|
@@ -179,6 +179,8 @@ void MimeHandlerViewGuest::CreateWebContents(
|
|
|
|
WebContents::CreateParams params(browser_context(),
|
|
|
|
guest_site_instance.get());
|
|
|
|
params.guest_delegate = this;
|
|
|
|
+ if (delegate_)
|
|
|
|
+ delegate_->OverrideWebContentsCreateParams(¶ms);
|
|
|
|
callback.Run(WebContents::Create(params));
|
|
|
|
}
|
|
|
|
|
|
|
|
@@ -203,6 +205,18 @@ bool MimeHandlerViewGuest::ZoomPropagatesFromEmbedderToGuest() const {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
+void MimeHandlerViewGuest::OnGuestAttached(
|
|
|
|
+ content::WebContentsView* parent_view) {
|
|
|
|
+ if (delegate_)
|
|
|
|
+ delegate_->OnGuestAttached(parent_view);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+void MimeHandlerViewGuest::OnGuestDetached(
|
|
|
|
+ content::WebContentsView* parent_view) {
|
|
|
|
+ if (delegate_)
|
|
|
|
+ delegate_->OnGuestDetached(parent_view);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
WebContents* MimeHandlerViewGuest::OpenURLFromTab(
|
|
|
|
WebContents* source,
|
|
|
|
const content::OpenURLParams& params) {
|
|
|
|
diff --git extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
|
|
|
|
index d237318..3701bd2 100644
|
|
|
|
--- extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
|
|
|
|
+++ extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
|
|
|
|
@@ -83,6 +83,10 @@ class MimeHandlerViewGuest :
|
|
|
|
bool ShouldHandleFindRequestsForEmbedder() const final;
|
|
|
|
bool ZoomPropagatesFromEmbedderToGuest() const final;
|
|
|
|
|
|
|
|
+ // content::BrowserPluginGuestDelegate implementation
|
|
|
|
+ void OnGuestAttached(content::WebContentsView* parent_view) override;
|
|
|
|
+ void OnGuestDetached(content::WebContentsView* parent_view) override;
|
|
|
|
+
|
|
|
|
// WebContentsDelegate implementation.
|
|
|
|
content::WebContents* OpenURLFromTab(
|
|
|
|
content::WebContents* source,
|
|
|
|
diff --git extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h
|
|
|
|
index e065104d..ea3f547 100644
|
|
|
|
--- extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h
|
|
|
|
+++ extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h
|
|
|
|
@@ -6,9 +6,9 @@
|
|
|
|
#define EXTENSIONS_BROWSER_GUEST_VIEW_MIME_HANDLER_VIEW_MIME_HANDLER_VIEW_GUEST_DELEGATE_H_
|
|
|
|
|
|
|
|
#include "base/macros.h"
|
|
|
|
+#include "content/public/browser/web_contents.h"
|
|
|
|
|
|
|
|
namespace content {
|
|
|
|
-class WebContents;
|
|
|
|
struct ContextMenuParams;
|
|
|
|
} // namespace content
|
|
|
|
|
|
|
|
@@ -21,6 +21,14 @@ class MimeHandlerViewGuestDelegate {
|
|
|
|
public:
|
|
|
|
MimeHandlerViewGuestDelegate() {}
|
|
|
|
virtual ~MimeHandlerViewGuestDelegate() {}
|
|
|
|
+
|
|
|
|
+ // Provides an opportunity to supply a custom view implementation.
|
|
|
|
+ virtual void OverrideWebContentsCreateParams(
|
|
|
|
+ content::WebContents::CreateParams* params) {}
|
|
|
|
+
|
|
|
|
+ // Called when a guest is attached or detached.
|
|
|
|
+ virtual void OnGuestAttached(content::WebContentsView* parent_view) {}
|
|
|
|
+ virtual void OnGuestDetached(content::WebContentsView* parent_view) {}
|
|
|
|
|
|
|
|
// Handles context menu, or returns false if unhandled.
|
|
|
|
virtual bool HandleContextMenu(content::WebContents* web_contents,
|