bcarrella
/
YetAnotherCallBlocker
mirror of https://gitlab.com/xynngh/YetAnotherCallBlocker.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Some layout improvements 

Thanks to an anonymous contibutor
This commit is contained in:
xynngh 2020-05-10 19:36:45 +04:00
parent a007e95417
commit 23fb81bc8d
4 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/dummydomain/yetanothercallblocker/ReviewsActivity.java
View File

@ -10,7 +10,6 @@ import android.view.View;
import android.widget.TextView; import android.widget.TextView;
import androidx.appcompat.app.AppCompatActivity; import androidx.appcompat.app.AppCompatActivity;
import androidx.recyclerview.widget.DividerItemDecoration;
import androidx.recyclerview.widget.LinearLayoutManager; import androidx.recyclerview.widget.LinearLayoutManager;
import androidx.recyclerview.widget.RecyclerView; import androidx.recyclerview.widget.RecyclerView;
@ -53,7 +52,7 @@ public class ReviewsActivity extends AppCompatActivity {
RecyclerView reviewsList = findViewById(R.id.reviews_list); RecyclerView reviewsList = findViewById(R.id.reviews_list);
reviewsList.setLayoutManager(new LinearLayoutManager(this)); reviewsList.setLayoutManager(new LinearLayoutManager(this));
reviewsList.setAdapter(listViewAdapter); reviewsList.setAdapter(listViewAdapter);
reviewsList.addItemDecoration(new DividerItemDecoration(this, DividerItemDecoration.VERTICAL)); reviewsList.addItemDecoration(new CustomVerticalDivider(this));
@SuppressLint("StaticFieldLeak") @SuppressLint("StaticFieldLeak")
AsyncTask<Void, Void, List<CommunityReview>> asyncTask = loadReviewsTask AsyncTask<Void, Void, List<CommunityReview>> asyncTask = loadReviewsTask

4
app/src/main/res/layout/content_reviews.xml
View File

@ -25,8 +25,6 @@
<androidx.recyclerview.widget.RecyclerView <androidx.recyclerview.widget.RecyclerView
android:id="@+id/reviews_list" android:id="@+id/reviews_list"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent" />
android:paddingLeft="@dimen/item_padding"
android:paddingRight="@dimen/item_padding"/>
</LinearLayout> </LinearLayout>
</androidx.core.widget.NestedScrollView> </androidx.core.widget.NestedScrollView>

4
app/src/main/res/layout/review_item.xml
View File

@ -3,7 +3,9 @@
xmlns:tool="http://schemas.android.com/tools" xmlns:tool="http://schemas.android.com/tools"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal"> android:orientation="horizontal"
android:paddingLeft="@dimen/item_padding"
android:paddingRight="@dimen/item_padding">
<androidx.appcompat.widget.AppCompatImageView <androidx.appcompat.widget.AppCompatImageView
android:id="@+id/rating_icon" android:id="@+id/rating_icon"
android:layout_height="wrap_content" android:layout_height="wrap_content"

4
app/src/main/res/layout/reviews_summary.xml
View File

@ -42,7 +42,7 @@
<androidx.appcompat.widget.AppCompatImageView <androidx.appcompat.widget.AppCompatImageView
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="wrap_content"
android:src="@drawable/ic_thumbs_up_down_24dp" android:src="@drawable/ic_thumbs_up_down_24dp"
android:tint="@color/rateNeutral" /> android:tint="@color/rateNeutral" />
@ -65,7 +65,7 @@
<androidx.appcompat.widget.AppCompatImageView <androidx.appcompat.widget.AppCompatImageView
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="match_parent" android:layout_height="wrap_content"
android:src="@drawable/ic_thumb_up_24dp" android:src="@drawable/ic_thumb_up_24dp"
android:tint="@color/ratePositive" /> android:tint="@color/ratePositive" />