fix: avoid making memos public when disabled (#2816)

* fix: avoid making memos public when disabled in v2

* fix: avoid making memos public when disabled in v1
This commit is contained in:
Brilliant Hanabi
2024-01-22 20:51:33 +08:00
committed by GitHub
parent 024a818e91
commit 3a129d5cfb
2 changed files with 38 additions and 0 deletions

View File

@@ -325,6 +325,14 @@ func (s *APIV2Service) UpdateMemo(ctx context.Context, request *apiv2pb.UpdateMe
}
} else if path == "visibility" {
visibility := convertVisibilityToStore(request.Memo.Visibility)
// Find disable public memos system setting.
disablePublicMemosSystem, err := s.getDisablePublicMemosSystemSettingValue(ctx)
if err != nil {
return nil, status.Errorf(codes.Internal, "failed to get system setting")
}
if disablePublicMemosSystem && visibility == store.Public {
return nil, status.Errorf(codes.PermissionDenied, "disable public memos system setting is enabled")
}
update.Visibility = &visibility
} else if path == "row_status" {
rowStatus := convertRowStatusToStore(request.Memo.RowStatus)