From 8d8e671a073d2775e61090cce356e74563ecce47 Mon Sep 17 00:00:00 2001 From: Matt Baer Date: Tue, 19 Nov 2019 09:59:13 +0900 Subject: [PATCH] Fix suspension check in fetchPost() Previously, this check would return a "user not found" error when retrieving a collection post by its post ID, e.g. /api/posts/abc123 instead of /api/collections/demo/posts/my-slug -- this happens particularly when `Announce`ing a post in the fediverse. This change fixes that. --- posts.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/posts.go b/posts.go index 6410735..4891a8e 100644 --- a/posts.go +++ b/posts.go @@ -1039,7 +1039,6 @@ func pinPost(app *App, w http.ResponseWriter, r *http.Request) error { func fetchPost(app *App, w http.ResponseWriter, r *http.Request) error { var collID int64 - var ownerID int64 var coll *Collection var err error vars := mux.Vars(r) @@ -1055,14 +1054,13 @@ func fetchPost(app *App, w http.ResponseWriter, r *http.Request) error { return err } collID = coll.ID - ownerID = coll.OwnerID } p, err := app.db.GetPost(vars["post"], collID) if err != nil { return err } - suspended, err := app.db.IsUserSuspended(ownerID) + suspended, err := app.db.IsUserSuspended(p.OwnerID.Int64) if err != nil { log.Error("fetch post: %v", err) return ErrInternalGeneral