Writefreely/writefreely
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Updating oauth form validation per PR feedback. T712

Browse Source
This commit is contained in:
Nick Gerakines 2020-01-07 21:52:51 -05:00
parent 5e76565271
commit 6d79ed3cfd
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
oauth_signup.go
View File

@ -125,21 +125,18 @@ func (h oauthHandler) viewOauthSignup(app *App, w http.ResponseWriter, r *http.R
func (h oauthHandler) validateOauthSignup(r *http.Request) error { func (h oauthHandler) validateOauthSignup(r *http.Request) error {
username := r.FormValue(oauthParamUsername) username := r.FormValue(oauthParamUsername)
if len(username) < 5 { if len(username) < h.Config.App.MinUsernameLen {
return impart.HTTPError{Status: http.StatusBadRequest, Message: "Username is too short."} return impart.HTTPError{Status: http.StatusBadRequest, Message: "Username is too short."}
} }
if len(username) > 20 { if len(username) > 100 {
return impart.HTTPError{Status: http.StatusBadRequest, Message: "Username is too long."} return impart.HTTPError{Status: http.StatusBadRequest, Message: "Username is too long."}
} }
alias := r.FormValue(oauthParamAlias) alias := r.FormValue(oauthParamAlias)
if len(alias) < 5 { if len(alias) == 0 {
return impart.HTTPError{Status: http.StatusBadRequest, Message: "Alias is too short."} return impart.HTTPError{Status: http.StatusBadRequest, Message: "Alias is too short."}
} }
if len(alias) > 20 {
return impart.HTTPError{Status: http.StatusBadRequest, Message: "Alias is too long."}
}
password := r.FormValue("password") password := r.FormValue("password")
if len(password) < 5 { if len(password) == 0 {
return impart.HTTPError{Status: http.StatusBadRequest, Message: "Password is too short."} return impart.HTTPError{Status: http.StatusBadRequest, Message: "Password is too short."}
} }
email := r.FormValue(oauthParamEmail) email := r.FormValue(oauthParamEmail)