From 58d163d2e09a3ff4ed16670ac9aae77bc55ccf3a Mon Sep 17 00:00:00 2001 From: Matt Baer Date: Wed, 14 Nov 2018 18:30:24 -0500 Subject: [PATCH] Properly handle failed AP requests --- activitypub.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/activitypub.go b/activitypub.go index 53ddb52..502e59a 100644 --- a/activitypub.go +++ b/activitypub.go @@ -460,14 +460,13 @@ func makeActivityPost(p *activitystreams.Person, url string, m interface{}) erro } resp, err := http.DefaultClient.Do(r) + if err != nil { + return err + } if resp != nil && resp.Body != nil { defer resp.Body.Close() } - if resp == nil { - log.Error("No response.") - return fmt.Errorf("No resonse.") - } body, err := ioutil.ReadAll(resp.Body) if err != nil { return err @@ -497,6 +496,9 @@ func resolveIRI(url string) ([]byte, error) { } resp, err := http.DefaultClient.Do(r) + if err != nil { + return nil, err + } if resp != nil && resp.Body != nil { defer resp.Body.Close() }